Skip to content

fix: ensure showInactive actually shows#42226

Merged
VerteDinde merged 1 commit intomainfrom
fix-show-inactive
May 20, 2024
Merged

fix: ensure showInactive actually shows#42226
VerteDinde merged 1 commit intomainfrom
fix-show-inactive

Conversation

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented May 20, 2024

This aligns our API usage with Chromium and ensures that windows shown inactive that were initially hidden actually get painted to.

Notes: Fixed issue where windows made visible with showInactive were blank

@MarshallOfSound MarshallOfSound added semver/patch backwards-compatible bug fixes fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases target/31-x-y PR should also be added to the "31-x-y" branch. labels May 20, 2024
@VerteDinde VerteDinde merged commit 2e778a9 into main May 20, 2024
@VerteDinde VerteDinde deleted the fix-show-inactive branch May 20, 2024 21:12
@release-clerk
Copy link

release-clerk bot commented May 20, 2024

Release Notes Persisted

Fixed issue where windows made visible with showInactive were blank

@trop trop bot mentioned this pull request May 20, 2024
Merged
@trop
Copy link
Contributor

trop bot commented May 20, 2024

I have automatically backported this PR to "31-x-y", please check out #42227

@trop trop bot added in-flight/31-x-y merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/31-x-y PR should also be added to the "31-x-y" branch. in-flight/31-x-y labels May 20, 2024
@codebytere
Copy link
Member

codebytere commented Jul 19, 2024

@MarshallOfSound it looks like this broke it actually coming to the front 🤔 #42962

codebytere added a commit that referenced this pull request Jul 29, 2024
@codebytere
fix: showInactive window not showing
aedf4cb 
Refs #42226 and #43033
@codebytere codebytere mentioned this pull request Jul 29, 2024
Merged
3 tasks
codebytere added a commit that referenced this pull request Jul 30, 2024
@codebytere
fix: showInactive window not showing (#43079)
d09a2e5 
fix: showInactive window not showing

Refs #42226 and #43033
trop bot added a commit that referenced this pull request Jul 30, 2024
@trop @codebytere
fix: showInactive window not showing
1c54b7a 
Refs #42226 and #43033

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
trop bot added a commit that referenced this pull request Jul 30, 2024
@trop @codebytere
fix: showInactive window not showing
694213d 
Refs #42226 and #43033

Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
ckerr pushed a commit that referenced this pull request Jul 30, 2024
@trop @codebytere
fix: showInactive window not showing (#43103)
b50702a 
fix: showInactive window not showing

Refs #42226 and #43033

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
ckerr pushed a commit that referenced this pull request Jul 30, 2024
@trop @codebytere
fix: showInactive window not showing (#43102)
35b7351 
fix: showInactive window not showing

Refs #42226 and #43033

Co-authored-by: trop[bot] <37223003+trop[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

No one assigned

Labels

fast-track 🚅 Indicates that this PR is intended to bypass the 24 hour rule. Needs approval from Releases merged/31-x-y PR was merged to the "31-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarshallOfSound @codebytere @VerteDinde