Skip to content

fix: showInactive window not showing#43079

Merged
codebytere merged 1 commit intomainfrom
fix-showactive
Jul 30, 2024
Merged

fix: showInactive window not showing#43079
codebytere merged 1 commit intomainfrom
fix-showactive

Conversation

@codebytere
Copy link
Member

Description of Change

Closes #42962
Refs #42226
Refs #43033

Fixes showInactive window not showing - we don't need to use orderFrontKeepWindowKeyState after reverting #43033

Checklist

Release Notes

Notes: Fixed an issue where calling window.showInactive on macOS did not actually show the window.

@codebytere codebytere added semver/patch backwards-compatible bug fixes target/31-x-y PR should also be added to the "31-x-y" branch. target/32-x-y PR should also be added to the "32-x-y" branch. labels Jul 29, 2024
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 29, 2024
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 30, 2024
@codebytere codebytere merged commit d09a2e5 into main Jul 30, 2024
@codebytere codebytere deleted the fix-showactive branch July 30, 2024 10:37
@release-clerk
Copy link

release-clerk bot commented Jul 30, 2024

Release Notes Persisted

Fixed an issue where calling window.showInactive on macOS did not actually show the window.

@trop
Copy link
Contributor

trop bot commented Jul 30, 2024

I have automatically backported this PR to "31-x-y", please check out #43102

@trop trop bot added in-flight/31-x-y and removed target/31-x-y PR should also be added to the "31-x-y" branch. labels Jul 30, 2024
@trop
Copy link
Contributor

trop bot commented Jul 30, 2024

I have automatically backported this PR to "32-x-y", please check out #43103

@trop trop bot added in-flight/32-x-y merged/32-x-y PR was merged to the "32-x-y" branch. merged/31-x-y PR was merged to the "31-x-y" branch. and removed target/32-x-y PR should also be added to the "32-x-y" branch. in-flight/32-x-y in-flight/31-x-y labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/31-x-y PR was merged to the "31-x-y" branch. merged/32-x-y PR was merged to the "32-x-y" branch. semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: BrowserWindow.showInactive not working anymore on macOS

2 participants