build: roll Mantle and remove patch#38437
Merged
Merged
Conversation
Member
|
The jump between the revisions is quite big. Given this is a dependency of Squirrel.mac, are our current auto updater tests sufficient to verify this bump or should we need squirrel.mac tests to be run to confirm ? |
5efdbc5 to
ebec9b3
Compare
efc2b67 to
24bcea5
Compare
24bcea5 to
fd3fa9b
Compare
Member
|
@codebytere it seems like this is something we would still want to land, do you agree? If so, what needs to happen to move this PR forward? |
Member
Author
|
@ckerr yes I'd still like to! frankly I think it's always going to be a bit of a risk but we can always revert it if it causes issues. |
2ba4b25 to
0c9a5ac
Compare
0c9a5ac to
8c53754
Compare
8c53754 to
f335dfb
Compare
jkleinsc
approved these changes
Nov 10, 2025
deepak1556
approved these changes
Nov 11, 2025
deepak1556
left a comment
Member
There was a problem hiding this comment.
It would be nice at some point to run squirrel.mac tests since we are building it ourselves similar to what we do for nan or node.js, adds another layer of confidence to changes as this.
|
No Release Notes |
nilayarya
pushed a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
nilayarya
added a commit
to nilayarya/electron
that referenced
this pull request
Nov 21, 2025
3 tasks
VerteDinde
added a commit
that referenced
this pull request
Feb 28, 2026
This reverts commit 11d1743.
4 tasks
jkleinsc
pushed a commit
that referenced
this pull request
Mar 2, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR rolls Mantle to
2a8e212. This pulls in upstream fixes and improvements as well as allowing us to remove a patch we've floated to compensate for extremely outdated code it previously contained.Checklist
npm testpassesRelease Notes
Notes: none