fix: revert "build: roll Mantle and remove patch"#49978
Merged
Conversation
This reverts commit 11d1743.
4 tasks
codebytere
approved these changes
Mar 2, 2026
jkleinsc
approved these changes
Mar 2, 2026
|
Release Notes Persisted
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Partially addresses #49977 for the Electron 41 release.
After bumping Mantle, we're seeing several errors in SQRLShipItRequest that are seemingly related to the upstream changes. This PR reverts commit 11d1743 for Electron 41 specifically - we can re-enable code-signing tests and try to keep the Mantle roll forward for Electron 42.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where Squirrel.Mac's auto updater would fail to install new updates if the targetBundleURL was either not set or contained special characters.