Skip to content

fix: allow contextmenu event in draggable regions#37394

Merged
VerteDinde merged 1 commit into23-x-yfrom
trop/23-x-y-bp-fix-allow-contextmenu-event-in-draggable-regions-1677197144697
Feb 27, 2023
Merged

fix: allow contextmenu event in draggable regions#37394
VerteDinde merged 1 commit into23-x-yfrom
trop/23-x-y-bp-fix-allow-contextmenu-event-in-draggable-regions-1677197144697

Conversation

@trop
Copy link
Contributor

@trop trop bot commented Feb 24, 2023

Backport of #37386

See that PR for details.

Notes: Fixed right-click events not being delivered in frameless window draggable regions.

Co-authored-by: Jeremy Rose <jeremya@chromium.org>
@trop trop bot requested a review from nornagon February 24, 2023 00:05
@trop trop bot added 23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Feb 24, 2023
@VerteDinde VerteDinde merged commit 38f4017 into 23-x-y Feb 27, 2023
@VerteDinde VerteDinde deleted the trop/23-x-y-bp-fix-allow-contextmenu-event-in-draggable-regions-1677197144697 branch February 27, 2023 05:24
@release-clerk
Copy link

release-clerk bot commented Feb 27, 2023

Release Notes Persisted

Fixed right-click events not being delivered in frameless window draggable regions.

vikunja-bot pushed a commit to go-vikunja/desktop that referenced this pull request Mar 3, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [electron](https://github.com/electron/electron) | devDependencies | patch | [`23.1.1` -> `23.1.2`](https://renovatebot.com/diffs/npm/electron/23.1.1/23.1.2) |

---

### Release Notes

<details>
<summary>electron/electron</summary>

### [`v23.1.2`](https://github.com/electron/electron/releases/tag/v23.1.2)

[Compare Source](electron/electron@v23.1.1...v23.1.2)

### Release Notes for v23.1.2

#### Fixes

-   Fixed `destroyed` event not emitted on `close` for `BrowserView.webContents`. [#&#8203;37451](electron/electron#37451) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37450))</span>
-   Fixed an incorrect result returned when using secure as a cookies filter. [#&#8203;37248](electron/electron#37248) <span style="font-size:small;">(Also in [22](electron/electron#37247), [24](https://github.com/electron/electron/pull/37246))</span>
-   Fixed an issue where `minWidth`/`minHeight` and `maxWidth`/`maxHeight` would not be enforced if the user set an `aspectRatio` on macOS. [#&#8203;37457](electron/electron#37457) <span style="font-size:small;">(Also in [22](electron/electron#37458), [24](https://github.com/electron/electron/pull/37456))</span>
-   Fixed an issue where passing both `hasReply` and `actions` to a main process Notification on macOS resulted in the first action being obscured and unavailable. [#&#8203;37448](electron/electron#37448) <span style="font-size:small;">(Also in [22](electron/electron#37447), [24](https://github.com/electron/electron/pull/37449))</span>
-   Fixed draggable regions not working in Mac App Store builds. [#&#8203;37473](electron/electron#37473) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37474))</span>
-   Fixed right-click events not being delivered in frameless window draggable regions. [#&#8203;37394](electron/electron#37394) <span style="font-size:small;">(Also in [24](https://github.com/electron/electron/pull/37395))</span>

#### Other Changes

-   Improved error messages for `contents.takeHeapSnapshot`. [#&#8203;37460](electron/electron#37460) <span style="font-size:small;">(Also in [22](electron/electron#37459), [24](https://github.com/electron/electron/pull/37461))</span>
-   Updated Chromium to 110.0.5481.177. [#&#8203;37389](electron/electron#37389)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuMiIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC4yIn0=-->

Reviewed-on: https://kolaente.dev/vikunja/desktop/pulls/140
Co-authored-by: renovate <renovatebot@kolaente.de>
Co-committed-by: renovate <renovatebot@kolaente.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

23-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant