Skip to content

fix: allow contextmenu event in draggable regions#37386

Merged
nornagon merged 1 commit intomainfrom
fix-draggable-region-context-menu
Feb 24, 2023
Merged

fix: allow contextmenu event in draggable regions#37386
nornagon merged 1 commit intomainfrom
fix-draggable-region-context-menu

Conversation

@nornagon
Copy link
Contributor

@nornagon nornagon commented Feb 23, 2023 •
edited
Loading

Description of Change

The change in #35603 made it so that right-click events in draggable regions
stopped being delivered to the web content, and were only delivered to the
browser. This adds some hacks to preserve that behavior, though I'm not sure
this is the best way forward. I feel like it might be better to expose
system-context-menu on macOS instead, and have right-clicks in
draggable regions trigger that event.

However, that would break backwards compatibility. I'd rather only do that
intentionally, so this PR for now preserves the old behavior.

Fixes #37301.

Checklist

Release Notes

Notes: Fixed right-click events not being delivered in frameless window draggable regions.

@nornagon nornagon added semver/patch backwards-compatible bug fixes target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. labels Feb 23, 2023
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Feb 23, 2023
This was referenced Feb 23, 2023
Closed
Closed
@nornagon nornagon merged commit e27905c into main Feb 24, 2023
@nornagon nornagon deleted the fix-draggable-region-context-menu branch February 24, 2023 00:05
@release-clerk
Copy link

release-clerk bot commented Feb 24, 2023

Release Notes Persisted

Fixed right-click events not being delivered in frameless window draggable regions.

This was referenced Feb 24, 2023
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Feb 24, 2023

I have automatically backported this PR to "23-x-y", please check out #37394

@trop
Copy link
Contributor

trop bot commented Feb 24, 2023

I have automatically backported this PR to "24-x-y", please check out #37395

@trop trop bot added in-flight/24-x-y merged/24-x-y PR was merged to the "24-x-y" branch merged/23-x-y PR was merged to the "23-x-y" branch. and removed target/23-x-y PR should also be added to the "23-x-y" branch. target/24-x-y PR should also be added to the "24-x-y" branch. in-flight/24-x-y labels Feb 24, 2023
gecko19 pushed a commit to brightsign/electron that referenced this pull request Feb 28, 2023
@nornagon @gecko19
fix: allow contextmenu event in draggable regions (electron#37386)
b0a03a0
@nornagon nornagon mentioned this pull request Mar 2, 2023
Closed
3 tasks
@codebytere codebytere mentioned this pull request May 8, 2023
Closed
3 tasks
@commit-lint commit-lint bot mentioned this pull request May 24, 2023
Open
@nornagon nornagon mentioned this pull request Feb 13, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codebytere codebytere codebytere approved these changes

@VerteDinde VerteDinde VerteDinde approved these changes

Assignees

No one assigned

Labels

merged/23-x-y PR was merged to the "23-x-y" branch. merged/24-x-y PR was merged to the "24-x-y" branch new-pr 🌱 PR opened recently semver/patch backwards-compatible bug fixes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: context menus cannot be displayed when "-webkit-app-region: drag" is enabled

3 participants

@nornagon @codebytere @VerteDinde