fix: BrowserWindow transparency not working#30136
Merged
codebytere merged 1 commit intomainfrom Jul 15, 2021
Merged
Conversation
nornagon
approved these changes
Jul 14, 2021
Contributor
nornagon
left a comment
There was a problem hiding this comment.
This seems to break fairly frequently... is there some way we could test this? With desktopCapturer perhaps? 😬
ckerr
reviewed
Jul 14, 2021
103ca40 to
6a67c62
Compare
ckerr
approved these changes
Jul 14, 2021
jkleinsc
approved these changes
Jul 14, 2021
MarshallOfSound
approved these changes
Jul 14, 2021
VerteDinde
approved these changes
Jul 15, 2021
Member
Author
|
Failure not germane. |
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "14-x-y", please check out #30159 |
|
This appears to still be broken in latest v14 beta and v15 alpha versions :( Works on current v13 stable though. |
BlackHole1
pushed a commit
to BlackHole1/electron
that referenced
this pull request
Aug 30, 2021
This was referenced Aug 30, 2021
5 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Closes #30082.
Fixes an issue where BrowserWindows would not properly honor
transparency: trueor abackgroundColorbeing set in their constructor options. This happened as a result of this CL rolled into Electron via #29751. The new methodSetPageBaseBackgroundColorset the default content background color - i.e, the color that would appear behind the content unless the content overrode it. What then happened was that when we changed our logic to call this method, it was eventually overridden by Blink, and so would show as transparent or with the supplied color for a flash and then revert to white. We fix this by directly calling the background color method inRenderWidgetHostViewBase.Tested with https://gist.github.com/b52f026c763057f97f745fade82758fd.
Checklist
npm testpassesRelease Notes
Notes: Fixed an issue where BrowserWindows would not properly honor
transparency: trueor abackgroundColorbeing set in their constructor options.