Skip to content

chore: bump chromium to 93.0.4550.0 (main)#29751

Merged
nornagon merged 31 commits intomainfrom
roller/chromium/main
Jun 22, 2021
Merged

chore: bump chromium to 93.0.4550.0 (main)#29751
nornagon merged 31 commits intomainfrom
roller/chromium/main

Conversation

@electron-roller
Copy link
Copy Markdown
Contributor

@electron-roller electron-roller bot commented Jun 17, 2021

Updating Chromium to 93.0.4550.0.

See all changes in 93.0.4539.0..93.0.4550.0

Notes: Updated Chromium to 93.0.4550.0.

@electron-roller electron-roller bot requested a review from a team as a code owner June 17, 2021 13:01
@electron-roller electron-roller bot added backport-check-skip Skip trop's backport validity checking no-backport semver/patch backwards-compatible bug fixes labels Jun 17, 2021
@electron-roller electron-roller bot changed the title chore: bump chromium to 93.0.4545.0 (main) chore: bump chromium to 93.0.4546.0 (main) Jun 18, 2021
@nornagon nornagon force-pushed the roller/chromium/main branch from fa6cc95 to 259e8f9 Compare June 18, 2021 17:22
@electron-roller electron-roller bot changed the title chore: bump chromium to 93.0.4546.0 (main) chore: bump chromium to 93.0.4547.0 (main) Jun 19, 2021
@electron-roller electron-roller bot changed the title chore: bump chromium to 93.0.4547.0 (main) chore: bump chromium to 93.0.4548.0 (main) Jun 20, 2021
@electron-roller electron-roller bot changed the title chore: bump chromium to 93.0.4548.0 (main) chore: bump chromium to 93.0.4549.0 (main) Jun 21, 2021
@nornagon
Copy link
Copy Markdown
Contributor

ASan failure looks real, probably related to 73cfd82.

@electron-roller electron-roller bot changed the title chore: bump chromium to 93.0.4546.0 (main) chore: bump chromium to 93.0.4550.0 (main) Jun 22, 2021
Copy link
Copy Markdown
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Took a longer look at the changes to background color, since that was a huge CR. I tested child window inheriting background color and transparency with a Fiddle from an older (resolved) issue, just to be safe, and everything seems to be working as expected. 🙂

@nornagon
Copy link
Copy Markdown
Contributor

Since @jkleinsc is on vacation and the woa build seems to be ever-queued, I'm going to land this. We can follow up with fixes if woa turns out to be broken.

@nornagon nornagon closed this Jun 22, 2021
@nornagon nornagon reopened this Jun 22, 2021
@nornagon nornagon merged commit b8261f1 into main Jun 22, 2021
@nornagon nornagon deleted the roller/chromium/main branch June 22, 2021 19:17
@release-clerk
Copy link
Copy Markdown

release-clerk bot commented Jun 22, 2021

Release Notes Persisted

Updated Chromium to 93.0.4550.0.

@nornagon
Copy link
Copy Markdown
Contributor

/trop run backport-to 14-x-y

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Jun 23, 2021

The backport process for this PR has been manually initiated - sending your PR to 14-x-y!

@trop
Copy link
Copy Markdown
Contributor

trop bot commented Jun 23, 2021

I was unable to backport this PR to "14-x-y" cleanly;
you will need to perform this backport manually.

@nornagon
Copy link
Copy Markdown
Contributor

ah, because #29756 hasn't landed yet :?

@trop trop bot added the merged/14-x-y label Jun 29, 2021
deepak1556 added a commit that referenced this pull request Jun 29, 2021
* chore: bump chromium to 93.0.4550.0 (main) (#29751)

* chore: bump chromium to 93.0.4552.0 (main) (#29862)

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>

Co-authored-by: deepak1556 <hop2deep@gmail.com>
Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: PatchUp <73610968+patchup[bot]@users.noreply.github.com>
Co-authored-by: Charles Kerr <charles@charleskerr.com>
BlackHole1 pushed a commit to BlackHole1/electron that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-check-skip Skip trop's backport validity checking no-backport semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants