chore: bump chromium to 93.0.4539.0 (14-x-y)#29756
Closed
chore: bump chromium to 93.0.4539.0 (14-x-y)#29756
Conversation
This is intended as an interm change. See patch for details.
…eManagerModel Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2894511 Xref: 5853833 is the interim patch that restores AdaptCallbackForRepeating in Electron until all its uses can be removed.
…LLoaderFactory Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2937315 is the sibling upstream change to ProxyingURLLoaderFactory Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2941842 is the commit that removes AdaptCallbackForRepeating Xref: 5853833 is the interim patch that restores AdaptCallbackForRepeating in Electron until all its uses can be removed.
…CertificateError() Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2941842 is the commit that removes AdaptCallbackForRepeating Xref: 5853833 is the interim patch that restores AdaptCallbackForRepeating in Electron until all its uses can be removed.
…ssionHelper Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2941842 is the commit that removes AdaptCallbackForRepeating Xref: 5853833 is the interim patch that restores AdaptCallbackForRepeating in Electron until all its uses can be removed.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2941842 is the commit that removes AdaptCallbackForRepeating Xref: 5853833 is the interim patch that restores AdaptCallbackForRepeating in Electron until all its uses can be removed.
…e_integrity.patch
…to_multibuffer_data_source.patch
Fix sort order to make linter happy
…p::AllowCertificateError()" This reverts commit d3c97a0. As per discussion @ #29608 (review)
…esource_integrity.patch" This reverts commit a878180 (initial) This reverts commit ec4e10c (fixup) Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2952503 Upstream reverted a change that affected our patch. This PR reverts our patch.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2416811 The signature for HandleExternalProtocol() got tweaked upstream.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2944338 Electron has had a `GetCompositor()` method in this class since #7104. Upstream just added a virtual GetCompositor() to parent class RenderWidgetHostViewBase, so mark ours as 'override' and move its declaration + implementation to the 'overrides RenderWidgetHostViewBase' sections of our .h, .cc.
Refs: https://chromium-review.googlesource.com/c/chromium/src/+/2941842 removes AdaptCallbackForRepeating upstream. 5853833 is the interim patch that restores it in Electron until Electrons' use of the API is settled. This PR fixes a wart that prevented move-only args from being passed to Emit(). OnceCallbacks are not copyable, so the workaround for Emitting a callback was to first run it through AdadptCallbackForRepeating() since RepeatingCallbacks are copyable. The issue is that the move-only converter in std_converter.h was not always (ever?) visible to event_emitter_caller.h. Including the former in the latter fixes Emit(move-only-arg) so the AdaptCallbackForRepeating workaround is no longer needed.
This reverts commit cb0afda. Experimental commit to find the cause of the asan failure
nornagon
approved these changes
Jun 17, 2021
…-4539-0-main--1623949742421
Contributor
|
hmmm trop done goofed on this one and missed like half the commits from #29608. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #29608
See that PR for details.
Notes: Updated Chromium to 93.0.4539.0.