feat: enable context isolation by default #27949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loads native modules when navigation happens
jkleinsc
approved these changes
Mar 1, 2021
VerteDinde
approved these changes
Mar 1, 2021
MarshallOfSound
approved these changes
Mar 1, 2021
codebytere
approved these changes
Mar 1, 2021
Member
|
Merging as CI failures are known flakes unrelated to this PR. |
|
Release Notes Persisted
|
undergroundwires
added a commit
to undergroundwires/privacy.sexy
that referenced
this pull request
Mar 11, 2021
- fix npm vulnerabilities #62 - change ResizeObserver polyfill dependency que-etc/resize-observer-polyfill#80 - bump typescript to 4.2.x and add tslib for importing helpers - update electron to v12.x and set contextIsolation to false (nklayman/vue-cli-plugin-electron-builder#1285, electron/electron#11608) to reach node APIs as it's now disabled by default (electron/electron#27949)
sanosdole
added a commit
to sanosdole/nodeclrhost
that referenced
this pull request
Mar 30, 2021
Implement support for Electron 12. Major changes: - [node #30782](nodejs/node#30782) New ArrayBuffer backing store prevents reusing the same data pointer - [electron #27949](electron/electron#27949) Context isolation is turned on by default and prevents `coreclr-hosting` from working properly - [electron #18397](electron/electron#18397) & [electron #454](maximegris/angular-electron#454) lead to `app.allowRendererProcessReuse` being fixed to true on Electron 12. This required making `coreclr-hosting` context aware and implement proper re-use of the hosted CLR. Known Issues: - After reloading a renderer app the task scheduler sometimes hangs up, as the the `ThreadSafeFunction` does not get invoked. Code cleanup and small memory management improvements.
panzy
added a commit
to panzy/electron-process-manager
that referenced
this pull request
Jul 19, 2021
…tions. See also breaking change electron/electron#27949
36 tasks
3 tasks
LarrMarburger
pushed a commit
to LarrMarburger/privacy.sexy
that referenced
this pull request
Nov 16, 2023
- fix npm vulnerabilities #62 - change ResizeObserver polyfill dependency que-etc/resize-observer-polyfill#80 - bump typescript to 4.2.x and add tslib for importing helpers - update electron to v12.x and set contextIsolation to false (nklayman/vue-cli-plugin-electron-builder#1285, electron/electron#11608) to reach node APIs as it's now disabled by default (electron/electron#27949)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #26890
See that PR for details.
Notes: Changed the default value of
contextIsolationtotrue.