feat: enable context isolation by default #26890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Should there be any docs changes included along with this? |
miniak
reviewed
Dec 16, 2020
Randomstand
approved these changes
Jan 30, 2021
47d399d to
07234f6
Compare
bdb5f05 to
f3559bb
Compare
codebytere
previously approved these changes
Feb 26, 2021
Member
|
Appears the visibility state tests are struggling on macOS |
… loads native modules when navigation happens
VerteDinde
approved these changes
Mar 1, 2021
codebytere
approved these changes
Mar 1, 2021
jkleinsc
approved these changes
Mar 1, 2021
|
Release Notes Persisted
|
Contributor
|
I have automatically backported this PR to "12-x-y", please check out #27949 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the plan in #23506 and in the breaking changes document, lets enable context isolation by default in Electron 12.
Notes: Changed the default value of
contextIsolationtotrue.