Skip to content

fix: temporarily remove yamux#195

Merged
alanshaw merged 1 commit intomainfrom
fix/temporarily-remove-yamux
Feb 28, 2023
Merged

fix: temporarily remove yamux#195
alanshaw merged 1 commit intomainfrom
fix/temporarily-remove-yamux

Conversation

@alanshaw
Copy link
Copy Markdown
Member

This is the only other thing that has been added to the libp2p config recently.

Copy link
Copy Markdown
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -68,7 +68,7 @@ async function startService ({ peerId, port, peerAnnounceAddr, awsClient, connec
maxOutboundStreams: connectionConfig.mplex.maxOutboundStreams,
maxStreamBufferSize: connectionConfig.mplex.maxStreamBufferSize
}),
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}),
})

@alanshaw alanshaw merged commit 86cf5d5 into main Feb 28, 2023
@alanshaw alanshaw deleted the fix/temporarily-remove-yamux branch February 28, 2023 09:38
alanshaw pushed a commit that referenced this pull request Sep 18, 2023
This PR re-enables yamux in E-IPFS. Some historical context:

1. E-IPFS release with yamux made all pods unstable. We reverted adding
yamux in #195 and
created issue ChainSafe/js-libp2p-yamux#23
2. In the meantime this issue was addressed
ChainSafe/js-libp2p-yamux#25

Please note that deploying this needs attention and we should monitor
and perform canary release.

Closes elastic-ipfs/elastic-ipfs#25

Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants