Merged
Conversation
github-actions Bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
## [3.0.7](v3.0.6...v3.0.7) (2023-03-01) ### Bug Fixes * catch stream sink errors ([#25](#25)) ([7c7fd07](7c7fd07))
|
🎉 This PR is included in version 3.0.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
alanshaw
pushed a commit
to elastic-ipfs/bitswap-peer
that referenced
this pull request
Sep 18, 2023
This PR re-enables yamux in E-IPFS. Some historical context: 1. E-IPFS release with yamux made all pods unstable. We reverted adding yamux in #195 and created issue ChainSafe/js-libp2p-yamux#23 2. In the meantime this issue was addressed ChainSafe/js-libp2p-yamux#25 Please note that deploying this needs attention and we should monitor and perform canary release. Closes elastic-ipfs/elastic-ipfs#25 Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #23
The stream sink did not catch its own errors. This can lead to a situation where a thrown error can be unhandled.