Remove username/password from elastic-agent#1423
Merged
michel-laterman merged 6 commits intoelastic:mainfrom Jan 6, 2022
Merged
Remove username/password from elastic-agent#1423michel-laterman merged 6 commits intoelastic:mainfrom
michel-laterman merged 6 commits intoelastic:mainfrom
Conversation
|
A documentation preview will be available soon: |
michel-laterman
commented
Dec 23, 2021
|
|
||
| // ============================================================================= | ||
|
|
||
| // tag::es-username[] |
Contributor
Author
There was a problem hiding this comment.
The es-username tag and es-password tag are not being removed as they are used by the standalone kubernetes config (i think for the agent to send data into es)
michel-laterman
commented
Jan 5, 2022
|
|
||
| | (string) The basic authentication username used to connect to {kib} and enable {fleet}. | ||
| Overrides `KIBANA_USERNAME` when set. | ||
| | (string) The basic authentication username used to connect to {kib} and retrieve a `service_token` to enable {fleet}. |
Contributor
Author
There was a problem hiding this comment.
@dedemorton, I've changed the behaviour of KIBANA_FLEET_USERNAME and ELASTICSEARCH_USERNAME with elastic/beats#29651, should I update the deprecation tags I added for 7.17 to reflect this?
Contributor
There was a problem hiding this comment.
Yes, if you don't mind. Thanks!
Contributor
|
@dedemorton @michel-laterman are we good to merge this PR then? |
Contributor
|
No, just give me a little time today to do a proper review. Thanks! |
dedemorton
approved these changes
Jan 6, 2022
Contributor
dedemorton
left a comment
There was a problem hiding this comment.
LGTM! Thanks for updating the docs.
mergify bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
* Remove username/password from elastic-agent * Remove broken references, add es-username/password for k8s * Update to specify new behaviour * fix swp file * add k8s env vars (cherry picked from commit 44d199c)
michel-laterman
added a commit
that referenced
this pull request
Jan 10, 2022
* Remove username/password from elastic-agent * Remove broken references, add es-username/password for k8s * Update to specify new behaviour * fix swp file * add k8s env vars (cherry picked from commit 44d199c) Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
bmorelli25
pushed a commit
to bmorelli25/observability-docs
that referenced
this pull request
Apr 11, 2023
* Remove username/password from elastic-agent * Remove broken references, add es-username/password for k8s * Update to specify new behaviour * fix swp file * add k8s env vars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove username/password env vars for the elastic-agent as it is removed from use in fleet-server.
PRs:
deprecation PR: #1409
Issue: elastic/fleet-server#978
Closes: elastic/fleet-server#978