Skip to content

Remove references to username/password#29458

Merged
michel-laterman merged 3 commits intoelastic:masterfrom
michel-laterman:agent-remove-password
Dec 23, 2021
Merged

Remove references to username/password#29458
michel-laterman merged 3 commits intoelastic:masterfrom
michel-laterman:agent-remove-password

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

@michel-laterman michel-laterman commented Dec 15, 2021 •
edited
Loading

What does this PR do?

Remove the use of username/password for authenication

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Create an 8.1 cluster and use a snapshot of the fleet-server from elastic/fleet-server#1006

Related issues

@michel-laterman michel-laterman added cleanup backport-v8.0.0 Automated backport with mergify Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Dec 15, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 15, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 15, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-12-22T20:38:29.844+0000

  • Duration: 99 min 29 sec

  • Commit: 47181e3

Test stats 🧪

Test Results
Failed 0
Passed 7120
Skipped 16
Total 7136

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@michel-laterman michel-laterman mentioned this pull request Dec 16, 2021
Merged
4 tasks
@michel-laterman michel-laterman mentioned this pull request Dec 22, 2021
Merged
@michel-laterman michel-laterman marked this pull request as ready for review December 22, 2021 20:56
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 22, 2021

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23 jlind23 requested a review from a team December 23, 2021 10:07
@michel-laterman michel-laterman merged commit bea8e45 into elastic:master Dec 23, 2021
@michel-laterman michel-laterman deleted the agent-remove-password branch December 23, 2021 17:22
mergify bot pushed a commit that referenced this pull request Dec 23, 2021
@michel-laterman
Remove references to username/password (#29458)
9a2e8ca 
* Remove references to username/password

* restore ouput username/password

* Update CHANGELOG

(cherry picked from commit bea8e45)
@mergify mergify bot mentioned this pull request Dec 23, 2021
Merged
michel-laterman added a commit that referenced this pull request Dec 23, 2021
@mergify @michel-laterman
Remove references to username/password (#29458) (#29599)
5ae6765 
* Remove references to username/password

* restore ouput username/password

* Update CHANGELOG

(cherry picked from commit bea8e45)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

Assignees

No one assigned

Labels

backport-v8.0.0 Automated backport with mergify cleanup Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michel-laterman @elasticmachine @AndersonQ @jlind23