Skip to content

Ensure elasticsearch logs and data dirs exist before startup#17531

Merged
mashhurs merged 1 commit intoelastic:mainfrom
donoghuc:test-elasticsearch-setup-improvement
Apr 9, 2025
Merged

Ensure elasticsearch logs and data dirs exist before startup#17531
mashhurs merged 1 commit intoelastic:mainfrom
donoghuc:test-elasticsearch-setup-improvement

Conversation

@donoghuc
Copy link
Copy Markdown
Member

@donoghuc donoghuc commented Apr 9, 2025 •
edited
Loading

Release notes

[rn:skip]

What does this PR do?

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed

logstash/qa/integration/services/elasticsearch_teardown.sh

Lines 26 to 27 in 712b37e

rm -rf /tmp/ls_integration/es-data
rm -rf /tmp/ls_integration/es-logs

Why is it important/What is the impact to the user?

N/A

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Apr 9, 2025

This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • backport-8.x is the label to automatically backport to the 8.x branch.
  • If no backport is necessary, please add the backport-skip label

@donoghuc donoghuc mentioned this pull request Apr 9, 2025
Merged
@donoghuc
Ensure elasticsearch logs and data dirs exist before startup
5230808 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27
@donoghuc donoghuc force-pushed the test-elasticsearch-setup-improvement branch from bcb8415 to 5230808 Compare April 9, 2025 20:03
@donoghuc donoghuc changed the title WIP: Test assumption in CI Ensure elasticsearch logs and data dirs exist before startup Apr 9, 2025
@donoghuc donoghuc marked this pull request as ready for review April 9, 2025 20:06
@donoghuc donoghuc added the backport-active-all Automated backport with mergify to all the active branches label Apr 9, 2025
mashhurs
mashhurs approved these changes Apr 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@mashhurs mashhurs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI.

@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube bot commented Apr 9, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

elasticmachine commented Apr 9, 2025

💚 Build Succeeded

History

@mashhurs mashhurs merged commit 8e6e183 into elastic:main Apr 9, 2025
9 checks passed
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
@donoghuc @mergify
Ensure elasticsearch logs and data dirs exist before startup (#17531)
8bd7b81 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)
@mergify mergify bot mentioned this pull request Apr 9, 2025
Merged
1 task
@mashhurs mashhurs mentioned this pull request Apr 9, 2025
Merged
3 tasks
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
@donoghuc @mergify
Ensure elasticsearch logs and data dirs exist before startup (#17531)
9b41933 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)
@mergify mergify bot mentioned this pull request Apr 9, 2025
Merged
1 task
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
@donoghuc @mergify
Ensure elasticsearch logs and data dirs exist before startup (#17531)
88e7990 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)
@mergify mergify bot mentioned this pull request Apr 9, 2025
Merged
1 task
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
@donoghuc @mergify
Ensure elasticsearch logs and data dirs exist before startup (#17531)
2941356 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)
@mergify mergify bot mentioned this pull request Apr 9, 2025
Merged
1 task
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
@donoghuc @mergify
Ensure elasticsearch logs and data dirs exist before startup (#17531)
d0a06f8 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)
mergify bot pushed a commit that referenced this pull request Apr 9, 2025
@donoghuc @mergify
Ensure elasticsearch logs and data dirs exist before startup (#17531)
77f9caa 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

# Conflicts:
#	qa/integration/services/elasticsearch_setup.sh
This was referenced Apr 9, 2025
Merged
Merged
donoghuc added a commit that referenced this pull request Apr 9, 2025
@mergify @donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531) (…
d7e38e5 
…#17533)

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Apr 9, 2025
@mergify @donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531) (…
d2d078a 
…#17536)

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Apr 9, 2025
@mergify @donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531) (…
6bd549d 
…#17537)

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Apr 9, 2025
@mergify @donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531) (…
acb8247 
…#17534)

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Apr 9, 2025
@donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531)
778c28b 
With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)
donoghuc added a commit that referenced this pull request Apr 9, 2025
@mergify @donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531) (…
c75b5a3 
…#17535)

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc added a commit that referenced this pull request Apr 10, 2025
@mergify @donoghuc
Ensure elasticsearch logs and data dirs exist before startup (#17531) (…
4dd7c05 
…#17538)

With a recent change in ES elastic/elasticsearch#125449
configuring path.data or path.logs to directories that do not exist cause ES to
not be able to start up. This commit ensures those directories exist. The
teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27

(cherry picked from commit 8e6e183)

Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashhurs mashhurs mashhurs approved these changes

Assignees

No one assigned

Labels

backport-active-all Automated backport with mergify to all the active branches

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donoghuc @elasticmachine @mashhurs