Simplify entitlement rest test discovery#125449
Merged
rjernst merged 4 commits intoelastic:mainfrom Apr 9, 2025
Merged
Conversation
This commit cleans up how entitlement test methods are discovered. It also adds another robustness check to ensure an annotation doesn't exist on a private method.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
reviewed
Apr 9, 2025
| getTestEntries(entries, testClass, a -> a.fromJavaVersion() == null || Runtime.version().feature() >= a.fromJavaVersion()); | ||
| } | ||
| @SuppressWarnings("unchecked") | ||
| Entry<String, CheckAction>[] entriesArray = entries.toArray(new Entry[0]); |
Contributor
There was a problem hiding this comment.
@rjernst this doesn't compile atm
warning: [rawtypes] found raw type: Entry
--
| Entry<String, CheckAction>[] entriesArray = entries.toArray(new Entry[0]);
Member
Author
There was a problem hiding this comment.
Oops. I've brought this PR up to date now and fixed this warning, see 647f97d
|
No utilizo elastic |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 9, 2025
This commit cleans up how entitlement test methods are discovered. It also adds another robustness check to ensure an annotation doesn't exist on a private method.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 9, 2025
This commit cleans up how entitlement test methods are discovered. It also adds another robustness check to ensure an annotation doesn't exist on a private method.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Apr 9, 2025
This commit cleans up how entitlement test methods are discovered. It also adds another robustness check to ensure an annotation doesn't exist on a private method.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 9, 2025
donoghuc
added a commit
to donoghuc/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27
1 task
mashhurs
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27
mergify bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183)
1 task
mergify bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183)
1 task
mergify bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183)
1 task
mergify bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183)
1 task
mergify bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183)
mergify bot
pushed a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) # Conflicts: # qa/integration/services/elasticsearch_setup.sh
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
…#17533) With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
…#17536) With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
…#17537) With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
…#17534) With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183)
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 9, 2025
…#17535) With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
donoghuc
added a commit
to elastic/logstash
that referenced
this pull request
Apr 10, 2025
…#17538) With a recent change in ES elastic/elasticsearch#125449 configuring path.data or path.logs to directories that do not exist cause ES to not be able to start up. This commit ensures those directories exist. The teardown script already ensures they are removed https://github.com/elastic/logstash/blob/712b37e1df333e8d156cb5d26fbc24aafcbfd2cd/qa/integration/services/elasticsearch_teardown.sh#L26-L27 (cherry picked from commit 8e6e183) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit cleans up how entitlement test methods are discovered. It also adds another robustness check to ensure an annotation doesn't exist on a private method.