Require shellwords in artifact rake task#17319
Merged
donoghuc merged 1 commit intoelastic:mainfrom Mar 14, 2025
Merged
Conversation
The elastic#17310 PR changed the rake task for artifact creation to use shellwords from standard library. The acceptance tests need to explitily load that library. This commit updates the rake file to handle loading the required code.
Contributor
|
This pull request does not have a backport label. Could you fix it @donoghuc? 🙏
|
|
💚 Build Succeeded
|
Member
Author
|
Note that this only needs to be backported to 9.0 as the bug that introduced the need for this change only went in to |
donoghuc
added a commit
that referenced
this pull request
Mar 14, 2025
The #17310 PR changed the rake task for artifact creation to use shellwords from standard library. The acceptance tests need to explitily load that library. This commit updates the rake file to handle loading the required code. (cherry picked from commit 964468f) Co-authored-by: Cas Donoghue <cas.donoghue@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
The #17310 PR changed the rake task for artifact creation to use shellwords from standard library. The acceptance tests need to explitily load that library. This commit updates the rake file to handle loading the required code.
References
failing cell https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1515#01959199-086d-4bb5-8922-161dc535f3e0