Skip to content

[9.0] Require shellwords in artifact rake task (backport #17319)#17320

Merged
donoghuc merged 1 commit into9.0from
mergify/bp/9.0/pr-17319
Mar 14, 2025
Merged

[9.0] Require shellwords in artifact rake task (backport #17319)#17320
donoghuc merged 1 commit into9.0from
mergify/bp/9.0/pr-17319

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 14, 2025

Release notes

[rn:skip]

What does this PR do?

The #17310 PR changed the rake task for artifact creation to use shellwords from standard library. The acceptance tests need to explitily load that library. This commit updates the rake file to handle loading the required code.

References

failing cell https://buildkite.com/elastic/logstash-exhaustive-tests-pipeline/builds/1515#01959199-086d-4bb5-8922-161dc535f3e0


2025-03-13 16:10:03 PDT | [docker] Building docker image
-- | --
  | 2025-03-13 16:10:03 PDT | rake aborted!
  | 2025-03-13 16:10:04 PDT | NameError: uninitialized constant Shellwords
  | 2025-03-13 16:10:04 PDT | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1741906760078483547/elastic/logstash-exhaustive-tests-pipeline/rakelib/artifacts.rake:143:in `block in safe_system'
  | 2025-03-13 16:10:04 PDT | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1741906760078483547/elastic/logstash-exhaustive-tests-pipeline/rakelib/artifacts.rake:142:in `safe_system'
  | 2025-03-13 16:10:04 PDT | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1741906760078483547/elastic/logstash-exhaustive-tests-pipeline/rakelib/artifacts.rake:828:in `block in build_docker'
  | 2025-03-13 16:10:04 PDT | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1741906760078483547/elastic/logstash-exhaustive-tests-pipeline/rakelib/artifacts.rake:827:in `build_docker'
  | 2025-03-13 16:10:04 PDT | /opt/buildkite-agent/builds/bk-agent-prod-gcp-1741906760078483547/elastic/logstash-exhaustive-tests-pipeline/rakelib/artifacts.rake:341:in `block in <main>'
  | 2025-03-13 16:10:04 PDT | org/jruby/ext/monitor/Monitor.java:82:in `synchronize'


```<hr>This is an automatic backport of pull request #17319 done by [Mergify](https://mergify.com).

The #17310 PR changed the rake task for
artifact creation to use shellwords from standard library. The acceptance tests
need to explitily load that library. This commit updates the rake file to handle
loading the required code.

(cherry picked from commit 964468f)
@mergify mergify bot added the backport label Mar 14, 2025
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Copy Markdown
Member

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean backport

@donoghuc donoghuc merged commit 5c50762 into 9.0 Mar 14, 2025
6 of 7 checks passed
@donoghuc donoghuc deleted the mergify/bp/9.0/pr-17319 branch March 14, 2025 02:11
@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

cc @donoghuc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants