plugin manager: add --level=[major|minor|patch] (default: minor)#16899
Merged
yaauie merged 6 commits intoelastic:mainfrom Jan 28, 2025
Merged
plugin manager: add --level=[major|minor|patch] (default: minor)#16899yaauie merged 6 commits intoelastic:mainfrom
--level=[major|minor|patch] (default: minor)#16899yaauie merged 6 commits intoelastic:mainfrom
Conversation
Member
|
Confirmed it works correctly: Vanilla 8.17.0 `bin/logstash-plugin update`Patched v8.17.0 `bin/logstash-plugin update`We can see in the second no major versions were upgraded. |
jsvd
requested changes
Jan 14, 2025
Member
jsvd
left a comment
There was a problem hiding this comment.
I've confirmed the behavior works as expected, just missing docs in https://github.com/elastic/logstash/blob/main/docs/static/plugin-manager.asciidoc?plain=1#L102-L113
Contributor
|
📃 DOCS PREVIEW ✨ https://logstash_bk_16899.docs-preview.app.elstc.co/diff |
yaauie
commented
Jan 14, 2025
| <1> updates all installed plugins | ||
| <2> updates only the plugin you specify | ||
|
|
||
| [NOTE] |
Member
Author
There was a problem hiding this comment.
I added this as an admonition because in the normal case users shouldn't need to concern themselves with this and will be happy to get the latest fully-compatible version available. It is rare that a user would want to jump across major versions of a plugin because we are taking care to backport non-breaking features and fixes to the previous minor.
jsvd
reviewed
Jan 14, 2025
Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Contributor
|
📃 DOCS PREVIEW ✨ https://logstash_bk_16899.docs-preview.app.elstc.co/diff |
karenzone
reviewed
Jan 17, 2025
Contributor
|
📃 DOCS PREVIEW ✨ https://logstash_bk_16899.docs-preview.app.elstc.co/diff |
yaauie
commented
Jan 21, 2025
Contributor
|
📃 DOCS PREVIEW ✨ https://logstash_bk_16899.docs-preview.app.elstc.co/diff |
karenzone
approved these changes
Jan 21, 2025
Contributor
karenzone
left a comment
There was a problem hiding this comment.
I pasted in my original content, and it appears that you reproduced most of the changes in yours.
Remaining differences are:
- shorter anchor title
- wording tweaks
- removing hyphen from heading and text
Otherwise, LGTM
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
|
Contributor
|
📃 DOCS PREVIEW ✨ https://logstash_bk_16899.docs-preview.app.elstc.co/diff |
💚 Build Succeeded
History
cc @yaauie |
Member
Author
|
@logstashmachine backport 8.x |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
…16899) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 6943df5)
Merged
4 tasks
Member
Author
|
@logstashmachine backport 8.17 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
…16899) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 6943df5)
Merged
4 tasks
Member
Author
|
@logstashmachine backport 8.16 |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 28, 2025
…16899) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 6943df5)
Merged
4 tasks
yaauie
added a commit
that referenced
this pull request
Jan 29, 2025
…16899) (#16973) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 6943df5) Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
yaauie
added a commit
that referenced
this pull request
Jan 29, 2025
…16899) (#16974) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 6943df5) Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
yaauie
added a commit
that referenced
this pull request
Jan 29, 2025
…16899) (#16975) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> (cherry picked from commit 6943df5) Co-authored-by: Ry Biesemeyer <yaauie@users.noreply.github.com>
andsel
pushed a commit
to andsel/logstash
that referenced
this pull request
Jan 31, 2025
…lastic#16899) * plugin manager: add `--level=[major|minor|patch]` (default: `minor`) * docs: plugin manager update `--level` behavior * Update docs/static/plugin-manager.asciidoc Co-authored-by: João Duarte <jsvd@users.noreply.github.com> * docs: plugin update major as subheading * docs: intention-first in major plugin updates * Update docs/static/plugin-manager.asciidoc Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com> --------- Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
--level=majorflag.What does this PR do?
Adds
--level=[major|minor|patch]to thebin/logstash-plugin updatecommand, with default valueminor, and propagates it to the underlying bundler's--major,--minor, or--patchflags, to ensure users can upgrade while avoiding breaking changes.Why is it important/What is the impact to the user?
Users are currently being surprised when their
bin/logstash-plugin updateconsumes breaking changes in plugins, causing their currently-valid pipeline configurations to fail to load. This removes the element of surprise, while still allowing users to upgrade across the major version of the plugins if they expressly wish to do so.Checklist
[ ] I have made corresponding change to the default configuration files (and/or docker env variables)closes: #16894