Skip to content

Backport PR #16899 to 8.x: plugin manager: add --level=[major|minor|patch] (default: minor)#16973

Merged
yaauie merged 1 commit into8.xfrom
backport_16899_8.x
Jan 29, 2025
Merged

Backport PR #16899 to 8.x: plugin manager: add --level=[major|minor|patch] (default: minor)#16973
yaauie merged 1 commit into8.xfrom
backport_16899_8.x

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot commented Jan 28, 2025

Backport PR #16899 to 8.x branch, original message:


Release notes

  • By default, the plugin manager will no longer consume breaking changes in plugins, and will instead only consume minor revisions. If you wish to consume breaking changes, you must now explicitly add the --level=major flag.

What does this PR do?

Adds --level=[major|minor|patch] to the bin/logstash-plugin update command, with default value minor, and propagates it to the underlying bundler's --major, --minor, or --patch flags, to ensure users can upgrade while avoiding breaking changes.

Why is it important/What is the impact to the user?

Users are currently being surprised when their bin/logstash-plugin update consumes breaking changes in plugins, causing their currently-valid pipeline configurations to fail to load. This removes the element of surprise, while still allowing users to upgrade across the major version of the plugins if they expressly wish to do so.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

closes: #16894

…16899)

* plugin manager: add `--level=[major|minor|patch]` (default: `minor`)

* docs: plugin manager update `--level` behavior

* Update docs/static/plugin-manager.asciidoc

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>

* docs: plugin update major as subheading

* docs: intention-first in major plugin updates

* Update docs/static/plugin-manager.asciidoc

Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>

---------

Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
Co-authored-by: Karen Metts <35154725+karenzone@users.noreply.github.com>
(cherry picked from commit 6943df5)
@elastic-sonarqube
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown

💚 Build Succeeded

@yaauie yaauie merged commit 2a8898a into 8.x Jan 29, 2025
@yaauie yaauie deleted the backport_16899_8.x branch January 29, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants