[Maps] timeslider by nreese · Pull Request #99661 · elastic/kibana

nreese · 2021-05-10T18:00:18Z

Note: Replaces #96791. #96791 included client-side masking functionality which is proving to have more edge cases then anticipated. This PR removes client-side masking to get to a timeslider MVP that is shippable. Client-side masking can be added in future iterations.

Implements #27714

This PR adds a timeslider to maps. Manipulating the time slider will set a new piece of redux state, timeslice, that will be used by layers to only show data for that timeslice.

elasticmachine · 2021-05-10T18:00:22Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2021-05-10T18:07:18Z

One small comment on the choice of left/right arrow icons - I'd normally associate the arrow with a vertical line e.g. >| with "go to end" not "advance one step".

from #96791 (comment)

@markharwood agreed. I have replaced the next and previous icons with arrowRight and arrowLeft EUI icons. Thanks for the feedback.

nreese · 2021-05-10T19:28:13Z

One note of feedback is to consider an active state on the timeline button to indicate that it is active/shown. Because it is in a different location on the screen when on, I wonder if there's the possibility users may not be certain something happened when clicking the button. All the other buttons in that toolbar show the resulting UI right next to the icon, so this is why I'm wondering if this needs an extra state indicating it's on.

Might also be a nice touch to have a subtle animation on the timeline when it appears similar to how our popovers appear.

from #96791 (comment)

@mdefazio Thanks for feedback. The show/hide icon is now colored with "primary" when the timeslider is open.

I will need some help adding animations for opening.

…action

kmartastic · 2021-05-12T23:39:17Z

Some feedback @nreese @miukimiu:

The time range bar should be aligned with the left-most datetime label.
I feel like I want more intervals. I was getting 4 or 5 whole slices when using 1- or 10- (seconds, days, etc). I was getting more when using 9-.
When looping through (hitting next step when your at the end of the range) it skips the "partial time slice". Either we need to eliminate the partial starting slice or it needs to be treated like a proper step. It would be best if we could reasonably divide the time range, without having a partial slice.
As discussed in this morning's meeting; the back/forward buttons feel too thin -- I like the idea of using the full triangle icon.
The width of the control is not constant. As I click through steps, it appears to jitter with slight changes to width.

kmartastic · 2021-05-13T16:57:03Z

One more idea as I use the Timeslider.

When I initiate the control, it's a snapshot of the global time picker's time range.
My time range is often set to last 5 minutes, 10 minutes, last week, last month, etc.

Let's take "last 10 minutes for example".
After I use this map for 2 or 3 minutes, I want to update the snapshot of my slider.

A couple ideas.

If the global time-picker has auto-update ON; the time-slider should refresh the snapshot as well.
If auto-update is not ON, allow the user to hit "sync" or "live" mode, which snaps the timeslider to the new snapshot -- like hitting update OR perhaps if the user hits Refresh on the time-picker, this would also re-sync the slider to current time.
Note: I think this works well if I update the global time picker and hit "Update" -- this forces a resync of the slider.

@nreese @miukimiu

kmartastic · 2021-05-13T16:57:47Z

Example where labels are too close:

nreese · 2021-05-13T19:27:51Z

@elasticmachine merge upstream

thomasneirynck

mostly nits. Still playing with it, it's really fun.

x-pack/plugins/maps/public/connected_components/timeslider/timeslider.tsx

x-pack/plugins/maps/public/connected_components/toolbar_overlay/toolbar_overlay.tsx

x-pack/plugins/maps/public/connected_components/timeslider/timeslider.tsx

elizabetdev · 2021-05-18T19:36:44Z

@kmartastic,

1 - The time range bar should be aligned with the left-most datetime label.

This fix was merged in EUI: elastic/eui#4781.

4 - As discussed in this morning's meeting; the back/forward buttons feel too thin -- I like the idea of using the full triangle icon.

I opened a PR in EUI with the new icons: elastic/eui#4810. The idea is to use the icons previousFrame and nextFrame. Here's the new set of icons that are going to be merged:

5 - The width of the control is not constant. As I click through steps, it appears to jitter with slight changes to width.

The design was not expecting the time to be so detailed (with milisencods). But as we discussed we can move the controls to the bottom row.

nreese · 2021-05-24T12:29:36Z

@elasticmachine merge upstream

thomasneirynck

thx, this is such a good feature.

thompsongl · 2021-05-25T21:32:24Z

Just dropping a note on some of the related bugs and requests that were reported/requested in EUI:
We've hit some snags with recent version upgrades in Kibana, so it'll be longer than usual before new things are available. Drop us a message if you want a time estimate on something specifc.

nreese · 2021-05-27T16:10:19Z

@elasticmachine merge upstream

kibanamachine · 2021-05-27T17:54:38Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: 167e69e
Storybooks Preview
Flaky suites:
- xpack-accessibility

Test Failures

Kibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/spaces·ts.Kibana spaces page meets a11y validations a11y test for space selection page

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:41]         └-: Kibana spaces page meets a11y validations
[00:01:41]           └-> "before all" hook for "a11y test for manage spaces menu from top nav on Kibana home"
[00:01:41]           └-> "before all" hook for "a11y test for manage spaces menu from top nav on Kibana home"
[00:01:41]             │ info [empty_kibana] Loading "mappings.json"
[00:01:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_001/0coaY2ZLTWO_7PlExeofZw] deleting index
[00:01:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_task_manager_8.0.0_001/nprOZIfrQxuv2iR7iXxzsQ] deleting index
[00:01:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_pre6.5.0_001/adiMzjkRRaCYOavprTGLCQ] deleting index
[00:01:41]             │ info [empty_kibana] Deleted existing index ".kibana_8.0.0_001"
[00:01:41]             │ info [empty_kibana] Deleted existing index ".kibana_task_manager_8.0.0_001"
[00:01:41]             │ info [empty_kibana] Deleted existing index ".kibana_pre6.5.0_001"
[00:01:41]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:01:41]             │ info [empty_kibana] Created index ".kibana"
[00:01:41]             │ debg [empty_kibana] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:01:41]             │ debg Migrating saved objects
[00:01:41]             │ proc [kibana]   log   [16:37:29.640] [info][savedobjects-service] [.kibana_task_manager] INIT -> CREATE_NEW_TARGET. took: 3ms.
[00:01:41]             │ proc [kibana]   log   [16:37:29.643] [info][savedobjects-service] [.kibana] INIT -> LEGACY_SET_WRITE_BLOCK. took: 7ms.
[00:01:41]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_task_manager_8.0.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:01:41]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] updating number_of_replicas to [0] for indices [.kibana_task_manager_8.0.0_001]
[00:01:41]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] adding block write to indices [[.kibana/4O7pjZJfQ_Kw22RLCGEMmA]]
[00:01:41]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] completed adding block write to indices [.kibana]
[00:01:41]             │ proc [kibana]   log   [16:37:29.741] [info][savedobjects-service] [.kibana_task_manager] CREATE_NEW_TARGET -> MARK_VERSION_INDEX_READY. took: 101ms.
[00:01:41]             │ proc [kibana]   log   [16:37:29.760] [info][savedobjects-service] [.kibana] LEGACY_SET_WRITE_BLOCK -> LEGACY_CREATE_REINDEX_TARGET. took: 117ms.
[00:01:41]             │ proc [kibana]   log   [16:37:29.786] [info][savedobjects-service] [.kibana_task_manager] MARK_VERSION_INDEX_READY -> DONE. took: 45ms.
[00:01:41]             │ proc [kibana]   log   [16:37:29.787] [info][savedobjects-service] [.kibana_task_manager] Migration completed after 150ms
[00:01:41]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_pre6.5.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:01:41]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] updating number_of_replicas to [0] for indices [.kibana_pre6.5.0_001]
[00:01:41]             │ proc [kibana]   log   [16:37:29.870] [info][savedobjects-service] [.kibana] LEGACY_CREATE_REINDEX_TARGET -> LEGACY_REINDEX. took: 110ms.
[00:01:41]             │ proc [kibana]   log   [16:37:29.875] [info][savedobjects-service] [.kibana] LEGACY_REINDEX -> LEGACY_REINDEX_WAIT_FOR_TASK. took: 5ms.
[00:01:41]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] 6199 finished with response BulkByScrollResponse[took=6.4ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:01:41]             │ proc [kibana]   log   [16:37:29.982] [info][savedobjects-service] [.kibana] LEGACY_REINDEX_WAIT_FOR_TASK -> LEGACY_DELETE. took: 107ms.
[00:01:41]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana/4O7pjZJfQ_Kw22RLCGEMmA] deleting index
[00:01:41]             │ proc [kibana]   log   [16:37:30.036] [info][savedobjects-service] [.kibana] LEGACY_DELETE -> SET_SOURCE_WRITE_BLOCK. took: 54ms.
[00:01:41]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] adding block write to indices [[.kibana_pre6.5.0_001/_bG_hqhaTFayLGPd-GaXaA]]
[00:01:42]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] completed adding block write to indices [.kibana_pre6.5.0_001]
[00:01:42]             │ proc [kibana]   log   [16:37:30.097] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP. took: 61ms.
[00:01:42]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:01:42]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:01:42]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_reindex_temp][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_reindex_temp][0]]"
[00:01:42]             │ proc [kibana]   log   [16:37:30.177] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP_OPEN_PIT. took: 80ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.182] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_OPEN_PIT -> REINDEX_SOURCE_TO_TEMP_READ. took: 5ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.188] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_READ -> REINDEX_SOURCE_TO_TEMP_CLOSE_PIT. took: 6ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.192] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_CLOSE_PIT -> SET_TEMP_WRITE_BLOCK. took: 4ms.
[00:01:42]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] adding block write to indices [[.kibana_8.0.0_reindex_temp/EUwiEiuAT5mhNcGmuBUeoA]]
[00:01:42]             │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:01:42]             │ proc [kibana]   log   [16:37:30.262] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET. took: 70ms.
[00:01:42]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:01:42]             │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:01:42]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:01:42]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_001/Pcei56RlSwaXxlbOdk6q8A] create_mapping
[00:01:42]             │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:01:42]             │ proc [kibana]   log   [16:37:30.423] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> REFRESH_TARGET. took: 161ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.427] [info][savedobjects-service] [.kibana] REFRESH_TARGET -> OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT. took: 4ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.431] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_OPEN_PIT -> OUTDATED_DOCUMENTS_SEARCH_READ. took: 4ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.439] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_READ -> OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT. took: 8ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.443] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH_CLOSE_PIT -> UPDATE_TARGET_MAPPINGS. took: 4ms.
[00:01:42]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_001/Pcei56RlSwaXxlbOdk6q8A] update_mapping [_doc]
[00:01:42]             │ proc [kibana]   log   [16:37:30.526] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK. took: 83ms.
[00:01:42]             │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] 6266 finished with response BulkByScrollResponse[took=3.4ms,timed_out=false,sliceId=null,updated=0,created=0,deleted=0,batches=0,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:01:42]             │ proc [kibana]   log   [16:37:30.634] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY. took: 108ms.
[00:01:42]             │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_reindex_temp/EUwiEiuAT5mhNcGmuBUeoA] deleting index
[00:01:42]             │ proc [kibana]   log   [16:37:30.690] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE. took: 56ms.
[00:01:42]             │ proc [kibana]   log   [16:37:30.691] [info][savedobjects-service] [.kibana] Migration completed after 1055ms
[00:01:42]             │ debg [empty_kibana] Migrated Kibana index after loading Kibana data
[00:01:43]             │ debg [empty_kibana] Ensured that default space exists in .kibana
[00:01:43]             │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:01:43]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_001/Pcei56RlSwaXxlbOdk6q8A] update_mapping [_doc]
[00:01:45]             │ debg navigating to home url: http://localhost:61141/app/home#/
[00:01:45]             │ debg navigate to: http://localhost:61141/app/home#/
[00:01:45]             │ debg browser[INFO] http://localhost:61141/app/home?_t=1622133453352#/ 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:45]             │
[00:01:45]             │ debg browser[INFO] http://localhost:61141/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:45]             │ debg ... sleep(700) start
[00:01:46]             │ debg ... sleep(700) end
[00:01:46]             │ debg returned from get, calling refresh
[00:01:46]             │ debg browser[INFO] http://localhost:61141/app/home?_t=1622133453352#/ 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:01:46]             │
[00:01:46]             │ debg browser[INFO] http://localhost:61141/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:01:47]             │ debg currentUrl = http://localhost:61141/app/home#/
[00:01:47]             │          appUrl = http://localhost:61141/app/home#/
[00:01:47]             │ debg TestSubjects.find(kibanaChrome)
[00:01:47]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:01:47]             │ debg ... sleep(501) start
[00:01:47]             │ debg ... sleep(501) end
[00:01:47]             │ debg in navigateTo url = http://localhost:61141/app/home#/
[00:01:47]           └-> a11y test for manage spaces menu from top nav on Kibana home
[00:01:47]             └-> "before each" hook: global before each for "a11y test for manage spaces menu from top nav on Kibana home"
[00:01:47]             │ debg TestSubjects.click(space-avatar-default)
[00:01:47]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-default"]') with timeout=10000
[00:01:47]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-default"]') with timeout=10000
[00:01:48]             │ debg Waiting up to 20000ms for Manage spaces option visible...
[00:01:48]             │ debg TestSubjects.exists(manageSpaces)
[00:01:48]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="manageSpaces"]') with timeout=2500
[00:01:48]             └- ✓ pass  (843ms) "Kibana spaces page meets a11y validations a11y test for manage spaces menu from top nav on Kibana home"
[00:01:48]           └-> a11y test for manage spaces page
[00:01:48]             └-> "before each" hook: global before each for "a11y test for manage spaces page"
[00:01:48]             │ debg TestSubjects.click(manageSpaces)
[00:01:48]             │ debg Find.clickByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:01:48]             │ debg Find.findByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:01:48]             │ debg isGlobalLoadingIndicatorVisible
[00:01:48]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:01:48]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:01:50]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:01:50]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:01:50]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:01:50]             │ debg TestSubjects.find(globalToastList)
[00:01:50]             │ debg Find.findByCssSelector('[data-test-subj="globalToastList"]') with timeout=10000
[00:02:01]             │ debg Waiting up to 20000ms for Manage spaces page visible...
[00:02:01]             │ debg TestSubjects.exists(createSpace)
[00:02:01]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="createSpace"]') with timeout=2500
[00:02:01]             └- ✓ pass  (12.5s) "Kibana spaces page meets a11y validations a11y test for manage spaces page"
[00:02:01]           └-> a11y test for click on create space page
[00:02:01]             └-> "before each" hook: global before each for "a11y test for click on create space page"
[00:02:01]             │ debg TestSubjects.click(createSpace)
[00:02:01]             │ debg Find.clickByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:01]             │ debg Find.findByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:01]             └- ✓ pass  (365ms) "Kibana spaces page meets a11y validations a11y test for click on create space page"
[00:02:01]           └-> a11y test for for customize space card
[00:02:01]             └-> "before each" hook: global before each for "a11y test for for customize space card"
[00:02:01]             │ debg TestSubjects.click(addSpaceName)
[00:02:01]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:01]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:01]             │ debg TestSubjects.setValue(addSpaceName, space_a)
[00:02:01]             │ debg TestSubjects.click(addSpaceName)
[00:02:01]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:01]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:01]             │ debg TestSubjects.click(space-avatar-space_a)
[00:02:01]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-space_a"]') with timeout=10000
[00:02:01]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-space_a"]') with timeout=10000
[00:02:02]             └- ✓ pass  (752ms) "Kibana spaces page meets a11y validations a11y test for for customize space card"
[00:02:02]           └-> a11y test for color picker
[00:02:02]           └-> a11y test for customize and reset space URL identifier
[00:02:02]             └-> "before each" hook: global before each for "a11y test for customize and reset space URL identifier"
[00:02:02]             │ debg TestSubjects.click(CustomizeOrReset)
[00:02:02]             │ debg Find.clickByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:02]             │ debg Find.findByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:03]             │ debg TestSubjects.click(CustomizeOrReset)
[00:02:03]             │ debg Find.clickByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:03]             │ debg Find.findByCssSelector('[data-test-subj="CustomizeOrReset"]') with timeout=10000
[00:02:03]             └- ✓ pass  (1.1s) "Kibana spaces page meets a11y validations a11y test for customize and reset space URL identifier"
[00:02:03]           └-> a11y test for describe space text space
[00:02:03]             └-> "before each" hook: global before each for "a11y test for describe space text space"
[00:02:03]             │ debg TestSubjects.click(descriptionSpaceText)
[00:02:03]             │ debg Find.clickByCssSelector('[data-test-subj="descriptionSpaceText"]') with timeout=10000
[00:02:03]             │ debg Find.findByCssSelector('[data-test-subj="descriptionSpaceText"]') with timeout=10000
[00:02:04]             └- ✓ pass  (589ms) "Kibana spaces page meets a11y validations a11y test for describe space text space"
[00:02:04]           └-> a11y test for toggling an entire feature category
[00:02:04]             └-> "before each" hook: global before each for "a11y test for toggling an entire feature category"
[00:02:04]             │ debg TestSubjects.click(featureCategoryButton_kibana)
[00:02:04]             │ debg Find.clickByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:04]             │ debg Find.findByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:04]             │ debg Find.findByCssSelector('button[aria-controls=featureCategory_kibana]') with timeout=10000
[00:02:04]             │ debg TestSubjects.click(featureCategoryButton_kibana)
[00:02:04]             │ debg Find.clickByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:04]             │ debg Find.findByCssSelector('[data-test-subj="featureCategoryButton_kibana"]') with timeout=10000
[00:02:04]             └- ✓ pass  (849ms) "Kibana spaces page meets a11y validations a11y test for toggling an entire feature category"
[00:02:04]           └-> a11y test for space listing page
[00:02:04]             └-> "before each" hook: global before each for "a11y test for space listing page"
[00:02:04]             │ debg TestSubjects.click(save-space-button)
[00:02:04]             │ debg Find.clickByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:04]             │ debg Find.findByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:05]             │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-ubuntu-18-tests-xxl-1622131862047624285] [.kibana_8.0.0_001/Pcei56RlSwaXxlbOdk6q8A] update_mapping [_doc]
[00:02:05]             └- ✓ pass  (670ms) "Kibana spaces page meets a11y validations a11y test for space listing page"
[00:02:05]           └-> a11y test for updating a space
[00:02:05]             └-> "before each" hook: global before each for "a11y test for updating a space"
[00:02:05]             │ debg TestSubjects.click(space_a-editSpace)
[00:02:05]             │ debg Find.clickByCssSelector('[data-test-subj="space_a-editSpace"]') with timeout=10000
[00:02:05]             │ debg Find.findByCssSelector('[data-test-subj="space_a-editSpace"]') with timeout=10000
[00:02:06]             │ debg TestSubjects.click(cancel-space-button)
[00:02:06]             │ debg Find.clickByCssSelector('[data-test-subj="cancel-space-button"]') with timeout=10000
[00:02:06]             │ debg Find.findByCssSelector('[data-test-subj="cancel-space-button"]') with timeout=10000
[00:02:06]             └- ✓ pass  (461ms) "Kibana spaces page meets a11y validations a11y test for updating a space"
[00:02:06]           └-> a11y test for delete space button
[00:02:06]             └-> "before each" hook: global before each for "a11y test for delete space button"
[00:02:06]             │ debg TestSubjects.click(createSpace)
[00:02:06]             │ debg Find.clickByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:06]             │ debg Find.findByCssSelector('[data-test-subj="createSpace"]') with timeout=10000
[00:02:06]             │ debg TestSubjects.click(addSpaceName)
[00:02:06]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:06]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:06]             │ debg TestSubjects.setValue(addSpaceName, space_b)
[00:02:06]             │ debg TestSubjects.click(addSpaceName)
[00:02:06]             │ debg Find.clickByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:06]             │ debg Find.findByCssSelector('[data-test-subj="addSpaceName"]') with timeout=10000
[00:02:06]             │ debg TestSubjects.click(save-space-button)
[00:02:06]             │ debg Find.clickByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:06]             │ debg Find.findByCssSelector('[data-test-subj="save-space-button"]') with timeout=10000
[00:02:06]             │ debg navigating to home url: http://localhost:61141/app/home#/
[00:02:06]             │ debg navigate to: http://localhost:61141/app/home#/
[00:02:06]             │ debg browser[INFO] http://localhost:61141/app/home?_t=1622133474679#/ 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:06]             │
[00:02:06]             │ debg browser[INFO] http://localhost:61141/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:06]             │ debg ... sleep(700) start
[00:02:07]             │ debg ... sleep(700) end
[00:02:07]             │ debg returned from get, calling refresh
[00:02:08]             │ERROR browser[SEVERE] http://localhost:61141/43107/bundles/core/core.entry.js 12:150797 TypeError: Failed to fetch
[00:02:08]             │          at fetch_Fetch.fetchResponse (http://localhost:61141/43107/bundles/core/core.entry.js:6:26193)
[00:02:08]             │          at async http://localhost:61141/43107/bundles/core/core.entry.js:6:24090
[00:02:08]             │          at async http://localhost:61141/43107/bundles/core/core.entry.js:6:23996
[00:02:08]             │ debg browser[INFO] http://localhost:61141/app/home?_t=1622133474679#/ 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:08]             │
[00:02:08]             │ debg browser[INFO] http://localhost:61141/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:08]             │ debg currentUrl = http://localhost:61141/app/home#/
[00:02:08]             │          appUrl = http://localhost:61141/app/home#/
[00:02:08]             │ debg TestSubjects.find(kibanaChrome)
[00:02:08]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:02:08]             │ debg ... sleep(501) start
[00:02:09]             │ debg ... sleep(501) end
[00:02:09]             │ debg in navigateTo url = http://localhost:61141/app/home#/
[00:02:09]             │ debg openSpacesNav()
[00:02:09]             │ debg TestSubjects.click(spacesNavSelector)
[00:02:09]             │ debg Find.clickByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:09]             │ debg Find.findByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:09]             │ info SpaceSelectorPage:clickSpaceAvatar(space_b)
[00:02:09]             │ debg TestSubjects.click(space-avatar-space_b)
[00:02:09]             │ debg Find.clickByCssSelector('[data-test-subj="space-avatar-space_b"]') with timeout=10000
[00:02:09]             │ debg Find.findByCssSelector('[data-test-subj="space-avatar-space_b"]') with timeout=10000
[00:02:10]             │ debg ... sleep(1000) start
[00:02:10]             │ debg browser[INFO] http://localhost:61141/s/space_b/app/home 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:10]             │
[00:02:10]             │ debg browser[INFO] http://localhost:61141/s/space_b/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:11]             │ debg ... sleep(1000) end
[00:02:11]             │ debg isGlobalLoadingIndicatorVisible
[00:02:11]             │ debg TestSubjects.exists(globalLoadingIndicator)
[00:02:11]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:02:13]             │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:02:13]             │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:02:13]             │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:02:13]             │ debg openSpacesNav()
[00:02:13]             │ debg TestSubjects.click(spacesNavSelector)
[00:02:13]             │ debg Find.clickByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:13]             │ debg Find.findByCssSelector('[data-test-subj="spacesNavSelector"]') with timeout=10000
[00:02:13]             │ debg TestSubjects.click(manageSpaces)
[00:02:13]             │ debg Find.clickByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:13]             │ debg Find.findByCssSelector('[data-test-subj="manageSpaces"]') with timeout=10000
[00:02:13]             │ debg TestSubjects.click(space_b-deleteSpace)
[00:02:13]             │ debg Find.clickByCssSelector('[data-test-subj="space_b-deleteSpace"]') with timeout=10000
[00:02:13]             │ debg Find.findByCssSelector('[data-test-subj="space_b-deleteSpace"]') with timeout=10000
[00:02:15]             └- ✓ pass  (9.0s) "Kibana spaces page meets a11y validations a11y test for delete space button"
[00:02:15]           └-> a11y test for space selection page
[00:02:15]             └-> "before each" hook: global before each for "a11y test for space selection page"
[00:02:15]             │ debg TestSubjects.click(confirmModalConfirmButton)
[00:02:15]             │ debg Find.clickByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:02:15]             │ debg Find.findByCssSelector('[data-test-subj="confirmModalConfirmButton"]') with timeout=10000
[00:02:15]             │ info Taking screenshot "/dev/shm/workspace/parallel/14/kibana/x-pack/test/functional/screenshots/failure/Kibana spaces page meets a11y validations a11y test for space selection page.png"
[00:02:15]             │ debg browser[INFO] http://localhost:61141/spaces/space_selector 340 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:02:15]             │
[00:02:15]             │ debg browser[INFO] http://localhost:61141/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:02:16]             │ info Current URL is: http://localhost:61141/spaces/space_selector
[00:02:16]             │ info Saving page source to: /dev/shm/workspace/parallel/14/kibana/x-pack/test/functional/failure_debug/html/Kibana spaces page meets a11y validations a11y test for space selection page.html
[00:02:16]             └- ✖ fail: Kibana spaces page meets a11y validations a11y test for space selection page
[00:02:16]             │      JavascriptError: javascript error: document unloaded while waiting for result
[00:02:16]             │   (Session info: headless chrome=91.0.4472.77)
[00:02:16]             │       at Object.throwDecodedError (/dev/shm/workspace/parallel/14/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
[00:02:16]             │       at parseHttpResponse (/dev/shm/workspace/parallel/14/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
[00:02:16]             │       at Executor.execute (/dev/shm/workspace/parallel/14/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
[00:02:16]             │       at runMicrotasks (<anonymous>)
[00:02:16]             │       at processTicksAndRejections (internal/process/task_queues.js:95:5)
[00:02:16]             │       at Task.exec (/dev/shm/workspace/parallel/14/kibana/test/functional/services/remote/prevent_parallel_calls.ts:29:22)
[00:02:16]             │ 
[00:02:16]             │

Stack Trace

JavascriptError: javascript error: document unloaded while waiting for result
  (Session info: headless chrome=91.0.4472.77)
    at Object.throwDecodedError (/dev/shm/workspace/parallel/14/kibana/node_modules/selenium-webdriver/lib/error.js:550:15)
    at parseHttpResponse (/dev/shm/workspace/parallel/14/kibana/node_modules/selenium-webdriver/lib/http.js:565:13)
    at Executor.execute (/dev/shm/workspace/parallel/14/kibana/node_modules/selenium-webdriver/lib/http.js:491:26)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at Task.exec (/dev/shm/workspace/parallel/14/kibana/test/functional/services/remote/prevent_parallel_calls.ts:29:22) {
  remoteStacktrace: '#0 0x55c9bf4a1ee9 <unknown>\n'
}

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`maps`	725	731	+6

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`maps`	2.6MB	2.6MB	+16.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`maps`	63.5KB	63.6KB	+74.0B

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`canvas`	29	25	-4
`crossClusterReplication`	8	6	-2
`fleet`	22	20	-2
`globalSearch`	4	2	-2
`indexManagement`	12	7	-5
`infra`	261	149	-112
`lens`	67	45	-22
`licensing`	18	15	-3
`lists`	239	236	-3
`maps`	286	208	-78
`ml`	121	115	-6
`monitoring`	109	56	-53
`securitySolution`	386	342	-44
`stackAlerts`	101	95	-6
total			-342

History

💚 Build #127157 succeeded be412b2
💚 Build #127143 succeeded 482f1a7
💚 Build #126871 succeeded 01db729
💚 Build #126111 succeeded ad4ac95
💚 Build #126092 succeeded 3c73072

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [Maps timeslider] * just arrowLeft and arrowRight icons * tslint * color icon when timeslider is open, auto select first section on open * increase width to prevent timeslider from changing sizes during interaction * fix filters disappearing when timeslice advances * use shorter date format for ticks * review feedback * do not show timeslider button when map is embedded Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

kibanamachine · 2021-05-27T18:34:37Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* [Maps timeslider] * just arrowLeft and arrowRight icons * tslint * color icon when timeslider is open, auto select first section on open * increase width to prevent timeslider from changing sizes during interaction * fix filters disappearing when timeslice advances * use shorter date format for ticks * review feedback * do not show timeslider button when map is embedded Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Nathan Reese <reese.nathan@gmail.com>

[Maps timeslider]

5f26896

nreese added release_note:enhancement Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.14.0 labels May 10, 2021

nreese requested a review from thomasneirynck May 10, 2021 18:00

nreese requested a review from a team as a code owner May 10, 2021 18:00

nreese mentioned this pull request May 10, 2021

[Maps] timeslider #96791

Closed

just arrowLeft and arrowRight icons

28bd1c7

nreese added 2 commits May 10, 2021 12:42

tslint

f3b3f36

color icon when timeslider is open, auto select first section on open

f23a05b

increase width to prevent timeslider from changing sizes during inter…

746bfb9

…action

thomasneirynck mentioned this pull request May 13, 2021

[RFC][Maps] Adding a timeslider to Maps #98355

Merged

kibanamachine and others added 2 commits May 13, 2021 15:27

Merge branch 'master' into timeslider2

8d4b5c2

fix filters disappearing when timeslice advances

00a0d3d

thomasneirynck reviewed May 13, 2021

View reviewed changes

nreese added 2 commits May 14, 2021 13:14

use shorter date format for ticks

3c73072

review feedback

ad4ac95

nreese requested a review from thomasneirynck May 14, 2021 20:44

thomasneirynck mentioned this pull request May 18, 2021

[EuiDualRange] Should only fire change events when user lets go of endpoint elastic/eui#4812

Closed

Merge branch 'master' into timeslider2

01db729

nreese added 2 commits May 25, 2021 08:41

merge with master

482f1a7

do not show timeslider button when map is embedded

be412b2

thomasneirynck approved these changes May 25, 2021

View reviewed changes

merge with master

70d76c6

nreese added the auto-backport Deprecated - use backport:version if exact versions are needed label May 26, 2021

Merge branch 'master' into timeslider2

167e69e

nreese merged commit 8420605 into elastic:master May 27, 2021

kibanamachine mentioned this pull request May 27, 2021

[7.x] [Maps] timeslider (#99661) #100811

Merged

nreese mentioned this pull request Jun 21, 2021

[Maps] Support for timeslider and playback #27714

Closed

This was referenced Aug 20, 2021

[maps] auto fit to bounds not working when map is embedded in dashboard #109465

Closed

[Maps] fix auto fit to bounds not working when map is embedded in dashboard #109479

Merged

Conversation

nreese commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented May 10, 2021

Uh oh!

nreese commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nreese commented May 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kmartastic commented May 12, 2021

Uh oh!

kmartastic commented May 13, 2021

Uh oh!

kmartastic commented May 13, 2021

Uh oh!

nreese commented May 13, 2021

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elizabetdev commented May 18, 2021

Uh oh!

nreese commented May 24, 2021

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl commented May 25, 2021

Uh oh!

nreese commented May 27, 2021

Uh oh!

kibanamachine commented May 27, 2021

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

Metrics [docs]

Module Count

Async chunks

Page load bundle

References to deprecated APIs

History

Uh oh!

kibanamachine commented May 27, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nreese commented May 10, 2021 •

edited

Loading

nreese commented May 10, 2021 •

edited

Loading

nreese commented May 10, 2021 •

edited

Loading