[EuiIcon] Add timeslider, playFilled, frameNext and framePrevious glyphs#4810
Merged
elizabetdev merged 6 commits intoelastic:masterfrom May 19, 2021
Merged
Conversation
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
1 similar comment
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
cchaos
approved these changes
May 19, 2021
Contributor
cchaos
left a comment
There was a problem hiding this comment.
LGTM!
Minor suggestion, but it's always nice to have similar icons be close to eachother in name and placement in the list. What do you think about changing previousFrame and nextFrame to frameNext and framePrevious?
Contributor
Author
Sounds good! 🎉 Let me change. |
timeslider, playFilled, previousFrame and nextFrame glyphstimeslider, playFilled, frameNext and framePrevious glyphs
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_4810/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
timeslider,playFilled,previousFrameandnextFrameglyphs to EuiIcon. All these icons are necessary for the upcoming Maps Timeslider.Design
The
play,filter,crossInACircleFilledicons are not part of this PR. They're just being used for comparison:Checklist
[ ] Checked in mobile[ ] Added documentation[ ] Checked Code Sandbox works for the any docs examples[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes