[Lens] Formula editor by wylieconlon · Pull Request #99297 · elastic/kibana

wylieconlon · 2021-05-04T23:34:58Z

Release note

Lens formulas let you do math using a combination of Elasticsearch aggregations and math functions. For example, find the error rate by typing count(kql='http.response.status_code >= 400 AND http.response.status_code < 600') / count().

Known issues that are not blocking

Update the icons used for the formula editor once EUI is merged
Documentation of formula
KQL autocomplete with \' does not replace word, for example category.keyword: Men's will become Men's "Men's Clothing"
KQL autocomplete is suggesting field names twice, for example category.keyword is suggested twice
The UI hangs for several seconds sometimes, it appears to be related to the suggestions rendering performance
- Work in progress, needs a separate PR
Hide tabs if there is just one (on bucketed dimension) @flash1293
'Search functions' placeholder doesn't fit the input for the standard Macbook width

## Fixed issues

General issues:

Validation:

Prevent using KQL with no quotes or double quotes @dej611

Text input:

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

For maintainers

This was checked for breaking API changes and was labeled appropriately

…ndling

…r-handling

…a into lens/formula-error-handling

lukeelmers

telemetry schema changes LGTM!

cjcenizal

One-line change to kbn-monaco imports LGTM. Didn't test locally.

Bamieh

LGTM. 1 NIT to add a description to the formula field in the schema. If you have no more changes to the PR feel free to merge and address the descriptions later on in a future PR

x-pack/plugins/lens/server/usage/schema.ts

streamich

AppServices change in data table expression function LGTM.

…r-handling

ThomThomson

Presentation team changes LGTM. Code only review

MichaelMarcialis

This is great! Extremely impressive job on this PR, @wylieconlon (and all others that contributed). I've left a few comments and suggestions below.

Additionally, per a previous question, I mentioned in the design notes that it would be desirable to not allow the height of an X/Y visualization to exceed its width in full screen mode, as that could yield a chart with some deceptive peaks and valleys. Is this a concern we wish to address in this PR? Or is this concern a non-issue?

MichaelMarcialis · 2021-06-09T13:40:12Z

...ugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula.scss

+
+.lnsFormula__editorContent {
+  position: relative;
+  height: 201px;


Why give a height style to the element containing the Monaco editor here? Wouldn't it be better to just leave it dimensionless and let it conform to the height of the editor? If so, I suggest removing.

@MichaelMarcialis Adding an exact height solves a few of the problems we ran into in Monaco:

Improves performance, especially performance of opening the initial editor

Prevents the monaco empty state from flashing

I could not find a way to get both a dynamic height and good performance.

MichaelMarcialis · 2021-06-09T13:42:08Z

...ugins/lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula.scss

+
+.lnsIndexPatternDimensionEditor-isFullscreen .lnsFormula__editorContent {
+  flex: 1;
+  min-height: 201px;


Same question here. Is the min-height style needed? If not, I suggest removing and letting flexbox determine the height for the editor space.

MichaelMarcialis · 2021-06-09T14:33:13Z

...lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx

+                    position="top"
+                  >
+                    <EuiButtonIcon
+                      iconType="bolt"


This EuiButtonIcon for disabling and enabling word wrap is still using the bolt icon. This should be updated to wordWrapDisabled and wordWrap respectively (assuming these new icons are now available in Kibana).

We will follow up to update the icons once they are ready in EUI, but they aren't yet.

MichaelMarcialis · 2021-06-09T14:34:22Z

...lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx

+                      setIsHelpOpen(!isFullscreen);
+                      trackUiEvent('toggle_formula_fullscreen');
+                    }}
+                    iconType={isFullscreen ? 'bolt' : 'fullScreen'}


This EuiButtonEmpty for collapsing or exiting full screen mode is still using the bolt icon. This should be updated to fullScreenExit (assuming this new icon is now available in Kibana).

MichaelMarcialis · 2021-06-09T14:36:44Z

...lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx

+                        color="text"
+                        onClick={() => setIsHelpOpen(!isHelpOpen)}
+                      >
+                        <EuiIcon type="help" />


This EuiIcon is still using the help icon. This should be updated to documentation (assuming this new icon is now available in Kibana).

...lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx

MichaelMarcialis · 2021-06-09T15:28:58Z

x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx

+            <EuiCallOut
+              size="s"
+              title={i18n.translate('xpack.lens.indexPattern.formulaWarning', {
+                defaultMessage: 'Staged formula',
+              })}
+              color="warning"
+            >
+              <p>
+                {i18n.translate('xpack.lens.indexPattern.formulaWarningText', {
+                  defaultMessage: 'Picking a quick function will erase your formula.',
+                })}
+              </p>
+            </EuiCallOut>


The placement of this callout feels awkward currently. Assuming we can migrate the EuiTabs to the flyout header (per my previous comment), could we make this callout flush with the container, as shown in the EUI docs example for applying a banner to an EuiFlyout?

The wording here also feels like it could use some tweaking. Perhaps the title could be Formula currently applied and subsequent text could be Select a quick function to overwrite your formula.? Thoughts, @KOTungseth?

I've made the callout flush, but I don't think I can easily make this a sticky header like the example you gave. If there is a CSS-only solution to this problem I'm happy to implement one, but for this component we don't have any access to the flyout react component.

Thanks for making that change. Can we also make the following changes to this EuiCallout?

Apply a prop of iconType="alert" for added emphasis.

Apply a style of border: none; to match style with similar EUI usage.

Also, any thoughts on those suggested text changes? We can of course update the text in a later PR as well.

I like the suggested language, matches the tone of the docs by avoiding "X will Y" type sentences in favor of "To Y, do X"

...lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx

MichaelMarcialis

Added one last nitpick below and replied to a previous comment above. Once those are addressed, this looks good from my perspective. Approving now to avoid holding you up. Thanks!

MichaelMarcialis · 2021-06-09T18:42:22Z

...lens/public/indexpattern_datasource/operations/definitions/formula/editor/formula_editor.tsx

                        <EuiButtonEmpty
                          color={errorCount ? 'danger' : 'warning'}
                          className="lnsFormula__editorError"
+                          iconType="alert"
+                          size="xs"
                          onClick={() => {
                            setIsWarningOpen(!isWarningOpen);
                          }}
                        >


Can we add a prop of flush="right" to this EuiButtonEmpty to align correctly?

kibanamachine · 2021-06-09T23:21:26Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`lens`	670	684	+14

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.3MB	1.3MB	+315.0B
`kibanaReact`	312.0KB	312.1KB	+45.0B
`lens`	1.3MB	1.4MB	+85.3KB
total			+85.6KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`expressions`	199.2KB	199.6KB	+332.0B
`kbnUiSharedDeps-css`	503.3KB	503.7KB	+409.0B
`kbnUiSharedDeps-elastic`	2.6MB	2.6MB	+1.0B
`kbnUiSharedDeps-js`	6.4MB	6.4MB	+5.4KB
`lens`	38.1KB	38.1KB	+69.0B
total			+6.2KB

History

💚 Build #130286 succeeded 28cf06e
💚 Build #130246 succeeded e2e4e6d
💚 Build #130047 succeeded fd8bbc9
💔 Build #130040 failed 93da501
💚 Build #129972 succeeded f9a9c9a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* 💄 Hack to fix suggestion box * 🐛 Fix validation messages * 🐛 Relax operations check for managedReferences * Change completion params * 🏷️ Fix missing arg issue * ✨ Add more tinymath fns * 🐛 Improved validation around math operations + multiple named arguments * 🐛 Use new onError feature in math expression * ♻️ Refactor namedArguments validation * 🐛 Fix circular dependency issue in tests + minor fixes * Move formula into a tab * 🔥 Leftovers from previous merge * ✨ Move over namedArgs from previous function * ✅ Add tests for transferable scenarios * ✅ Fixed broken test * ✨ Use custom label for axis * Allow switching back and forth to formula tab * Add a section for the function reference * Add modal editor and markdown docs * Change the way math nodes are validated * Use custom portal to fix monaco positioning * Fix model sharing issues * Provide signature help * 🐛 Fix small test issue * 🐛 Mark pow arguments as required * 🐛 validate on first render only if a formula is present * 🔥 Remove log10 fn for now * ✨ Improved math validation + add tests for math functions * Fix mount/unmount issues with Monaco * [Lens] Fully unmount React when flyout closes * Fix bug with editor frame unmounting * Fix type * Add tests for monaco providers, add hover provider * Add test for last_value * Usability improvements * Add KQL and Lucene named parameters * Add kql, lucene completion and validation * Fix autocomplete on weird characters and properly connect KQL * Highlight functions that have additional requirements after validating * Fix type error and move help text to popover * Fix escape characters inside KQL * 🐛 Fix dataType issue when moving over to Formula * Automatically insert single quotes on every named param * Only insert single quotes when typing kql= or lucene= * Reorganize help popover * Fix merge issues * Update grammar for formulas * Fix bad merge * Rough fullscreen mode * Type updates * Pass through fullscreen state * Remove more chrome from full screen mode * Fix minor bugs in formula typing * 🐛 Decouple column order of references and output * 🔧 Fix tests and types * ✅ Add first functional test * Fix copying formulas and empty formula * Trigger suggestion prompt when hitting enter on function or typing kql= * 🐛 Prevent flyout from closing while interacting with monaco * refactoring * move main column generation into parse module * fix tests * refactor small formula styles and markup * documentation * adjustments in formula footer * Formula refactoring (elastic#12) * refactoring * move main column generation into parse module * fix tests * more style and markup tweak for custom formula * Fix tests * [Expressions] Use table column ID instead of name when set * [Lens] Create managedReference type for formulas * Fix test failures * Fix i18n types * fix fullscreen flex issues * Delete managedReference when replacing * refactor css and markup; add button placeholders * [Lens] Formulas * Tests for formula Co-authored-by: Marco Liberati <marco.liberati@elastic.co> * added error count placeholder * Add tooltips * Refactoring from code review * Fix some editor issues * Update ID matching to match by name sometimes * Improve performance of Monaco, fix formulas with 0, update labels * Improve performance of full screen toggle * Fix formula tests * fix stuff * Add an extra case to prevent insertion of duplicate column * Simplify logic and add test for output ID * add telemetry for Lens formula (elastic#15) * Respond to review comments * ✨ Improve the signatures with better documentation and examples * adjust border styles to account for docs collapse * refactor docs markup; restructure docs obj; styles * Fix formula auto reordering (elastic#18) * fix formula auto reordering * add unit test * Fix and improve suggestion experience in Formula (elastic#19) * ✨ Revisit documentation and suggestions * 👌 Integrated feedback * ✨ Add query validation for quotes * Usability updates & type fixes * add search to formula * fix form styles to match designs * fix text styles; revert to Markdown for control * 👌 Integrated more feedback * improve search * improve suggestions * improve suggestions even more * 🐛 Fix i18n issues (elastic#22) * Persist formula on leave, fix fullscreen and popovers * Fix documentation tests * 🏷️ fix type issue * 🐛 Remove hidden operations from valid functions list * 🐛 Fix empty string query edge case * 🐛 Enable more suggestions + extends validation * Fix tests that depended on setState being called without function * Error state and text wrapping updates * ✨ Add new module to CodeEditor for brackets matching (elastic#25) * Fix type * show warning * keep current quick function * ✨ Improve suggestions within kql query * 📷 Fix snapshot editor test * 🐛 Improved suggestion for single quote and refactored debounce * Fix lodash usage * Fix tests * Revert "keep current quick function" This reverts commit ed47705. * Improve performance of dispatch by using timeout * Improve memoization of datapanel * Fix escape characters * fix reduced suggestions * fix responsiveness * fix unit test * Fix autocomplete on nested math * Show errors and warnings on first render * fix transposing column crash * Update comment * 🐛 Fix field error message * fix test types * 📝 Fix i18n name * 💄 Manage wordwrap via react component * Fix selector for palettes that interferes with quick functions * Use word wrapping by default * Errors for managed references are handled at the top level * 🐛 Move the cursor just next to new inserted text * ⚗️ First pass for performance * 🐛 Fix unwanted change * ⚡ Memoize as many combobox props as possible * ⚡ More memoization * Show errors in hover * Use temporary invalid state when moving away from formula * Remove setActiveDimension and shouldClose, fixed by async setters * Fix test dependency * do not show quick functions tab * increase documentation popover width * fix functional test * Call setActiveDimension when updating visualization * Simplify handling of flyout with incomplete columns * Fix test issues * add description to formula telemetry * fix schema * Update from design feedback * More review comments * Hide callout border from v7 theme Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co> Co-authored-by: Joe Reuter <email@johannes-reuter.de> Co-authored-by: Marco Liberati <marco.liberati@elastic.co> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>

kibanamachine · 2021-06-10T14:11:46Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* 💄 Hack to fix suggestion box * 🐛 Fix validation messages * 🐛 Relax operations check for managedReferences * Change completion params * 🏷️ Fix missing arg issue * ✨ Add more tinymath fns * 🐛 Improved validation around math operations + multiple named arguments * 🐛 Use new onError feature in math expression * ♻️ Refactor namedArguments validation * 🐛 Fix circular dependency issue in tests + minor fixes * Move formula into a tab * 🔥 Leftovers from previous merge * ✨ Move over namedArgs from previous function * ✅ Add tests for transferable scenarios * ✅ Fixed broken test * ✨ Use custom label for axis * Allow switching back and forth to formula tab * Add a section for the function reference * Add modal editor and markdown docs * Change the way math nodes are validated * Use custom portal to fix monaco positioning * Fix model sharing issues * Provide signature help * 🐛 Fix small test issue * 🐛 Mark pow arguments as required * 🐛 validate on first render only if a formula is present * 🔥 Remove log10 fn for now * ✨ Improved math validation + add tests for math functions * Fix mount/unmount issues with Monaco * [Lens] Fully unmount React when flyout closes * Fix bug with editor frame unmounting * Fix type * Add tests for monaco providers, add hover provider * Add test for last_value * Usability improvements * Add KQL and Lucene named parameters * Add kql, lucene completion and validation * Fix autocomplete on weird characters and properly connect KQL * Highlight functions that have additional requirements after validating * Fix type error and move help text to popover * Fix escape characters inside KQL * 🐛 Fix dataType issue when moving over to Formula * Automatically insert single quotes on every named param * Only insert single quotes when typing kql= or lucene= * Reorganize help popover * Fix merge issues * Update grammar for formulas * Fix bad merge * Rough fullscreen mode * Type updates * Pass through fullscreen state * Remove more chrome from full screen mode * Fix minor bugs in formula typing * 🐛 Decouple column order of references and output * 🔧 Fix tests and types * ✅ Add first functional test * Fix copying formulas and empty formula * Trigger suggestion prompt when hitting enter on function or typing kql= * 🐛 Prevent flyout from closing while interacting with monaco * refactoring * move main column generation into parse module * fix tests * refactor small formula styles and markup * documentation * adjustments in formula footer * Formula refactoring (#12) * refactoring * move main column generation into parse module * fix tests * more style and markup tweak for custom formula * Fix tests * [Expressions] Use table column ID instead of name when set * [Lens] Create managedReference type for formulas * Fix test failures * Fix i18n types * fix fullscreen flex issues * Delete managedReference when replacing * refactor css and markup; add button placeholders * [Lens] Formulas * Tests for formula Co-authored-by: Marco Liberati <marco.liberati@elastic.co> * added error count placeholder * Add tooltips * Refactoring from code review * Fix some editor issues * Update ID matching to match by name sometimes * Improve performance of Monaco, fix formulas with 0, update labels * Improve performance of full screen toggle * Fix formula tests * fix stuff * Add an extra case to prevent insertion of duplicate column * Simplify logic and add test for output ID * add telemetry for Lens formula (#15) * Respond to review comments * ✨ Improve the signatures with better documentation and examples * adjust border styles to account for docs collapse * refactor docs markup; restructure docs obj; styles * Fix formula auto reordering (#18) * fix formula auto reordering * add unit test * Fix and improve suggestion experience in Formula (#19) * ✨ Revisit documentation and suggestions * 👌 Integrated feedback * ✨ Add query validation for quotes * Usability updates & type fixes * add search to formula * fix form styles to match designs * fix text styles; revert to Markdown for control * 👌 Integrated more feedback * improve search * improve suggestions * improve suggestions even more * 🐛 Fix i18n issues (#22) * Persist formula on leave, fix fullscreen and popovers * Fix documentation tests * 🏷️ fix type issue * 🐛 Remove hidden operations from valid functions list * 🐛 Fix empty string query edge case * 🐛 Enable more suggestions + extends validation * Fix tests that depended on setState being called without function * Error state and text wrapping updates * ✨ Add new module to CodeEditor for brackets matching (#25) * Fix type * show warning * keep current quick function * ✨ Improve suggestions within kql query * 📷 Fix snapshot editor test * 🐛 Improved suggestion for single quote and refactored debounce * Fix lodash usage * Fix tests * Revert "keep current quick function" This reverts commit ed47705. * Improve performance of dispatch by using timeout * Improve memoization of datapanel * Fix escape characters * fix reduced suggestions * fix responsiveness * fix unit test * Fix autocomplete on nested math * Show errors and warnings on first render * fix transposing column crash * Update comment * 🐛 Fix field error message * fix test types * 📝 Fix i18n name * 💄 Manage wordwrap via react component * Fix selector for palettes that interferes with quick functions * Use word wrapping by default * Errors for managed references are handled at the top level * 🐛 Move the cursor just next to new inserted text * ⚗️ First pass for performance * 🐛 Fix unwanted change * ⚡ Memoize as many combobox props as possible * ⚡ More memoization * Show errors in hover * Use temporary invalid state when moving away from formula * Remove setActiveDimension and shouldClose, fixed by async setters * Fix test dependency * do not show quick functions tab * increase documentation popover width * fix functional test * Call setActiveDimension when updating visualization * Simplify handling of flyout with incomplete columns * Fix test issues * add description to formula telemetry * fix schema * Update from design feedback * More review comments * Hide callout border from v7 theme Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co> Co-authored-by: Joe Reuter <email@johannes-reuter.de> Co-authored-by: Marco Liberati <marco.liberati@elastic.co> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com> Co-authored-by: Wylie Conlon <william.conlon@elastic.co> Co-authored-by: dej611 <dej611@gmail.com> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: Michael Marcialis <michael.marcialis@elastic.co> Co-authored-by: Joe Reuter <email@johannes-reuter.de> Co-authored-by: Marco Liberati <marco.liberati@elastic.co> Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>

dej611 and others added 30 commits February 10, 2021 14:41

Merge branch lens/formula-error-handling-2 into lens/formula-error-ha…

844692a

…ndling

💄 Hack to fix suggestion box

d4c5998

Merge branch 'master' into lens/formula-error-handling

bb37b7f

Merge branch 'master' into lens/formula-error-handling

2420565

Merge branch 'master' into lens/formula-error-handling

036415a

🐛 Fix validation messages

4d5dca2

🐛 Relax operations check for managedReferences

7c38af3

Merge remote-tracking branch 'origin/master' into lens/formulas

e90a5df

Change completion params

a695329

🏷️ Fix missing arg issue

ea574f7

Merge remote-tracking branch 'upstream/master' into lens/formula-erro…

28c0427

…r-handling

✨ Add more tinymath fns

417edff

🐛 Improved validation around math operations + multiple named arguments

fcbdc74

🐛 Use new onError feature in math expression

55d3bc6

♻️ Refactor namedArguments validation

642fa53

🐛 Fix circular dependency issue in tests + minor fixes

08b9b6f

Merge remote-tracking branch 'upstream/master' into lens/formula-erro…

530226c

…r-handling

Merge remote-tracking branch 'origin/master' into lens/formulas

586f6ef

Move formula into a tab

7832aeb

🔥 Leftovers from previous merge

f05c647

✨ Move over namedArgs from previous function

d050e6f

✅ Add tests for transferable scenarios

37c9c5f

Merge branch 'lens/formula-error-handling' of github.com:dej611/kiban…

006f569

…a into lens/formula-error-handling

✅ Fixed broken test

135987c

✨ Use custom label for axis

28847f1

Allow switching back and forth to formula tab

5524cf2

Add a section for the function reference

6650f67

Add modal editor and markdown docs

1e32e0a

Merge remote-tracking branch 'origin/master' into lens/formulas

cacf486

Change the way math nodes are validated

2bc7f6c

mbondyra approved these changes Jun 8, 2021

View reviewed changes

flash1293 and others added 2 commits June 8, 2021 16:32

fix functional test

9a7b4bc

Call setActiveDimension when updating visualization

7f5dbea

lukeelmers approved these changes Jun 8, 2021

View reviewed changes

cjcenizal approved these changes Jun 8, 2021

View reviewed changes

wylieconlon added 2 commits June 8, 2021 17:52

Simplify handling of flyout with incomplete columns

4b81e5d

Fix test issues

f9a9c9a

Bamieh approved these changes Jun 9, 2021

View reviewed changes

x-pack/plugins/lens/server/usage/schema.ts Outdated Show resolved Hide resolved

streamich approved these changes Jun 9, 2021

View reviewed changes

flash1293 added 2 commits June 9, 2021 11:13

Merge remote-tracking branch 'upstream/master' into lens/formula-erro…

bca4cb5

…r-handling

add description to formula telemetry

93da501

flash1293 mentioned this pull request Jun 9, 2021

[Lens] Formula time shift #101718

Merged

fix schema

fd8bbc9

ThomThomson approved these changes Jun 9, 2021

View reviewed changes

wylieconlon added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 9, 2021

MichaelMarcialis reviewed Jun 9, 2021

View reviewed changes

Update from design feedback

e2e4e6d

MichaelMarcialis approved these changes Jun 9, 2021

View reviewed changes

wylieconlon added 2 commits June 9, 2021 15:33

More review comments

28cf06e

Hide callout border from v7 theme

9ec3c9a

wylieconlon merged commit b35cde5 into elastic:master Jun 10, 2021

kibanamachine mentioned this pull request Jun 10, 2021

[7.x] [Lens] Formula editor (#99297) #101900

Merged

This was referenced Jun 14, 2021

[Lens] Math using TinyMath #68969

Closed

[Lens] Formula: KQL autocomplete in formula #94673

Closed

[Lens] Formula MVP #91087

Closed

mbondyra mentioned this pull request Jul 14, 2023

[Lens] fix dimension panel datasource updates #161881

Merged

9 tasks

Conversation

wylieconlon commented May 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Release note

Known issues that are not blocking

Checklist

For maintainers

Uh oh!

lukeelmers left a comment

Choose a reason for hiding this comment

Uh oh!

cjcenizal left a comment

Choose a reason for hiding this comment

Uh oh!

Bamieh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

streamich left a comment

Choose a reason for hiding this comment

Uh oh!

ThomThomson left a comment

Choose a reason for hiding this comment

Uh oh!

MichaelMarcialis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

MichaelMarcialis left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 9, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

Page load bundle

History

Uh oh!

kibanamachine commented Jun 10, 2021

💚 Backport successful

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

wylieconlon commented May 4, 2021 •

edited

Loading

Bamieh left a comment •

edited

Loading