Update dependency @elastic/charts to v28.2.0 (master)#97005
Conversation
|
@elasticmachine merge upstream |
| [ | ||
| { | ||
| groupByRollup: 6, | ||
| value: 6, | ||
| depth: 1, | ||
| path: [], | ||
| sortIndex: 1, | ||
| smAccessorValue: '', | ||
| }, | ||
| ], |
There was a problem hiding this comment.
Missing smAccessorValue from new partition small multiples
There was a problem hiding this comment.
Lens code changes LGTM, but it seems like this broke the way we do functional tests. Let me know whether I should take a deeper look here.
retry.try timeout: NoSuchElementError: no such element: Unable to locate element: {"method":"css selector","selector":"[data-ech-series-name="Count"] .echLegendItem__color"}
|
@elasticmachine merge upstream |
markov00
left a comment
There was a problem hiding this comment.
This elastic/elastic-charts#1087 introduced an internal change.
I've checked the error and is easily visible when opening the Log sample dashboard.
The problem happens when using dual axis chart, in particular this part in src/plugins/vis_type_xy/public/utils/render_all_series.tsx create the issue in with the new code
// needed to seperate stacked and non-stacked bars into unique pseudo groups
const pseudoGroupId = isStacked ? `__pseudo_stacked_group-${groupId}__` : groupId;
// set domain of stacked groups to use actual groupId not pseudo groupdId
const useDefaultGroupDomain = isStacked ? groupId : undefined;
I'm start investigating locally on the chart lib about that case
|
@elasticmachine run elasticsearch-ci/docs |
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @markov00 |
* Update dependency @elastic/charts to v28.2.0 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
* Update dependency @elastic/charts to v28.2.0 Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renovate Bot <bot@renovateapp.com> Co-authored-by: nickofthyme <nick.ryan.partridge@gmail.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This PR contains the following updates:
28.0.1->28.2.0Release Notes
elastic/elastic-charts
Compare Source
v28.2.0Bug Fixes
useDefaultGroupDomainon scale config (#1119) (c1b59f2), closes #1087Features
v28.1.0Bug Fixes
Features
28.0.1 (2021-04-06)
Bug Fixes
Configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by WhiteSource Renovate. View repository job log here.