fix(xy): consider useDefaultGroupDomain on scale config#1119
Merged
markov00 merged 4 commits intoelastic:masterfrom Apr 15, 2021
Merged
fix(xy): consider useDefaultGroupDomain on scale config#1119markov00 merged 4 commits intoelastic:masterfrom
useDefaultGroupDomain on scale config#1119markov00 merged 4 commits intoelastic:masterfrom
Conversation
the elastic#1087 PR introduced a regression where the useDefaultGroupDomain was not considered when computing the scale configs.
nickofthyme
approved these changes
Apr 14, 2021
Collaborator
nickofthyme
left a comment
There was a problem hiding this comment.
LGTM, tested locally.
nickofthyme
reviewed
Apr 14, 2021
nickofthyme
pushed a commit
that referenced
this pull request
Apr 15, 2021
# [28.2.0](v28.1.0...v28.2.0) (2021-04-15) ### Bug Fixes * **xy:** consider `useDefaultGroupDomain` on scale config ([#1119](#1119)) ([c1b59f2](c1b59f2)), closes [#1087](#1087) ### Features * **a11y:** allow user to pass custom description for screen readers ([#1111](#1111)) ([2ee1b91](2ee1b91)), closes [#1097](#1097) * **partition:** add debuggable state ([#1117](#1117)) ([d7fc206](d7fc206)), closes [#917](#917)
Collaborator
|
🎉 This PR is included in version 28.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [28.2.0](elastic/elastic-charts@v28.1.0...v28.2.0) (2021-04-15) ### Bug Fixes * **xy:** consider `useDefaultGroupDomain` on scale config ([opensearch-project#1119](elastic/elastic-charts#1119)) ([269ff1a](elastic/elastic-charts@269ff1a)), closes [opensearch-project#1087](elastic/elastic-charts#1087) ### Features * **a11y:** allow user to pass custom description for screen readers ([opensearch-project#1111](elastic/elastic-charts#1111)) ([a0020ba](elastic/elastic-charts@a0020ba)), closes [#1097](elastic/elastic-charts#1097) * **partition:** add debuggable state ([opensearch-project#1117](elastic/elastic-charts#1117)) ([08f8baf](elastic/elastic-charts@08f8baf)), closes [opensearch-project#917](elastic/elastic-charts#917)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
useDefaultGroupDomainwas introduced to allow clustering of multiple series with a common Y domain.The #1087 PR introduced a regression where the
useDefaultGroupDomainwas not considered when defined as the actualgroupIdfor a specific group of series. This issue throws an error when a series useuseDefaultGroupDomainwith a groupId that doesn't exist in the chart configuration. This is an edge case but a legit one.Checklist
Delete any items that are not applicable to this PR.