[APM] Settings: Update layout and update/add descriptions#94398
Merged
formgeist merged 17 commits intoelastic:masterfrom Mar 16, 2021
formgeist:apm-update-settings-styles
Merged
[APM] Settings: Update layout and update/add descriptions#94398formgeist merged 17 commits intoelastic:masterfrom formgeist:apm-update-settings-styles
formgeist merged 17 commits intoelastic:masterfrom
formgeist:apm-update-settings-styles
Conversation
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
formgeist
commented
Mar 11, 2021
x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/index.tsx
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Mar 15, 2021
Contributor
sorenlouv
left a comment
There was a problem hiding this comment.
Awesome! Thanks for doing this @formgeist !
Contributor
Author
|
@elasticmachine merge upstream |
bmorelli25
reviewed
Mar 16, 2021
x-pack/plugins/apm/public/components/app/Settings/AgentConfigurations/index.tsx
Outdated
Show resolved
Hide resolved
Member
|
Should we also consider updating the empty state text for agent configuration? For example, we'll be adding the following text to the page:
The empty state text already says something very similar:
I think we could completely remove the empty state text (leaving only No configurations found) to avoid this duplication. |
…index.tsx Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
…rations/index.tsx Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Not needed as we have a description by the main title
Contributor
Author
Good catch! I agree - removed it in 5ba9113 |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @formgeist |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Mar 16, 2021
) * [APM] Align naming * [APM] Add agent config description * [APM] Update layout and styles * [APM] Update text styles and spacing * [APM] Updating styles and layout * [APM] Update layout and styles * [APM] Update description * [APM] Update layout and styles * [APM] Update i18n name * [APM] Add i18n description * [APM] Update layout and styles * Update x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/index.tsx Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * [APM] Update agent config description * Update x-pack/plugins/apm/public/components/app/Settings/AgentConfigurations/index.tsx Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * [APM] Remove empty state description Not needed as we have a description by the main title * [APM] Remove unneeded translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
Contributor
kibanamachine
added a commit
that referenced
this pull request
Mar 16, 2021
…94743) * [APM] Align naming * [APM] Add agent config description * [APM] Update layout and styles * [APM] Update text styles and spacing * [APM] Updating styles and layout * [APM] Update layout and styles * [APM] Update description * [APM] Update layout and styles * [APM] Update i18n name * [APM] Add i18n description * [APM] Update layout and styles * Update x-pack/plugins/apm/public/components/app/Settings/CustomizeUI/index.tsx Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * [APM] Update agent config description * Update x-pack/plugins/apm/public/components/app/Settings/AgentConfigurations/index.tsx Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> * [APM] Remove empty state description Not needed as we have a description by the main title * [APM] Remove unneeded translations Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com> Co-authored-by: Casper Hübertz <casper@elastic.co> Co-authored-by: Brandon Morelli <bmorelli25@gmail.com>
jloleysens
added a commit
that referenced
this pull request
Mar 17, 2021
…-action * 'master' of github.com:elastic/kibana: (44 commits) Migrate the optimizer mixin to core (#94272) Replace EuiCodeBlock with JsonCodeEditor in DiscoverGrid (#92442) [ML] Anomaly Detection: Migrate validation messages links to use docLinks. (#94568) [Lists][Exceptions] - Adding basic linting, i18n and storybook support (#94772) [Fleet] Add test/fix for invalid/missing ids in bulk agent reassign (#94632) [Security Solution] [Cases] Move create page components and dependencies to Cases (#94444) [ML] Data Frame Analytics accessibility tests: fix flaky outlier creation test (#94735) [Security Solutions] Remove commented out old linter rules (#94753) [App Search] Role mappings migration part 2 (#94461) [CI] Update Backport action inputs to match updated ones (#94721) [chore] Remove the infra team from CODEOWNERS (#94740) [Connectors UI] Make UI use new connector APIs (#94180) [ML] Use indices options in anomaly detection job wizards (#91830) Remove `string` as a valid registry var type value (#94174) [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. (#93364) [Reporting-CSV Export] Re-write CSV Export using SearchSource (#88303) chore(NA): upgrade bazel rules nodejs to v3.2.2 (#94726) [APM] Settings: Update layout and update/add descriptions (#94398) skip flaky suite (#94666) [XY axis] Integrates legend color picker with the eui palette (#90589) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/constants.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx # x-pack/plugins/index_lifecycle_management/public/shared_imports.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #71074
Updated styles and added descriptions to improve the layout and content across the four settings views.