Skip to content

[Fleet] Remove string as a valid registry var type value#94174

Merged
jen-huang merged 3 commits intoelastic:masterfrom
jen-huang:fix/remove-string-var-type
Mar 16, 2021
Merged

[Fleet] Remove string as a valid registry var type value#94174
jen-huang merged 3 commits intoelastic:masterfrom
jen-huang:fix/remove-string-var-type

Conversation

@jen-huang
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang commented Mar 9, 2021 •
edited
Loading

Summary

Follow up to elastic/package-storage#1011. This PR removes string from RegistryVarType, it is not a valid type according to the package spec but we added it in #93585 to get APM package working. The types have since been corrected in APM: elastic/apm-server#4931, elastic/package-storage#1012

‼️ Do not merge until prod package registry is deployed with the updated APM package

@jen-huang jen-huang added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v7.13.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Mar 9, 2021
@jen-huang jen-huang self-assigned this Mar 9, 2021
@jen-huang jen-huang requested a review from a team as a code owner March 9, 2021 18:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 9, 2021

Pinging @elastic/fleet (Team:Fleet)

skh
skh approved these changes Mar 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@skh skh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for pushing this.

@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Mar 16, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 16, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/discover/_doc_navigation·ts.discover app doc link in discover should open the doc view of the selected document

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:07:59]         └-: discover app
[00:07:59]           └-> "before all" hook in "discover app"
[00:07:59]           └-> "before all" hook in "discover app"
[00:23:51]           └-: doc link in discover
[00:23:51]             └-> "before all" hook for "should open the doc view of the selected document"
[00:23:51]             └-> should open the doc view of the selected document
[00:23:51]               └-> "before each" hook: global before each for "should open the doc view of the selected document"
[00:23:51]               └-> "before each" hook for "should open the doc view of the selected document"
[00:23:51]                 │ info [logstash_functional] Loading "mappings.json"
[00:23:51]                 │ info [logstash_functional] Loading "data.json.gz"
[00:23:51]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:23:51]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:23:51]                 │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:23:54]                 │ info [discover] Loading "mappings.json"
[00:23:54]                 │ info [discover] Loading "data.json"
[00:23:55]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_pre6.5.0_001/i1FR5xQwRWWgm9pjrWpt_w] deleting index
[00:23:55]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/RfpUtJNRQcitEoixb9Jskw] deleting index
[00:23:55]                 │ info [discover] Deleted existing index ".kibana_8.0.0_001"
[00:23:55]                 │ info [discover] Deleted existing index ".kibana_pre6.5.0_001"
[00:23:55]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana] creating index, cause [api], templates [], shards [1]/[1]
[00:23:55]                 │ info [discover] Created index ".kibana"
[00:23:55]                 │ debg [discover] ".kibana" settings {"index":{"number_of_replicas":"1","number_of_shards":"1"}}
[00:23:55]                 │ info [discover] Indexed 2 docs into ".kibana"
[00:23:55]                 │ debg Migrating saved objects
[00:23:55]                 │ proc [kibana]   log   [18:17:26.136] [info][savedobjects-service] [.kibana] INIT -> LEGACY_SET_WRITE_BLOCK
[00:23:55]                 │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] adding block write to indices [[.kibana/EWMC9ToCT7KI1gKK_Nmdeg]]
[00:23:55]                 │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] completed adding block write to indices [.kibana]
[00:23:55]                 │ proc [kibana]   log   [18:17:26.232] [info][savedobjects-service] [.kibana] LEGACY_SET_WRITE_BLOCK -> LEGACY_CREATE_REINDEX_TARGET
[00:23:55]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_pre6.5.0_001] creating index, cause [api], templates [], shards [1]/[1]
[00:23:55]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] updating number_of_replicas to [0] for indices [.kibana_pre6.5.0_001]
[00:23:55]                 │ proc [kibana]   log   [18:17:26.360] [info][savedobjects-service] [.kibana] LEGACY_CREATE_REINDEX_TARGET -> LEGACY_REINDEX
[00:23:55]                 │ proc [kibana]   log   [18:17:26.378] [info][savedobjects-service] [.kibana] LEGACY_REINDEX -> LEGACY_REINDEX_WAIT_FOR_TASK
[00:23:55]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] 11903 finished with response BulkByScrollResponse[took=39.4ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:23:55]                 │ proc [kibana]   log   [18:17:26.490] [info][savedobjects-service] [.kibana] LEGACY_REINDEX_WAIT_FOR_TASK -> LEGACY_DELETE
[00:23:55]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana/EWMC9ToCT7KI1gKK_Nmdeg] deleting index
[00:23:55]                 │ proc [kibana]   log   [18:17:26.559] [info][savedobjects-service] [.kibana] LEGACY_DELETE -> SET_SOURCE_WRITE_BLOCK
[00:23:55]                 │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] adding block write to indices [[.kibana_pre6.5.0_001/YDAwLDSOQ6mOoKvWzo0-VQ]]
[00:23:55]                 │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] completed adding block write to indices [.kibana_pre6.5.0_001]
[00:23:55]                 │ proc [kibana]   log   [18:17:26.613] [info][savedobjects-service] [.kibana] SET_SOURCE_WRITE_BLOCK -> CREATE_REINDEX_TEMP
[00:23:55]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_reindex_temp] creating index, cause [api], templates [], shards [1]/[1]
[00:23:55]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] updating number_of_replicas to [0] for indices [.kibana_8.0.0_reindex_temp]
[00:23:55]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_reindex_temp][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_reindex_temp][0]]"
[00:23:55]                 │ proc [kibana]   log   [18:17:26.740] [info][savedobjects-service] [.kibana] CREATE_REINDEX_TEMP -> REINDEX_SOURCE_TO_TEMP
[00:23:55]                 │ proc [kibana]   log   [18:17:26.773] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP -> REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK
[00:23:55]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] 11942 finished with response BulkByScrollResponse[took=31.7ms,timed_out=false,sliceId=null,updated=0,created=2,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:23:56]                 │ proc [kibana]   log   [18:17:26.880] [info][savedobjects-service] [.kibana] REINDEX_SOURCE_TO_TEMP_WAIT_FOR_TASK -> SET_TEMP_WRITE_BLOCK
[00:23:56]                 │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] adding block write to indices [[.kibana_8.0.0_reindex_temp/N03cmO3aSI-f8nH_deHVYw]]
[00:23:56]                 │ info [o.e.c.m.MetadataIndexStateService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] completed adding block write to indices [.kibana_8.0.0_reindex_temp]
[00:23:56]                 │ proc [kibana]   log   [18:17:27.019] [info][savedobjects-service] [.kibana] SET_TEMP_WRITE_BLOCK -> CLONE_TEMP_TO_TARGET
[00:23:56]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] applying create index request using existing index [.kibana_8.0.0_reindex_temp] metadata
[00:23:56]                 │ info [o.e.c.m.MetadataCreateIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001] creating index, cause [clone_index], templates [], shards [1]/[1]
[00:23:56]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] updating number_of_replicas to [0] for indices [.kibana_8.0.0_001]
[00:23:56]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/f_YmVWK7Sv--F2Ss31LPzA] create_mapping
[00:23:56]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] current.health="GREEN" message="Cluster health status changed from [YELLOW] to [GREEN] (reason: [shards started [[.kibana_8.0.0_001][0]]])." previous.health="YELLOW" reason="shards started [[.kibana_8.0.0_001][0]]"
[00:23:56]                 │ proc [kibana]   log   [18:17:27.318] [info][savedobjects-service] [.kibana] CLONE_TEMP_TO_TARGET -> OUTDATED_DOCUMENTS_SEARCH
[00:23:56]                 │ proc [kibana]   log   [18:17:27.342] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> OUTDATED_DOCUMENTS_TRANSFORM
[00:23:56]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/f_YmVWK7Sv--F2Ss31LPzA] update_mapping [_doc]
[00:23:56]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/f_YmVWK7Sv--F2Ss31LPzA] update_mapping [_doc]
[00:23:57]                 │ proc [kibana]   log   [18:17:28.135] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_TRANSFORM -> OUTDATED_DOCUMENTS_SEARCH
[00:23:57]                 │ proc [kibana]   log   [18:17:28.155] [info][savedobjects-service] [.kibana] OUTDATED_DOCUMENTS_SEARCH -> UPDATE_TARGET_MAPPINGS
[00:23:57]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/f_YmVWK7Sv--F2Ss31LPzA] update_mapping [_doc]
[00:23:57]                 │ proc [kibana]   log   [18:17:28.239] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS -> UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK
[00:23:57]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] 12003 finished with response BulkByScrollResponse[took=39.3ms,timed_out=false,sliceId=null,updated=2,created=0,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:23:57]                 │ proc [kibana]   log   [18:17:28.354] [info][savedobjects-service] [.kibana] UPDATE_TARGET_MAPPINGS_WAIT_FOR_TASK -> MARK_VERSION_INDEX_READY
[00:23:57]                 │ info [o.e.c.m.MetadataDeleteIndexService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_reindex_temp/N03cmO3aSI-f8nH_deHVYw] deleting index
[00:23:57]                 │ proc [kibana]   log   [18:17:28.457] [info][savedobjects-service] [.kibana] MARK_VERSION_INDEX_READY -> DONE
[00:23:57]                 │ proc [kibana]   log   [18:17:28.460] [info][savedobjects-service] [.kibana] Migration completed after 2339ms
[00:23:57]                 │ debg [discover] Migrated Kibana index after loading Kibana data
[00:23:57]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:23:57]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/f_YmVWK7Sv--F2Ss31LPzA] update_mapping [_doc]
[00:23:59]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC","visualization:visualize:legacyChartsLibrary":true}
[00:24:00]                 │ debg applying update to kibana config: {"timepicker:timeDefaults":"{ \"from\": \"2015-09-18T06:31:44.000Z\", \"to\": \"2015-09-23T18:31:44.000Z\"}"}
[00:24:01]                 │ debg navigating to discover url: http://localhost:6171/app/discover#/
[00:24:01]                 │ debg navigate to: http://localhost:6171/app/discover#/
[00:24:02]                 │ debg browser[INFO] http://localhost:6171/app/discover?_t=1615918652236#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:24:02]                 │
[00:24:02]                 │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:24:02]                 │ debg ... sleep(700) start
[00:24:02]                 │ debg ... sleep(700) end
[00:24:02]                 │ debg returned from get, calling refresh
[00:24:05]                 │ debg browser[INFO] http://localhost:6171/app/discover?_t=1615918652236#/ 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:24:05]                 │
[00:24:05]                 │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:24:05]                 │ debg currentUrl = http://localhost:6171/app/discover#/
[00:24:05]                 │          appUrl = http://localhost:6171/app/discover#/
[00:24:05]                 │ debg TestSubjects.find(kibanaChrome)
[00:24:05]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:24:05]                 │ debg ... sleep(501) start
[00:24:06]                 │ debg ... sleep(501) end
[00:24:06]                 │ debg in navigateTo url = http://localhost:6171/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!(!(%27@timestamp%27,desc)))
[00:24:06]                 │ debg --- retry.try error: URL changed, waiting for it to settle
[00:24:07]                 │ debg ... sleep(501) start
[00:24:07]                 │ debg ... sleep(501) end
[00:24:12]                 │ info [o.e.c.m.MetadataMappingService] [kibana-ci-immutable-debian-tests-xxl-1615915372480787001] [.kibana_8.0.0_001/f_YmVWK7Sv--F2Ss31LPzA] update_mapping [_doc]
[00:24:14]                 │ debg in navigateTo url = http://localhost:6171/app/discover#/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%272015-09-18T06:31:44.000Z%27,to:%272015-09-23T18:31:44.000Z%27))&_a=(columns:!(),filters:!(),index:%27logstash-*%27,interval:auto,query:(language:kuery,query:%27%27),sort:!(!(%27@timestamp%27,desc)))
[00:24:14]                 │ debg TestSubjects.exists(statusPageContainer)
[00:24:14]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:24:16]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:24:17]                 │ debg Find.waitForAttributeToChange('[data-test-subj="discoverDocTable"]', 'data-render-complete', 'true')
[00:24:17]                 │ debg Waiting up to 20000ms for data-render-complete to equal "true"...
[00:24:17]                 │ debg Find.findByCssSelector('[data-test-subj="discoverDocTable"]') with timeout=10000
[00:24:17]               │ debg TestSubjects.find(docTable)
[00:24:17]               │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:24:20]               │ debg TestSubjects.find(docTable)
[00:24:20]               │ debg Find.findByCssSelector('[data-test-subj="docTable"]') with timeout=10000
[00:24:22]               │ debg TestSubjects.exists(doc-hit)
[00:24:22]               │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="doc-hit"]') with timeout=2500
[00:24:22]               │ debg browser[INFO] http://localhost:6171/app/discover#/doc/logstash-*/logstash-2015.09.22?id=AU_x3_g4GFA8no6QjkYX 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:24:22]               │
[00:24:22]               │ debg browser[INFO] http://localhost:6171/bootstrap.js 41:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:24:24]               │ debg --- retry.tryForTime error: [data-test-subj="doc-hit"] is not displayed
[00:24:25]               │ info Taking screenshot "/dev/shm/workspace/parallel/7/kibana/test/functional/screenshots/failure/discover app doc link in discover should open the doc view of the selected document.png"
[00:24:25]               │ info Current URL is: http://localhost:6171/app/discover#/doc/logstash-*/logstash-2015.09.22?id=AU_x3_g4GFA8no6QjkYX
[00:24:26]               │ info Saving page source to: /dev/shm/workspace/parallel/7/kibana/test/functional/failure_debug/html/discover app doc link in discover should open the doc view of the selected document.html
[00:24:26]               └- ✖ fail: discover app doc link in discover should open the doc view of the selected document
[00:24:26]               │      Error: expected false to equal true
[00:24:26]               │       at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
[00:24:26]               │       at Assertion.be.Assertion.equal (node_modules/@kbn/expect/expect.js:227:8)
[00:24:26]               │       at Assertion.be (node_modules/@kbn/expect/expect.js:69:22)
[00:24:26]               │       at Context.<anonymous> (test/functional/apps/discover/_doc_navigation.ts:44:28)
[00:24:26]               │       at Object.apply (node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)
[00:24:26]               │ 
[00:24:26]               │

Stack Trace

Error: expected false to equal true
    at Assertion.assert (node_modules/@kbn/expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (node_modules/@kbn/expect/expect.js:227:8)
    at Assertion.be (node_modules/@kbn/expect/expect.js:69:22)
    at Context.<anonymous> (test/functional/apps/discover/_doc_navigation.ts:44:28)
    at Object.apply (node_modules/@kbn/test/src/functional_test_runner/lib/mocha/wrap_function.js:73:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 755.4KB 755.3KB -52.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 2374af3 into elastic:master Mar 16, 2021
@jen-huang
Copy link
Copy Markdown
Contributor Author

jen-huang commented Mar 16, 2021

Merged, the updated APM package was deployed on all envs.

@jen-huang jen-huang deleted the fix/remove-string-var-type branch March 16, 2021 19:32
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 16, 2021
@jen-huang @kibanamachine
Remove string as a valid registry var type value (elastic#94174)
9df835f 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 16, 2021
Merged
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 16, 2021
@jen-huang @kibanamachine
Remove string as a valid registry var type value (elastic#94174)
f3626a4 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Mar 16, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 16, 2021

💚 Backport successful

✅ 7.12 / #94751
✅ 7.x / #94752

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Mar 16, 2021
@kibanamachine @jen-huang
Remove string as a valid registry var type value (#94174) (#94751)
9b1a579 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
kibanamachine added a commit that referenced this pull request Mar 16, 2021
@kibanamachine @jen-huang
Remove string as a valid registry var type value (#94174) (#94752)
524ab01 
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
jloleysens added a commit that referenced this pull request Mar 17, 2021
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into ilm/rollup-v2…
29a96dd 
…-action

* 'master' of github.com:elastic/kibana: (44 commits)
  Migrate the optimizer mixin to core (#94272)
  Replace EuiCodeBlock with JsonCodeEditor in DiscoverGrid (#92442)
  [ML] Anomaly Detection: Migrate validation messages links to use docLinks. (#94568)
  [Lists][Exceptions] - Adding basic linting, i18n and storybook support (#94772)
  [Fleet] Add test/fix for invalid/missing ids in bulk agent reassign (#94632)
  [Security Solution] [Cases] Move create page components and dependencies to Cases (#94444)
  [ML] Data Frame Analytics accessibility tests: fix flaky outlier creation test (#94735)
  [Security Solutions] Remove commented out old linter rules (#94753)
  [App Search] Role mappings migration part 2 (#94461)
  [CI] Update Backport action inputs to match updated ones (#94721)
  [chore] Remove the infra team from CODEOWNERS (#94740)
  [Connectors UI] Make UI use new connector APIs (#94180)
  [ML] Use indices options in anomaly detection job wizards (#91830)
  Remove `string` as a valid registry var type value (#94174)
  [Alerts] Replaces legacy es client with the ElasticsearchClient for alerts and triggers_actions_ui plugins. (#93364)
  [Reporting-CSV Export] Re-write CSV Export using SearchSource (#88303)
  chore(NA): upgrade bazel rules nodejs to v3.2.2 (#94726)
  [APM] Settings: Update layout and update/add descriptions (#94398)
  skip flaky suite (#94666)
  [XY axis] Integrates legend color picker with the eui palette (#90589)
  ...

# Conflicts:
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/cold_phase/cold_phase.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/searchable_snapshot_field/searchable_snapshot_field.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/constants.ts
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx
#	x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/form/configuration_context.tsx
#	x-pack/plugins/index_lifecycle_management/public/shared_imports.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@skh skh skh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jen-huang jen-huang

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.12.0 v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jen-huang @elasticmachine @kibanamachine @skh