Skip to content

[Lens] Fix area percentage gaps with zero fitting function#94086

Merged
dej611 merged 3 commits intoelastic:masterfrom
dej611:fix/93648-2
Mar 11, 2021
Merged

[Lens] Fix area percentage gaps with zero fitting function#94086
dej611 merged 3 commits intoelastic:masterfrom
dej611:fix/93648-2

Conversation

@dej611
Copy link
Copy Markdown
Contributor

@dej611 dej611 commented Mar 9, 2021

Summary

Fixes #93648

Alternative to #93812 as discussed with @nickofthyme .

I've implemented the alternative solution using the fit="zero" solution, but I still see some gaps in the middle of the stacked area.

Screenshot 2021-03-09 at 14 44 16

Between the 2021-24-02 00:00 and 12:00 there's still a gap not filled with the fitting function. I've used the logs sample dataset, but if the specific data is required let me know.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

nickofthyme
nickofthyme approved these changes Mar 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@nickofthyme nickofthyme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@dej611 dej611 changed the title [Lens] Fix area percentage gaps (fitting solution) [Lens] Fix area percentage gaps with zero fitting function Mar 9, 2021
@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Mar 9, 2021

@elasticmachine merge upstream

@nickofthyme nickofthyme mentioned this pull request Mar 9, 2021
Closed
@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Mar 9, 2021

Gaps will be fixed in a patched version of elastic charts with elastic/elastic-charts#1067

@dej611 dej611 added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Mar 11, 2021
@dej611 dej611 marked this pull request as ready for review March 11, 2021 10:11
@dej611 dej611 requested a review from a team March 11, 2021 10:11
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 11, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

@dej611
Copy link
Copy Markdown
Contributor Author

dej611 commented Mar 11, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 11, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 921.8KB 921.9KB +110.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

flash1293
flash1293 approved these changes Mar 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, works as expected

@dej611 dej611 added the auto-backport Deprecated - use backport:version if exact versions are needed label Mar 11, 2021
@dej611 dej611 merged commit ed95c08 into elastic:master Mar 11, 2021
@dej611 dej611 deleted the fix/93648-2 branch March 11, 2021 16:04
@kibanamachine kibanamachine mentioned this pull request Mar 11, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 11, 2021

💚 Backport successful

✅ 7.x / #94452

Successful backport PRs will be merged automatically after passing CI.

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Mar 11, 2021
@dej611 @kibanamachine
[Lens] Fix area percentage gaps with zero fitting function (elastic#9…
a02c047 
…4086)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Mar 11, 2021
@kibanamachine @dej611
[Lens] Fix area percentage gaps with zero fitting function (#94086) (#…
5ae7dd7 
…94452)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Marco Liberati <dej611@users.noreply.github.com>
@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Mar 15, 2021 •
edited
Loading

@flash1293 and @dej611 Since this issue has likely been in past kibana releases depending on when this regression was caused in chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=1163912). What do you guys think about merging this patch fix (elastic/elastic-charts#1067) into 7.12? Should we wait for 7.12.1?

cc: @markov00

@flash1293
Copy link
Copy Markdown
Contributor

flash1293 commented Mar 15, 2021

It's fine for 7.12 for me cc @timroes

@nickofthyme
Copy link
Copy Markdown
Contributor

nickofthyme commented Mar 16, 2021

Ok, merged here #94698

@dej611 dej611 mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flash1293 flash1293 flash1293 approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.13.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] Percentage charts can have gaps in a series

5 participants

@dej611 @nickofthyme @elasticmachine @kibanamachine @flash1293