[Lens] Prevent gaps in percentage charts#93812
[Lens] Prevent gaps in percentage charts#93812dej611 wants to merge 2 commits intoelastic:masterfrom
Conversation
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
That's a pretty involved change (I thought it would just be about @nickofthyme do you have a rough time frame for elastic/elastic-charts#1053 ? Will it land in 7.13? If that's the case and it would avoid the need for this PR I would be more comfortable with waiting until it can be fixed in a nice way. If the upstream fix won't cover the full bug, then it makes sense to merge this. |
|
@flash1293 I'll look at this today and get a better idea of the timeline. My hunch is that this should be easy to fix in charts and patch the |
|
Per discussion with @dej611 and @markov00... The gaps are created when values are missing as indended. See https://codesandbox.io/s/voltron-lij5x?file=/src/App.tsx Screen.Recording.2021-03-08.at.12.41.11.PM.mp4
which filling missing values with Actions: |
|
Closing in favor of #94086 |
Summary
Fixes #93648
This PR addresses a bug, from the consumer side, of the elastic-charts library with missing buckets in date histograms.
Also, as a nice side effect, it fixes also the tooltip behaviour, showing now all series all the time in the chart.
Combined with #93717 (which contains a fix for percentage charts with overflow buckets) it completely fixes the problem. Already tested together.
Before:
After:
Tooltip issue before:

Tooltip after: