[KQL] Remove number parsing#93658
Merged
lukasolson merged 4 commits intoelastic:masterfrom Mar 7, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-services (Team:AppServices) |
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
tsullivan
approved these changes
Mar 5, 2021
Member
tsullivan
left a comment
There was a problem hiding this comment.
LGTM! Thanks for walking me through the changes
FrankHassanabad
approved these changes
Mar 5, 2021
Contributor
💚 Build SucceededMetrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: cc @lukasolson |
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 9, 2021
* [KQL] Remove number parsing * Update test snapshots
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Mar 9, 2021
* [KQL] Remove number parsing * Update test snapshots
lukasolson
added a commit
that referenced
this pull request
Mar 9, 2021
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
lukasolson
added a commit
that referenced
this pull request
Mar 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #48835.
Fixes #81581.
Fixes #85548.
Prior to this PR, when parsing a KQL expression, we would attempt to distinguish numbers from regular strings. This has been error-prone because of regex issues and handling numbers larger than JavaScript can handle. If we don't distinguish between strings and numbers, the queries that are generated and sent to Elasticsearch work regardless of whether they're passed as numbers or strings, so we can remove this behavior altogether.
Checklist
Delete any items that are not applicable to this PR.
For maintainers
Release note
KQL will no longer incorrectly parse unquoted strings as numbers.