Skip to content

[7.12] [KQL] Remove number parsing (#93658)#94102

Merged
lukasolson merged 3 commits intoelastic:7.12from
lukasolson:backport/7.12/pr-93658
Mar 10, 2021
Merged

[7.12] [KQL] Remove number parsing (#93658)#94102
lukasolson merged 3 commits intoelastic:7.12from
lukasolson:backport/7.12/pr-93658

Conversation

@lukasolson
Copy link
Copy Markdown
Contributor

@lukasolson lukasolson commented Mar 9, 2021

Backports the following commits to 7.12:

@lukasolson
[KQL] Remove number parsing (elastic#93658)
67fe6cf 
* [KQL] Remove number parsing

* Update test snapshots
@lukasolson lukasolson added the backport This PR is a backport of another PR label Mar 9, 2021
@lukasolson lukasolson enabled auto-merge (squash) March 9, 2021 14:57
@lukasolson
Copy link
Copy Markdown
Contributor Author

lukasolson commented Mar 9, 2021

@elasticmachine merge upstream

@lukasolson
Copy link
Copy Markdown
Contributor Author

lukasolson commented Mar 10, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Mar 10, 2021

💛 Build succeeded, but was flaky

Test Failures

Kibana Pipeline / general / "before all" hook for "should open a modal".Open timeline Open timeline modal "before all" hook for "should open a modal"

Link to Jenkins

Stack Trace

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

AssertionError: Timed out retrying after 60000ms: Expected to find element: `[data-test-subj="title-07c86360-81bc-11eb-a8a0-7d59975f91f6"]`, but never found it.

Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Open timeline`

Although you have test retries enabled, we do not retry tests when `before all` or `after all` hooks fail
    at Object.openTimelineById (http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/open_timeline.spec.ts:16089:15)
    at Context.eval (http://localhost:6121/__cypress/tests?p=cypress/integration/timelines/open_timeline.spec.ts:15046:28)

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
data 822.1KB 821.9KB -139.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lukasolson lukasolson merged commit c4a3c98 into elastic:7.12 Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukasolson @kibanamachine