[XY Chart] Fix "No data to display" error when using IP range aggregation to split series by DianaDerevyankina · Pull Request #93024 · elastic/kibana

DianaDerevyankina · 2021-03-01T13:19:24Z

Summary

Fix "No data to display" error for XY chart.

For IP range aggregation visData contains data with range object instead of simple string or number, so series should have complex accessors in this case.

Added an IP range for aggregation range types check.

For maintainers

This was checked for breaking API changes and was labeled appropriately

This reverts commit f2b088e.

alexwizp

LGTM! Thank you

elasticmachine · 2021-03-01T14:26:10Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula

LGTM, tested it locally, now the ip range works either with split series or as an aggregation on the x-axis

stratoula · 2021-03-01T16:08:40Z

@elasticmachine run elasticsearch-ci/docs

nickofthyme · 2021-03-01T16:15:45Z

src/plugins/vis_type_xy/public/utils/accessors.tsx


 export const isRangeAggType = (type: string | null) =>
-  type === BUCKET_TYPES.DATE_RANGE || type === BUCKET_TYPES.RANGE;
+  type === BUCKET_TYPES.DATE_RANGE || type === BUCKET_TYPES.RANGE || type === BUCKET_TYPES.IP_RANGE;


wylieconlon

Can you add some tests for this?

wylieconlon

Marking as change requested for three reasons:

No tests
The title of the PR does not meet our release note standards. If this title appeared in our release notes, users might think that you've removed the IP range split. Instead, the title should answer the question "what can I do now that was broken before?"
The PR labels indicate that this is for 7.12.1, which is only true if you merge this after we release 7.12- anything merged before 7.12 is released onto the 7.12 branch will be 7.12.0

stratoula · 2021-03-02T06:45:23Z

@wylieconlon thank you for your review. I agree, it is a great opportunity to add tests, I also missed the label, I changed it. We plan to merge it for 7.12.0. As this is a bug introduced with the new xy plugin that will be released on 7.12.0 too, this PR won't appear on the release notes as the bug "never existed". Nevertheless, the title is confusing and needs to be changed 👍

kibanamachine · 2021-03-02T14:03:39Z

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`visTypeXy`	119.8KB	119.9KB	+46.0B

History

💚 Build #109903 succeeded ce750bf
💚 Build #109887 succeeded 1f9273c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dziyanadzeraviankina

stratoula · 2021-03-02T14:18:26Z

@elasticmachine run elasticsearch-ci/docs

wylieconlon

Thanks, LGTM! Please add the 7.13.0 tag as well.

…tion to split series (elastic#93024) * Visualize: Can't use ip range to split series in xy chart * Refactor accessors.tsx * Revert "Refactor accessors.tsx" This reverts commit f2b088e. * Add accessors.test to cover getComplexAccessor function

…tion to split series (#93024) (#93368) * Visualize: Can't use ip range to split series in xy chart * Refactor accessors.tsx * Revert "Refactor accessors.tsx" This reverts commit f2b088e. * Add accessors.test to cover getComplexAccessor function

…tion to split series (#93024) (#93367) * Visualize: Can't use ip range to split series in xy chart * Refactor accessors.tsx * Revert "Refactor accessors.tsx" This reverts commit f2b088e. * Add accessors.test to cover getComplexAccessor function

* master: (45 commits) Add outcome of node scripts/build_api_docs (elastic#93399) [Lens] fix long field name on field stats panel doesn't wrap (elastic#93279) [Bug] Fix filter creation for numeric scripted fields in Discover (elastic#93224) [uptime] Fix anomaly alert edit (elastic#93025) Consolidate @babel/* packages and use latest compatible version (elastic#93264) [Search Embeddable] Add highlighting when searching (elastic#93178) [APM] Add missing bottom border to header (elastic#93179) [CI] No longer collect APM span stack traces (elastic#93263) [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (elastic#93024) update generated public api docs API DOCS Step 3/3 (elastic#92929) chore(NA): look for bazel packages on npm_module folder during distributable build (elastic#93262) rename advanced setting ml:fileDataVisualizerMaxFileSize to fileUpload:maxFileSize and increase max geojson upload size to 1GB (elastic#92620) [kbn/optimizer] allow customizing the limits path from the script (elastic#93153) [Alerting][Docs] Adding template for documenting alert and action types (elastic#92830) [jenkins] convert baseline capture job to use tasks (elastic#93288) removing the linked issue in comments from PR (elastic#93303) chore(NA): do not include fs within a storybook build (elastic#93294) [Maps] Update Map extent queries to use bounding box logic for both point and shape queries (elastic#93156) Add searchDuration to EQL and Threshold rules (elastic#93149) ...

Visualize: Can't use ip range to split series in xy chart

1f9273c

DianaDerevyankina added Feature:XYAxis XY-Axis charts (bar, area, line) Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.1 labels Mar 1, 2021

DianaDerevyankina requested review from alexwizp and nickofthyme March 1, 2021 13:19

DianaDerevyankina self-assigned this Mar 1, 2021

DianaDerevyankina added 2 commits March 1, 2021 17:03

Refactor accessors.tsx

f2b088e

Revert "Refactor accessors.tsx"

ce750bf

This reverts commit f2b088e.

alexwizp approved these changes Mar 1, 2021

View reviewed changes

DianaDerevyankina marked this pull request as ready for review March 1, 2021 14:26

DianaDerevyankina requested a review from a team March 1, 2021 14:26

stratoula approved these changes Mar 1, 2021

View reviewed changes

nickofthyme approved these changes Mar 1, 2021

View reviewed changes

wylieconlon reviewed Mar 1, 2021

View reviewed changes

wylieconlon suggested changes Mar 1, 2021

View reviewed changes

stratoula added v7.12.0 and removed v7.12.1 labels Mar 2, 2021

DianaDerevyankina changed the title ~~Visualize: Can't use ip range to split series in xy chart~~ [XY Chart] Fix "No data to display" error when using IP range aggregation to split series Mar 2, 2021

Add accessors.test to cover getComplexAccessor function

5a06926

wylieconlon approved these changes Mar 2, 2021

View reviewed changes

alexwizp added the v7.13.0 label Mar 3, 2021

DianaDerevyankina merged commit 7bd1f6f into elastic:master Mar 3, 2021

DianaDerevyankina mentioned this pull request Mar 3, 2021

[7.x] [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (#93024) #93367

Merged

DianaDerevyankina mentioned this pull request Mar 3, 2021

[7.12] [XY Chart] Fix "No data to display" error when using IP range aggregation to split series (#93024) #93368

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[XY Chart] Fix "No data to display" error when using IP range aggregation to split series#93024

[XY Chart] Fix "No data to display" error when using IP range aggregation to split series#93024
DianaDerevyankina merged 4 commits intoelastic:masterfrom
DianaDerevyankina:issues/92835

DianaDerevyankina commented Mar 1, 2021

Uh oh!

alexwizp left a comment

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

stratoula left a comment

Uh oh!

stratoula commented Mar 1, 2021

Uh oh!

nickofthyme Mar 1, 2021

Uh oh!

wylieconlon left a comment

Uh oh!

wylieconlon left a comment

Uh oh!

stratoula commented Mar 2, 2021

Uh oh!

kibanamachine commented Mar 2, 2021

Uh oh!

stratoula commented Mar 2, 2021

Uh oh!

wylieconlon left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

DianaDerevyankina commented Mar 1, 2021

Summary

For maintainers

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 1, 2021

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Mar 1, 2021

Uh oh!

nickofthyme Mar 1, 2021

Choose a reason for hiding this comment

Uh oh!

wylieconlon left a comment

Choose a reason for hiding this comment

Uh oh!

wylieconlon left a comment

Choose a reason for hiding this comment

Uh oh!

stratoula commented Mar 2, 2021

Uh oh!

kibanamachine commented Mar 2, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

History

Uh oh!

stratoula commented Mar 2, 2021

Uh oh!

wylieconlon left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants