Removes "global-style" setting for npm#9256
Merged
epixa merged 1 commit intoelastic:masterfrom Nov 29, 2016
Merged
Conversation
This change, which was originally introduced in elastic#9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides.
This was referenced Nov 29, 2016
elastic-jasper
added a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
epixa
pushed a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
epixa
pushed a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in elastic#9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z Former-commit-id: 9b43bdc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change, which was originally introduced in #9136, resulted in much
larger installs for Kibana (50MB larger in dev mode), which isn't a
reasonable tradeoff for the convenience that global-style provides.