REVERTED in #9256 - [npm] install deps "global-style"#9136
Merged
Conversation
Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper.
Contributor
|
Can you do a rough analysis on path lengths in Kibana right now with this enabled? |
Contributor
Author
|
Interestingly enough, it doesn't effect the longest path in the dependencies: 191 characters, and it's installed with the same path regardless of global-style to find the longest path: |
Contributor
Author
|
Also interesting, the same is true with |
Contributor
Author
|
If I install just production dependencies I get 126 in normal mode, and 130 in global-style mode # deduped tree 126
node_modules/@elastic/kibana-ui-framework/src/guide/views/local_nav/local_nav_menu_item_states/local_nav_menu_item_states.html
# global-style 130
node_modules/bunyan/node_modules/dtrace-provider/build/Release/.deps/Release/obj.target/DTraceProviderBindings/dtrace_provider.o.dSo, it actually doesn't have much impact on the bottom line |
Contributor
|
I can't think of any problems this would create, so I guess we should just see it in action. I do like the result of the change. LGTM @spalger Can you do the same change for x-pack as well? |
jbudz
approved these changes
Nov 21, 2016
elastic-jasper
added a commit
that referenced
this pull request
Nov 21, 2016
Backports PR #9136 **Commit 1:** [npm] install deps "global-sytle" Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper. * Original sha: 95103f0 * Authored by Spencer <spalger@users.noreply.github.com> on 2016-11-18T16:43:54Z * Committed by GitHub <noreply@github.com> on 2016-11-18T16:43:54Z
epixa
pushed a commit
that referenced
this pull request
Nov 21, 2016
Backports PR #9136 **Commit 1:** [npm] install deps "global-sytle" Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper. * Original sha: 95103f0 * Authored by Spencer <spalger@users.noreply.github.com> on 2016-11-18T16:43:54Z * Committed by GitHub <noreply@github.com> on 2016-11-18T16:43:54Z
epixa
added a commit
to epixa/kibana
that referenced
this pull request
Nov 29, 2016
This change, which was originally introduced in elastic#9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides.
epixa
added a commit
that referenced
this pull request
Nov 29, 2016
This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides.
This was referenced Nov 29, 2016
elastic-jasper
added a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
elastic-jasper
added a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
epixa
pushed a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
epixa
pushed a commit
that referenced
this pull request
Nov 29, 2016
Backports PR #9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in #9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9136 **Commit 1:** [npm] install deps "global-sytle" Installing dependencies "global-style" creates a top-level directory in `node_modules` for each direct dependency, and then creates a flat tree of dependencies inside each of those. I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in `node_modules`. Unfortunately the `node_modules` directory will be a little deeper. * Original sha: 95103f0 * Authored by Spencer <spalger@users.noreply.github.com> on 2016-11-18T16:43:54Z * Committed by GitHub <noreply@github.com> on 2016-11-18T16:43:54Z Former-commit-id: 269ee06
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
Backports PR elastic#9256 **Commit 1:** Removes "global-style" setting for npm This change, which was originally introduced in elastic#9136, resulted in much larger installs for Kibana (50MB larger in dev mode), which isn't a reasonable tradeoff for the convenience that global-style provides. * Original sha: bdf4c68 * Authored by Court Ewing <court@epixa.com> on 2016-11-29T20:29:43Z Former-commit-id: 9b43bdc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installing dependencies "global-style" creates a top-level directory in
node_modulesfor each direct dependency, and then creates a flat tree of dependencies inside each of those.I prefer this method because it prevents accidentally depending on a dependency of a dependency, and makes it easier to find dependencies in
node_modules.Unfortunately the
node_modulesdirectory will be a little deeper.