Skip to content

[5.x] [timelion] Secondary y-axis no longer removes config on first axis#9199

Merged
epixa merged 1 commit into5.xfrom
jasper/backport/9197/5.x
Nov 23, 2016
Merged

[5.x] [timelion] Secondary y-axis no longer removes config on first axis#9199
epixa merged 1 commit into5.xfrom
jasper/backport/9197/5.x

Conversation

@elastic-jasper
Copy link
Copy Markdown
Contributor

[timelion] fixing Y axis #9114

Backports PR #9197

Commit 1:
fixing timelion Y axis #9114

Backports PR #9197

**Commit 1:**
fixing timelion Y axis #9114

* Original sha: 54107d6
* Authored by ppisljar <peter.pisljar@gmail.com> on 2016-11-23T09:37:52Z
@elastic-jasper elastic-jasper added the backport This PR is a backport of another PR label Nov 23, 2016
@epixa epixa changed the title [5.x] [timelion] fixing Y axis #9114 [5.x] [timelion] fixing Y axis Nov 23, 2016
@epixa epixa changed the title [5.x] [timelion] fixing Y axis [5.x] [timelion] Secondary y-axis no longer removes config on first axis Nov 23, 2016
@epixa epixa merged commit 29240b6 into 5.x Nov 23, 2016
@epixa epixa deleted the jasper/backport/9197/5.x branch November 23, 2016 15:50
mgadewoll added a commit that referenced this pull request Dec 2, 2025
- `@elastic/eui`: `v109.1.0` ⏩ `v109.2.0`
- `@elastic/eui-theme-borealis`: `v5.0.0` ⏩ `v5.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

- Only snapshot updates related to EuiPopover, ToolTip and Table changes
(see below)

## Package updates

### `@elastic/eui` v109.2.0

- Updated `EuiFlexItem` to fall back to `grow={true}` if invalid values
for `grow` are passed
([#9228](elastic/eui#9228))
- Updated shared button styles in `useEuiButtonColorCSS` to use
`euiDisabledSelector`
([#9226](elastic/eui#9226))
- Added `euiTextTruncateCSS` Emotion style utility
([#9231](elastic/eui#9231))
- Added `hasBackground` prop on `EuiTable`, `EuiBasicTable` and
`EuiInMemoryTable` ([#9224](elastic/eui#9224))
- Added component token `components.tableFooterBackground`
([#9224](elastic/eui#9224))
- Updated the color of mobile table header cells to use
`colors.textSubdued` ([#9224](elastic/eui#9224))
- Updated `EuiSuperDatePicker` to show a tooltip with the full range
details when the button displays a pretty duration e.g. "Last 15
minutes" ([#9221](elastic/eui#9221))
- Updated `EuiPopover` default prop values of `hasArrow`, `position` and
`offset`: ([#9218](elastic/eui#9218))
  - Changed `hasArrow` to `false`
  - Changed `position` to `downLeft`
  - Changed `offset` to `4` when `hasArrow=false`
- Updated `EuiInputPopover` `offset` default value to `2`
([#9218](elastic/eui#9218))
- Updated `EuiTourStep` to not apply `hasArrow=true` by default when
`decoration="none"` ([#9218](elastic/eui#9218))
- Updated `EuiSuperDatePicker` to have a more forgiving manual input for
absolute dates. ([#9199](elastic/eui#9199))

**Bug fixes**

- Updated EuiButtonGroup disabled style selectors to use
`euiDisabledSelector` to ensure high contrast mode styles apply
correctly ([#9226](elastic/eui#9226))
- Updated `EuiSuperDatePicker` to ensure its pretty format button dates
are truncated correctly
([#9231](elastic/eui#9231))
- Fixed a visual bug for mobile table action buttons that causes
shifting positions when changing color mode
([#8231](elastic/eui#8231))
([#9224](elastic/eui#9224))

**Accessibility**

- Improved the navigation of sibling `EuiToolTip` anchor elements in
NVDA browse mode by adding an `id` to ensure they are unique
([#9208](elastic/eui#9208))

### `@elastic/eui-theme-borealis` v5.1.0

- Added component token `components.tableFooterBackground`
([#9224](elastic/eui#9224))

---------

Co-authored-by: Jorge Sanz <jorge.sanz@elastic.co>
Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
NicholasPeretti pushed a commit to NicholasPeretti/kibana that referenced this pull request Dec 2, 2025
- `@elastic/eui`: `v109.1.0` ⏩ `v109.2.0`
- `@elastic/eui-theme-borealis`: `v5.0.0` ⏩ `v5.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

- Only snapshot updates related to EuiPopover, ToolTip and Table changes
(see below)

## Package updates

### `@elastic/eui` v109.2.0

- Updated `EuiFlexItem` to fall back to `grow={true}` if invalid values
for `grow` are passed
([elastic#9228](elastic/eui#9228))
- Updated shared button styles in `useEuiButtonColorCSS` to use
`euiDisabledSelector`
([elastic#9226](elastic/eui#9226))
- Added `euiTextTruncateCSS` Emotion style utility
([elastic#9231](elastic/eui#9231))
- Added `hasBackground` prop on `EuiTable`, `EuiBasicTable` and
`EuiInMemoryTable` ([elastic#9224](elastic/eui#9224))
- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))
- Updated the color of mobile table header cells to use
`colors.textSubdued` ([elastic#9224](elastic/eui#9224))
- Updated `EuiSuperDatePicker` to show a tooltip with the full range
details when the button displays a pretty duration e.g. "Last 15
minutes" ([elastic#9221](elastic/eui#9221))
- Updated `EuiPopover` default prop values of `hasArrow`, `position` and
`offset`: ([elastic#9218](elastic/eui#9218))
  - Changed `hasArrow` to `false`
  - Changed `position` to `downLeft`
  - Changed `offset` to `4` when `hasArrow=false`
- Updated `EuiInputPopover` `offset` default value to `2`
([elastic#9218](elastic/eui#9218))
- Updated `EuiTourStep` to not apply `hasArrow=true` by default when
`decoration="none"` ([elastic#9218](elastic/eui#9218))
- Updated `EuiSuperDatePicker` to have a more forgiving manual input for
absolute dates. ([elastic#9199](elastic/eui#9199))

**Bug fixes**

- Updated EuiButtonGroup disabled style selectors to use
`euiDisabledSelector` to ensure high contrast mode styles apply
correctly ([elastic#9226](elastic/eui#9226))
- Updated `EuiSuperDatePicker` to ensure its pretty format button dates
are truncated correctly
([elastic#9231](elastic/eui#9231))
- Fixed a visual bug for mobile table action buttons that causes
shifting positions when changing color mode
([elastic#8231](elastic/eui#8231))
([elastic#9224](elastic/eui#9224))

**Accessibility**

- Improved the navigation of sibling `EuiToolTip` anchor elements in
NVDA browse mode by adding an `id` to ensure they are unique
([elastic#9208](elastic/eui#9208))

### `@elastic/eui-theme-borealis` v5.1.0

- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))

---------

Co-authored-by: Jorge Sanz <jorge.sanz@elastic.co>
Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
JordanSh pushed a commit to JordanSh/kibana that referenced this pull request Dec 9, 2025
- `@elastic/eui`: `v109.1.0` ⏩ `v109.2.0`
- `@elastic/eui-theme-borealis`: `v5.0.0` ⏩ `v5.1.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

---

## Changes

- Only snapshot updates related to EuiPopover, ToolTip and Table changes
(see below)

## Package updates

### `@elastic/eui` v109.2.0

- Updated `EuiFlexItem` to fall back to `grow={true}` if invalid values
for `grow` are passed
([elastic#9228](elastic/eui#9228))
- Updated shared button styles in `useEuiButtonColorCSS` to use
`euiDisabledSelector`
([elastic#9226](elastic/eui#9226))
- Added `euiTextTruncateCSS` Emotion style utility
([elastic#9231](elastic/eui#9231))
- Added `hasBackground` prop on `EuiTable`, `EuiBasicTable` and
`EuiInMemoryTable` ([elastic#9224](elastic/eui#9224))
- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))
- Updated the color of mobile table header cells to use
`colors.textSubdued` ([elastic#9224](elastic/eui#9224))
- Updated `EuiSuperDatePicker` to show a tooltip with the full range
details when the button displays a pretty duration e.g. "Last 15
minutes" ([elastic#9221](elastic/eui#9221))
- Updated `EuiPopover` default prop values of `hasArrow`, `position` and
`offset`: ([elastic#9218](elastic/eui#9218))
  - Changed `hasArrow` to `false`
  - Changed `position` to `downLeft`
  - Changed `offset` to `4` when `hasArrow=false`
- Updated `EuiInputPopover` `offset` default value to `2`
([elastic#9218](elastic/eui#9218))
- Updated `EuiTourStep` to not apply `hasArrow=true` by default when
`decoration="none"` ([elastic#9218](elastic/eui#9218))
- Updated `EuiSuperDatePicker` to have a more forgiving manual input for
absolute dates. ([elastic#9199](elastic/eui#9199))

**Bug fixes**

- Updated EuiButtonGroup disabled style selectors to use
`euiDisabledSelector` to ensure high contrast mode styles apply
correctly ([elastic#9226](elastic/eui#9226))
- Updated `EuiSuperDatePicker` to ensure its pretty format button dates
are truncated correctly
([elastic#9231](elastic/eui#9231))
- Fixed a visual bug for mobile table action buttons that causes
shifting positions when changing color mode
([elastic#8231](elastic/eui#8231))
([elastic#9224](elastic/eui#9224))

**Accessibility**

- Improved the navigation of sibling `EuiToolTip` anchor elements in
NVDA browse mode by adding an `id` to ensure they are unique
([elastic#9208](elastic/eui#9208))

### `@elastic/eui-theme-borealis` v5.1.0

- Added component token `components.tableFooterBackground`
([elastic#9224](elastic/eui#9224))

---------

Co-authored-by: Jorge Sanz <jorge.sanz@elastic.co>
Co-authored-by: Lene Gadewoll <lene.gadewoll@elastic.co>
acstll added a commit that referenced this pull request Mar 19, 2026
## Summary

> [!IMPORTANT]
> the `DateRangePicker` component this is touching will be in Technical
Preview

This PR adds the missing parts to make `DateRangePicker`
feature-complete to start a QA process.

Resolves elastic/eui-private#515 🔒 
Resolves elastic/eui-private#516 🔒 
Resolves elastic/eui-private#517 🔒 
Resolves elastic/eui-private#519 🔒 

Changes outlines right below.

### Changes

#### Parser small improvements


838c6c3

- make the input more forgiving with absolute dates (see
[eui/#9199](elastic/eui#9199))
- use a dash as default delimiter e.g. `feb 1 - feb 3`, also supporting
others e.g. `to` or `until`
- support shorthand-specific unit forms while still being handling date
math as before e.g. `-6M` and `-6mos` are the same
- a bit better test coverage
- matches presets _before_ parsing, as expected
- add an option to round relative times (wired up with settings)
45618ea

##### QA suggestion
* [x] verify input is forgiving with absolute dates in RFC 2822-ish
* [x] verify dash works as a delimiter, also `to` and `until`
* [x] verify shorthand units for minutes and months works in strict
dateMath and our custom syntax `min` -> `m`, `mos` -> `M`
* [x] presets are matched correctly, both by typing and selecting from
the list

#### Documentation panel


0b3c5d5

- a button to navigate to it is visible when the input is cleared
- contents are not final

##### QA suggestion
* [x] verify the button shows when the input clears and navigates
correctly

#### Settings panel and `settings` / `onSettingsChange` props 


13ad343

- can be opened via the gear icon button on the footer
- features only one setting, "Round relative time ranges" →
`roundRelativeTime`
- introduces mandatory `settings` and `onSettingsChange` props

##### QA suggestion
* [x] verify toggling "Round relative time ranges" works as expected
(rounding is applied when "on", to the start bound only)

#### Time zone in main panel


fc69e8b

- display the time zone in the main panel's footer
- does not handle `Browser` as a value, this will be fixed separately
- no tests for now

##### QA suggestion
* [x] verify the time zone is displayed as expected (if no valid iana
name passed, it shouldn't show)

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
flash1293 pushed a commit to flash1293/kibana that referenced this pull request Mar 19, 2026
## Summary

> [!IMPORTANT]
> the `DateRangePicker` component this is touching will be in Technical
Preview

This PR adds the missing parts to make `DateRangePicker`
feature-complete to start a QA process.

Resolves elastic/eui-private#515 🔒 
Resolves elastic/eui-private#516 🔒 
Resolves elastic/eui-private#517 🔒 
Resolves elastic/eui-private#519 🔒 

Changes outlines right below.

### Changes

#### Parser small improvements


elastic@838c6c3

- make the input more forgiving with absolute dates (see
[eui/elastic#9199](elastic/eui#9199))
- use a dash as default delimiter e.g. `feb 1 - feb 3`, also supporting
others e.g. `to` or `until`
- support shorthand-specific unit forms while still being handling date
math as before e.g. `-6M` and `-6mos` are the same
- a bit better test coverage
- matches presets _before_ parsing, as expected
- add an option to round relative times (wired up with settings)
elastic@45618ea

##### QA suggestion
* [x] verify input is forgiving with absolute dates in RFC 2822-ish
* [x] verify dash works as a delimiter, also `to` and `until`
* [x] verify shorthand units for minutes and months works in strict
dateMath and our custom syntax `min` -> `m`, `mos` -> `M`
* [x] presets are matched correctly, both by typing and selecting from
the list

#### Documentation panel


elastic@0b3c5d5

- a button to navigate to it is visible when the input is cleared
- contents are not final

##### QA suggestion
* [x] verify the button shows when the input clears and navigates
correctly

#### Settings panel and `settings` / `onSettingsChange` props 


elastic@13ad343

- can be opened via the gear icon button on the footer
- features only one setting, "Round relative time ranges" →
`roundRelativeTime`
- introduces mandatory `settings` and `onSettingsChange` props

##### QA suggestion
* [x] verify toggling "Round relative time ranges" works as expected
(rounding is applied when "on", to the start bound only)

#### Time zone in main panel


elastic@fc69e8b

- display the time zone in the main panel's footer
- does not handle `Browser` as a value, this will be fixed separately
- no tests for now

##### QA suggestion
* [x] verify the time zone is displayed as expected (if no valid iana
name passed, it shouldn't show)

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
jeramysoucy pushed a commit to jeramysoucy/kibana that referenced this pull request Mar 26, 2026
## Summary

> [!IMPORTANT]
> the `DateRangePicker` component this is touching will be in Technical
Preview

This PR adds the missing parts to make `DateRangePicker`
feature-complete to start a QA process.

Resolves elastic/eui-private#515 🔒 
Resolves elastic/eui-private#516 🔒 
Resolves elastic/eui-private#517 🔒 
Resolves elastic/eui-private#519 🔒 

Changes outlines right below.

### Changes

#### Parser small improvements


elastic@838c6c3

- make the input more forgiving with absolute dates (see
[eui/elastic#9199](elastic/eui#9199))
- use a dash as default delimiter e.g. `feb 1 - feb 3`, also supporting
others e.g. `to` or `until`
- support shorthand-specific unit forms while still being handling date
math as before e.g. `-6M` and `-6mos` are the same
- a bit better test coverage
- matches presets _before_ parsing, as expected
- add an option to round relative times (wired up with settings)
elastic@45618ea

##### QA suggestion
* [x] verify input is forgiving with absolute dates in RFC 2822-ish
* [x] verify dash works as a delimiter, also `to` and `until`
* [x] verify shorthand units for minutes and months works in strict
dateMath and our custom syntax `min` -> `m`, `mos` -> `M`
* [x] presets are matched correctly, both by typing and selecting from
the list

#### Documentation panel


elastic@0b3c5d5

- a button to navigate to it is visible when the input is cleared
- contents are not final

##### QA suggestion
* [x] verify the button shows when the input clears and navigates
correctly

#### Settings panel and `settings` / `onSettingsChange` props 


elastic@13ad343

- can be opened via the gear icon button on the footer
- features only one setting, "Round relative time ranges" →
`roundRelativeTime`
- introduces mandatory `settings` and `onSettingsChange` props

##### QA suggestion
* [x] verify toggling "Round relative time ranges" works as expected
(rounding is applied when "on", to the start bound only)

#### Time zone in main panel


elastic@fc69e8b

- display the time zone in the main panel's footer
- does not handle `Browser` as a value, this will be fixed separately
- no tests for now

##### QA suggestion
* [x] verify the time zone is displayed as expected (if no valid iana
name passed, it shouldn't show)

### Checklist

Check the PR satisfies following conditions. 

Reviewers should verify this PR satisfies this list as well.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
- [ ] Review the [backport
guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing)
and apply applicable `backport:*` labels.

### Identify risks

Does this PR introduce any risks? For example, consider risks like hard
to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified
risk. Invite stakeholders and evaluate how to proceed before merging.

- [ ] [See some risk
examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx)
- [ ] ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants