[Fleet] Silently swallow 404 errors when deleting ingest pipelines#91778
Merged
jen-huang merged 4 commits intoelastic:masterfrom Feb 18, 2021
Merged
[Fleet] Silently swallow 404 errors when deleting ingest pipelines#91778jen-huang merged 4 commits intoelastic:masterfrom
jen-huang merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
3 tasks
jfsiii
approved these changes
Feb 18, 2021
x-pack/plugins/fleet/server/services/epm/elasticsearch/ingest_pipeline/remove.ts
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: cc @jen-huang |
jen-huang
added a commit
to jen-huang/kibana
that referenced
this pull request
Feb 18, 2021
…lastic#91778) * Only show transform logs when there are transforms * Silently swallow 404 errors when deleting ingest pipelines * Change to IngestManagerError
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 19, 2021
* master: (111 commits) [Logs UI] Replace dependencies in the infra bundle (elastic#91503) [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921) [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918) Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657) [Fleet] Don't error on missing package_assets value (elastic#91744) [Lens] Pass used histogram interval to chart (elastic#91370) [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839) [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947) [CI] backportrc can skip CI (elastic#91886) Revert "[SOM] fix flaky suites (elastic#91809)" [Fleet] Install Elastic Agent integration by default during setup (elastic#91676) [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778) [data.search] Use incrementCounter for search telemetry (elastic#91230) [Fleet] Bootstrap functional test suite (elastic#91898) [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067) Use correct environment in anomaly detection setup link (elastic#91877) [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770) [CI] Build and publish storybooks (elastic#87701) docs: add PHP agent info to docs (elastic#91773) [DOCS] Adds and updates Visualization advanced settings (elastic#91904) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves #91192 by silently swallowing 404 errors that get thrown when deleting ingest pipelines. For explanation of why this happens and why they are safe to ignore, see: #91192 (comment)
I also took the liberty of removing some redundant logs around transforms that always show up on Fleet setup, even when there are no transforms found.
If you'd like to test this PR, start with fresh ES data and install an older system package before navigating to Fleet (triggering setup) via:
Then navigate to Fleet to trigger setup, which will trigger upgrade of the system package. Without this PR, you will see
error deleting pipelineerrors in Kibana logs. With this PR, you should no longer see them.