[FTSR] Convert to tasks and add jest/api integration suites#91770
Merged
brianseeders merged 1 commit intoelastic:masterfrom Feb 18, 2021
Merged
[FTSR] Convert to tasks and add jest/api integration suites#91770brianseeders merged 1 commit intoelastic:masterfrom
brianseeders merged 1 commit intoelastic:masterfrom
Conversation
fd27525 to
5ae9ff5
Compare
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
Comment on lines
+76
to
+80
| if (!config.isXpack) { | ||
| kibanaPipeline.buildOss() | ||
| } else { | ||
| kibanaPipeline.buildXpack() | ||
| } |
Member
There was a problem hiding this comment.
nit: not with an else is a little harder to follow.
tylersmalley
approved these changes
Feb 18, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 18, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 18, 2021
Contributor
brianseeders
added a commit
to brianseeders/kibana
that referenced
this pull request
Feb 18, 2021
…91770) # Conflicts: # .ci/Jenkinsfile_flaky
kibanamachine
added a commit
that referenced
this pull request
Feb 18, 2021
kibanamachine
added a commit
that referenced
this pull request
Feb 18, 2021
brianseeders
added a commit
that referenced
this pull request
Feb 18, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 19, 2021
* master: (111 commits) [Logs UI] Replace dependencies in the infra bundle (elastic#91503) [Search Source] Do not request unmapped fields if source filters are provided (elastic#91921) [APM] Kql Search Bar suggests values outside the selected time range (elastic#91918) Refactored component edit policy tests into separate folders and using client integration testing setup (elastic#91657) [Fleet] Don't error on missing package_assets value (elastic#91744) [Lens] Pass used histogram interval to chart (elastic#91370) [Indexpattern management] Use indexPatterns Service instead of savedObjects client (elastic#91839) [Security Solutions] Fixes Cypress tests for indicator match by making the selectors more specific (elastic#91947) [CI] backportrc can skip CI (elastic#91886) Revert "[SOM] fix flaky suites (elastic#91809)" [Fleet] Install Elastic Agent integration by default during setup (elastic#91676) [Fleet] Silently swallow 404 errors when deleting ingest pipelines (elastic#91778) [data.search] Use incrementCounter for search telemetry (elastic#91230) [Fleet] Bootstrap functional test suite (elastic#91898) [Alerts][Docs] Added API documentation for alerts plugin (elastic#91067) Use correct environment in anomaly detection setup link (elastic#91877) [FTSR] Convert to tasks and add jest/api integration suites (elastic#91770) [CI] Build and publish storybooks (elastic#87701) docs: add PHP agent info to docs (elastic#91773) [DOCS] Adds and updates Visualization advanced settings (elastic#91904) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally set out to add the integration test suites to the FTSR. Some of the integration tests require a unique workspace because they write to files in the kibana directory, so I converted FTSR to use the
tasksframework, since that provides unique workspaces for parallel tasks.Some example runs:
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1315/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1316/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1313/
https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1314/
The integration suites will require changes to the Jenkins job definition in a separate repo.