[APM] Fix optimize-tsconfig script#91487
Merged
dgieselaar merged 1 commit intoelastic:masterfrom Feb 17, 2021
Merged
Conversation
- Removes x-pack/plugins/apm/tsconfig.json file - Make optimisation opt-in for precommit script
Contributor
|
Pinging @elastic/apm-ui (Team:apm) |
Contributor
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
smith
approved these changes
Feb 16, 2021
Contributor
smith
left a comment
There was a problem hiding this comment.
Looks good, though I'm not using this script.
I wonder if how workspaces are set up makes any difference for VSCode performance. I have a workspace with apm, observability, and kibana as roots so I wonder if that has any bearing on how TS projects get built.
Contributor
Author
|
@smith I have the same setup (stole it from you). Maybe we can chat about it later how it works for you. |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 17, 2021
- Removes x-pack/plugins/apm/tsconfig.json file - Make optimisation opt-in for precommit script
Contributor
kibanamachine
added a commit
that referenced
this pull request
Feb 17, 2021
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 17, 2021
* master: (157 commits) [DOCS] Adds machine learning to the security section of alerting (elastic#91501) [Uptime] Ping list step screenshot caption formatting (elastic#91403) [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483) [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464) Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194) [APM] Wrap Elasticsearch client errors (elastic#91125) [APM] Fix optimize-tsconfig script (elastic#91487) [Discover][docs] Add searchFieldsFromSource description (elastic#90980) Adds support for 'ip' data type (elastic#85087) [Detection Rules] Add updates from 7.11.2 rules (elastic#91553) [SECURITY SOLUTION] Eql in timeline (elastic#90816) [APM] Correlations Beta (elastic#86477) (elastic#89952) [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258) [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446) skip flaky suite (elastic#91450) skip flaky suite (elastic#91592) [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870) [ML] Add better UI support for runtime fields Transforms (elastic#90363) [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167) [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that A) the optimised version is still faster when giving autocompletion results (~2x as fast), B) having a per-plugin tsconfig file causes vscode to switch between projects which takes a lot of time. I might be holding it wrong, but I think it's worth it to make some changes in the script to make it work again.