Skip to content

[Discover][docs] Add searchFieldsFromSource description#90980

Merged
kertal merged 3 commits intoelastic:masterfrom
kertal:kertal-pr-2021-02-10-discover-add-search-from-source-doc
Feb 17, 2021
Merged

[Discover][docs] Add searchFieldsFromSource description#90980
kertal merged 3 commits intoelastic:masterfrom
kertal:kertal-pr-2021-02-10-discover-add-search-from-source-doc

Conversation

@kertal
Copy link
Copy Markdown
Member

@kertal kertal commented Feb 10, 2021

Summary

Add documentation for the searchFieldsFromSource flag of Discover

Checklist

  • Documentation was added for features that require explanation or tutorials

@kertal kertal added the Feature:Discover Discover Application label Feb 10, 2021
@kertal kertal self-assigned this Feb 10, 2021
@kertal kertal requested review from gchaps and majagrubic February 10, 2021 17:08
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
@kertal kertal marked this pull request as ready for review February 11, 2021 05:11
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.12.0 Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Feb 11, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

[[discover-searchFieldsFromSource]]`discover:searchFieldsFromSource`::
When enabled, documents will be loaded and displayed using `_source`. This is soon going to be deprecated.
When disabled, the new `fields` parameter of Elasticsearch search service is being used. This way runtime, alias and
multi fields can be displayed.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@majagrubic Mind if we align this documentation text with the one in our UI?

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@gchaps gchaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kertal!

@kertal kertal merged commit 673b0e9 into elastic:master Feb 17, 2021
kertal added a commit to kertal/kibana that referenced this pull request Feb 17, 2021
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
kertal added a commit that referenced this pull request Feb 17, 2021
)

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
Co-authored-by: gchaps <33642766+gchaps@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 17, 2021
* master: (157 commits)
  [DOCS] Adds machine learning to the security section of alerting (elastic#91501)
  [Uptime] Ping list step screenshot caption formatting (elastic#91403)
  [Vislib] Use timestamp on brush event instead of iso dates (elastic#91483)
  [Application Usage] Remove deprecated & unused legacy.appChanged API (elastic#91464)
  Migrate logstash, monitoring, url_drilldowns, xpack_legacy to ts projects (elastic#91194)
  [APM] Wrap Elasticsearch client errors (elastic#91125)
  [APM] Fix optimize-tsconfig script (elastic#91487)
  [Discover][docs] Add searchFieldsFromSource description (elastic#90980)
  Adds support for 'ip' data type (elastic#85087)
  [Detection Rules] Add updates from 7.11.2 rules (elastic#91553)
  [SECURITY SOLUTION] Eql in timeline (elastic#90816)
  [APM] Correlations Beta (elastic#86477) (elastic#89952)
  [Security Solutions][Detection Engine] Adds a warning banner when the alerts data has not been migrated yet. (elastic#90258)
  [Security Solution] [Timeline] Endpoint row renderers (2nd batch) (elastic#91446)
  skip flaky suite (elastic#91450)
  skip flaky suite (elastic#91592)
  [Security Solution][Endpoint][Admin] Endpoint Details UX Enhancements (elastic#90870)
  [ML] Add better UI support for runtime fields Transforms  (elastic#90363)
  [Security Solution] [Detections] Replace 'partial failure' with 'warning' for rule statuses (elastic#91167)
  [Security Solution][Detections] Adds Indicator path config for indicator match rules (elastic#91260)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Discover Discover Application release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.12.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants