[ML] Edit hyperparameter descriptions in job wizard#91072
Merged
lcawl merged 8 commits intoelastic:masterfrom Feb 12, 2021
Merged
[ML] Edit hyperparameter descriptions in job wizard#91072lcawl merged 8 commits intoelastic:masterfrom
lcawl merged 8 commits intoelastic:masterfrom
Conversation
tveasey
approved these changes
Feb 11, 2021
Contributor
tveasey
left a comment
There was a problem hiding this comment.
Couple of small suggestions but basically LGTM
.../data_frame_analytics/pages/analytics_creation/components/advanced_step/hyper_parameters.tsx
Outdated
Show resolved
Hide resolved
.../data_frame_analytics/pages/analytics_creation/components/advanced_step/hyper_parameters.tsx
Outdated
Show resolved
Hide resolved
.../data_frame_analytics/pages/analytics_creation/components/advanced_step/hyper_parameters.tsx
Outdated
Show resolved
Hide resolved
…s/analytics_creation/components/advanced_step/hyper_parameters.tsx Co-authored-by: Tom Veasey <tveasey@users.noreply.github.com>
…s/analytics_creation/components/advanced_step/hyper_parameters.tsx Co-authored-by: Tom Veasey <tveasey@users.noreply.github.com>
…s/analytics_creation/components/advanced_step/hyper_parameters.tsx Co-authored-by: Tom Veasey <tveasey@users.noreply.github.com>
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Member
Author
|
@elasticmachine merge upstream |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Feb 12, 2021
Co-authored-by: Tom Veasey <tveasey@users.noreply.github.com>
lcawl
added a commit
that referenced
this pull request
Feb 12, 2021
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related to #90843 and #90738
Screenshots
Before:
After:
