Skip to content

[ML] Data Frame Analytics creation wizard: adds support for extended hyper-parameters#90843

Merged
alvarezmelissa87 merged 2 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfa-adds-hyperparams
Feb 10, 2021
Merged

[ML] Data Frame Analytics creation wizard: adds support for extended hyper-parameters#90843
alvarezmelissa87 merged 2 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfa-adds-hyperparams

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Feb 9, 2021 •
edited
Loading

Summary

Related issue: #90738

Adds UI support for the following parameters for regression/classification

  • alpha
  • downsample_factor
  • eta_growth_rate_per_tree
  • max_optimization_rounds_per_hyperparameter
  • soft_tree_depth_limit
  • soft_tree_depth_tolerance

Hyperparameters added to Hyperparameters section in wizard with validation:

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 self-assigned this Feb 9, 2021
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner February 9, 2021 20:14
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 9, 2021

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87
Copy link
Copy Markdown
Contributor Author

alvarezmelissa87 commented Feb 9, 2021

@lcawl - would you be up for taking a look at the help text? Would love your opinion 🙏

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 9, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 6.3MB 6.3MB +11.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 58.0KB 59.1KB +1.1KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson approved these changes Feb 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question, but otherwise tested and LGTM.

.../data_frame_analytics/pages/analytics_creation/components/advanced_step/hyper_parameters.tsx
})
}
step={0.001}
min={0.5}
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm - we don't currently aim to validate any of the hyperparameter values inside the JSON editor do we?

image

Copy link
Copy Markdown
Contributor Author

@alvarezmelissa87 alvarezmelissa87 Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the 'explain' api to validate these parameters and display any messages returned from that api regarding the particular hyperparameter. There is input validation for value type (e.g. numbers) and min/max, as well.

walterra
walterra approved these changes Feb 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87
Copy link
Copy Markdown
Contributor Author

alvarezmelissa87 commented Feb 10, 2021

Merging this and applying any necessary helptext changes that might come up (courtesy of @lcawl 🙏 ) in a follow up.

@alvarezmelissa87 alvarezmelissa87 merged commit 2a93ebe into elastic:master Feb 10, 2021
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 10, 2021
Merged
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfa-adds-hyperparams branch February 10, 2021 15:57
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Feb 10, 2021
Closed
alvarezmelissa87 added a commit that referenced this pull request Feb 10, 2021
@alvarezmelissa87
[ML] Data Frame Analytics creation wizard: adds support for extended …
3e3f64f 
…hyper-parameters (#90843) (#90969)

* add support for new hyperparameters in the creation wizard

* fix translation error
@lcawl lcawl mentioned this pull request Feb 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@lcawl lcawl Awaiting requested review from lcawl

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels

Feature:Data Frame Analytics ML data frame analytics features :ml release_note:enhancement v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alvarezmelissa87 @elasticmachine @kibanamachine @walterra @peteharverson