Skip to content

[ts/build_ts_refs] add support for --clean flag#91060

Merged
spalger merged 1 commit intoelastic:masterfrom
spalger:implement/clean-ts-refs
Feb 11, 2021
Merged

[ts/build_ts_refs] add support for --clean flag#91060
spalger merged 1 commit intoelastic:masterfrom
spalger:implement/clean-ts-refs

Conversation

@spalger
Copy link
Copy Markdown
Contributor

@spalger spalger commented Feb 10, 2021

Does a tiny bit of refactoring in the dev/typescript directory to implement a --clean flag for node scripts/build_ts_refs which clears out the outDir for each TS project referenced from the root tsconfig.refs.json file.

@spalger spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.12.0 labels Feb 10, 2021
@spalger spalger requested a review from mshustov February 10, 2021 23:10
@spalger spalger requested a review from a team as a code owner February 10, 2021 23:10
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 10, 2021

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger mentioned this pull request Feb 10, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 11, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

mistic
mistic approved these changes Feb 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@mistic mistic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spalger spalger merged commit c0a974a into elastic:master Feb 11, 2021
@spalger spalger deleted the implement/clean-ts-refs branch February 11, 2021 05:38
@spalger spalger added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 11, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2021
@spalger @kibanamachine
[ts/build_ts_refs] add support for --clean flag (elastic#91060)
87bba9f 
Co-authored-by: spalger <spalger@users.noreply.github.com>
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 11, 2021

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:Operations","auto-backport","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"c0a974aa0e048af7c5829172c41aa32d860961c4\",\"formattedMessage\":\"[ts/build_ts_refs] add support for --clean flag (#91060)\",\"originalMessage\":\"[ts/build_ts_refs] add support for --clean flag (#91060)\\n\\nCo-authored-by: spalger <spalger@users.noreply.github.com>\",\"pullNumber\":91060,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] [ts/build_ts_refs] add support for --clean flag (#91060)\". kibanamachine:backport/7.x/pr-91060 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1227ms"}
{"level":"info","message":"Adding assignees to #91078: spalger"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91078/assignees - 201 in 481ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91078/labels - 200 in 330ms"}
View pull request: https://github.com/elastic/kibana/pull/91078

spalger added a commit that referenced this pull request Feb 11, 2021
@kibanamachine @spalger
[ts/build_ts_refs] add support for --clean flag (#91060) (#91078)
a7e0755 
Co-authored-by: spalger <spalger@users.noreply.github.com>

Co-authored-by: Spencer <email@spalger.com>
Co-authored-by: spalger <spalger@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 11, 2021
@gmmorris
Merge branch 'master' into task-manager/support-limited-concurrency
1713500 
* master: (44 commits)
  [APM] Add experimental support for Data Streams (elastic#89650)
  [Search Session] Control "Kibana / Search Sessions" management section by privileges (elastic#90818)
  [Lens] Median as default function (elastic#90952)
  Implement custom global header banner (elastic#87438)
  [Fleet] Reduce permissions. (elastic#90302)
  Update dependency @elastic/charts to v24.5.1 (elastic#89822)
  [Create index pattern] Can't create single character index without wildcard (elastic#90919)
  [ts/build_ts_refs] add support for --clean flag (elastic#91060)
  Don't clean when running e2e tests (elastic#91057)
  Fixes track_total_hits in the body not having an effect when using search strategy (elastic#91068)
  [Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege (elastic#90895)
  Removing the code plugin entirely for 8.0 (elastic#77940)
  chore(NA): move the instruction to remove yarn global bazelisk package into the first place on install bazel tools (elastic#91026)
  [jest/ci] remove max-old-space-size override to use 4gb default (elastic#91020)
  [Fleet] Restrict integration changes for managed policies (elastic#90675)
  [CI] Fix auto-backport condditions so that it doesn't trigger for other labels (elastic#91042)
  [DOCS] Uses variable to refer to query profiler (elastic#90976)
  [App Search] Relevance Tuning logic listeners (elastic#89461)
  [Metrics UI] Fix saving/loading saved views from URL (elastic#90216)
  Limit cardinality of transaction.name (elastic#90955)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mistic mistic mistic approved these changes

@mshustov mshustov Awaiting requested review from mshustov

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@spalger @elasticmachine @kibanamachine @mistic