Skip to content

Don't clean when running e2e tests#91057

Merged
smith merged 2 commits intoelastic:masterfrom
smith:nls/e2e-fix
Feb 11, 2021
Merged

Don't clean when running e2e tests#91057
smith merged 2 commits intoelastic:masterfrom
smith:nls/e2e-fix

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Feb 10, 2021 •
edited
Loading

I don't think this is necessary, and since it's run before bootstrap, the Bazel tools aren't installed so it fails silently.

Example: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-ui%2Fapm-ui-e2e-tests-mbp%2FPR-89647/detail/PR-89647/21/pipeline/124/

Should fix APM E2E failures.

@smith
Don't clean when running e2e tests
ca41250 
I don't think this is necessary, and since it's run before `bootstrap`, the Bazel tools aren't installed so it fails silently.

Example: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-ui%2Fapm-ui-e2e-tests-mbp%2FPR-89647/detail/PR-89647/21/pipeline/124/

`exec` the `nohup` script so preceding commands will fail instead of proceeding silently.

Should fix APM E2E failures.
@smith smith requested a review from a team February 10, 2021 22:41
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Feb 10, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 10, 2021

Pinging @elastic/apm-ui (Team:apm)

@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.12.0 v8.0.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Feb 10, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 11, 2021

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit d9abaa1 into elastic:master Feb 11, 2021
@smith smith deleted the nls/e2e-fix branch February 11, 2021 05:34
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 11, 2021
@smith @kibanamachine
Don't clean when running e2e tests (elastic#91057)
717fa7e 
I don't think this is necessary, and since it's run before `bootstrap`, the Bazel tools aren't installed so it fails silently.

Example: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-ui%2Fapm-ui-e2e-tests-mbp%2FPR-89647/detail/PR-89647/21/pipeline/124/

Should fix APM E2E failures.
@kibanamachine kibanamachine mentioned this pull request Feb 11, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 11, 2021

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:apm","auto-backport","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"d9abaa180b15ef72f18a9ad03a4395c0a9601873\",\"formattedMessage\":\"Don't clean when running e2e tests (#91057)\",\"originalMessage\":\"Don't clean when running e2e tests (#91057)\\n\\nI don't think this is necessary, and since it's run before `bootstrap`, the Bazel tools aren't installed so it fails silently.\\r\\n\\r\\nExample: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-ui%2Fapm-ui-e2e-tests-mbp%2FPR-89647/detail/PR-89647/21/pipeline/124/\\r\\n\\r\\nShould fix APM E2E failures.\",\"pullNumber\":91057,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"level":"info","message":"Creating PR with title: \"[7.x] Don't clean when running e2e tests (#91057)\". kibanamachine:backport/7.x/pr-91057 -> 7.x"}
{"level":"info","message":"POST /repos/elastic/kibana/pulls - 201 in 1206ms"}
{"level":"info","message":"Adding assignees to #91077: smith"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91077/assignees - 201 in 500ms"}
{"level":"info","message":"Adding labels: backport"}
{"level":"info","message":"POST /repos/elastic/kibana/issues/91077/labels - 200 in 330ms"}
View pull request: https://github.com/elastic/kibana/pull/91077

gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 11, 2021
@gmmorris
Merge branch 'master' into task-manager/support-limited-concurrency
1713500 
* master: (44 commits)
  [APM] Add experimental support for Data Streams (elastic#89650)
  [Search Session] Control "Kibana / Search Sessions" management section by privileges (elastic#90818)
  [Lens] Median as default function (elastic#90952)
  Implement custom global header banner (elastic#87438)
  [Fleet] Reduce permissions. (elastic#90302)
  Update dependency @elastic/charts to v24.5.1 (elastic#89822)
  [Create index pattern] Can't create single character index without wildcard (elastic#90919)
  [ts/build_ts_refs] add support for --clean flag (elastic#91060)
  Don't clean when running e2e tests (elastic#91057)
  Fixes track_total_hits in the body not having an effect when using search strategy (elastic#91068)
  [Security Solution][Detections] Adds list plugin Saved Objects to Security feature privilege (elastic#90895)
  Removing the code plugin entirely for 8.0 (elastic#77940)
  chore(NA): move the instruction to remove yarn global bazelisk package into the first place on install bazel tools (elastic#91026)
  [jest/ci] remove max-old-space-size override to use 4gb default (elastic#91020)
  [Fleet] Restrict integration changes for managed policies (elastic#90675)
  [CI] Fix auto-backport condditions so that it doesn't trigger for other labels (elastic#91042)
  [DOCS] Uses variable to refer to query profiler (elastic#90976)
  [App Search] Relevance Tuning logic listeners (elastic#89461)
  [Metrics UI] Fix saving/loading saved views from URL (elastic#90216)
  Limit cardinality of transaction.name (elastic#90955)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Feb 15, 2021

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Feb 15, 2021
dgieselaar pushed a commit that referenced this pull request Feb 15, 2021
@kibanamachine @smith
Don't clean when running e2e tests (#91057) (#91077)
656d844 
I don't think this is necessary, and since it's run before `bootstrap`, the Bazel tools aren't installed so it fails silently.

Example: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-ui%2Fapm-ui-e2e-tests-mbp%2FPR-89647/detail/PR-89647/21/pipeline/124/

Should fix APM E2E failures.

Co-authored-by: Nathan L Smith <nathan.smith@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.12.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smith @elasticmachine @kibanamachine @sorenlouv