Strongly typed EUI theme for styled-components#90106
Strongly typed EUI theme for styled-components#90106sorenlouv merged 4 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/apm-ui (Team:apm) |
|
retest |
|
Anyone know why I get this a typescript error after importing the eui dark theme in the declaration file for eui? |
|
Do we need this if we import https://github.com/elastic/kibana/blob/master/src/plugins/kibana_react/common/index.ts#L9 |
Oh! Didn't know about that. I'll try that instead. |
|
Pinging @elastic/uptime (Team:uptime) |
|
retest |
|
@elasticmachine merge upstream |
use euiStyled fix tsc issue
1997ea3 to
495a4cb
Compare
|
retest |
|
@elasticmachine merge upstream |
.../transaction_details/WaterfallWithSummmary/WaterfallContainer/Waterfall/SpanFlyout/index.tsx
Outdated
Show resolved
Hide resolved
...nts/app/transaction_details/WaterfallWithSummmary/WaterfallContainer/Waterfall/SyncBadge.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/Summary/ErrorCountSummaryItemBadge.tsx
Outdated
Show resolved
Hide resolved
cauemarcondes
left a comment
There was a problem hiding this comment.
LGTM, just a small comment.
|
retest |
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / X-Pack Accessibility Tests.x-pack/test/accessibility/apps/uptime·ts.uptime overview alert popover controlsStandard OutStack TraceMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
…timeline-and-rollover-info * 'master' of github.com:elastic/kibana: (47 commits) [Fleet] Use TS project references (elastic#87574) before/beforeEach clean up (elastic#90663) [Vega] user should be able to set a specific tilemap service using the mapStyle property (elastic#88440) [Security Solution][Case] ServiceNow SIR Connector (elastic#88655) [Search Sessions] Enable extend from management (elastic#90558) [ILM] Delete phase redesign (rework) (elastic#90291) [APM-UI][E2E] use withGithubStatus step (elastic#90651) Add folding in kb-monaco and update some viewers (elastic#90152) [Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness (elastic#90543) Strongly typed EUI theme for styled-components (elastic#90106) Fix vega renovate label (elastic#90591) [Uptime] Migrate to TypeScript project references (elastic#90510) [Monitoring] Migrate data source for legacy alerts to monitoring data directly (elastic#87377) [Upgrade Assistant] Add A11y Tests (elastic#90265) [Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (elastic#89612) [dev-utils/ship-ci-stats] fail when CI stats is down (elastic#90678) chore(NA): remove write permissions on Bazel remote cache for PRs (elastic#90652) chore(NA): move bazel workspace status from bash script into nodejs executable (elastic#90560) Use default ES distribution for functional tests (elastic#88737) [Alerts] Jira: Disallow labels with spaces (elastic#90548) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts
* Strongly typed EUI theme for styled-components use euiStyled fix tsc issue * use relative imports * remove redundant types Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
|
Backport result |

Use typed
euiStyledwhen using styled-components.typescript-styled.mp4