Use default ES distribution for functional tests by tylersmalley · Pull Request #88737 · elastic/kibana

tylersmalley · 2021-01-19T19:18:05Z

Use the default Elasticsearch distribution across all functional and integration tests within Kibana.

elasticmachine · 2021-01-21T05:03:00Z

Pinging @elastic/kibana-operations (Team:Operations)

test/api_integration/config.js

test/common/services/deployment.ts

test/functional/apps/management/_scripted_fields.js

spalger

LGTM, but I would feel more comfortable if we got to the bottom of that lens assertion change.

flash1293 · 2021-01-21T09:31:27Z

@tylersmalley Seems like this PR will still run the tests in test/functional against a Kibana instance with only the plugin in src loaded while all x-pack plugins are not active. The isOss() check you removed in the scripted field test is about testing Lens, but Lens is not available for this test so visualize is opened instead. I guess for now we can just take the visualize branch (the one checking against inspector) and deleting the Lens branch.

Maybe I misunderstood something, but going forward I would expect all tests to run with all of the x-pack stuff present right (like a regular "basic" default distribution behaves as well)?

mshustov

ok for the Core changes

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

spalger · 2021-02-08T20:15:49Z

@elasticmachine merge upstream

kibanamachine · 2021-02-08T22:22:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 00e5a44

Metrics [docs]

✅ unchanged

History

💚 Build #104472 succeeded 55b9586
💚 Build #100226 succeeded 4d84523d39485fd7f58d8d73c94550019af4a7c0
💔 Build #100194 failed 809b1f2b3afedb95c0ba5a29e7f6f1c58e4a0cc5
💔 Build #100190 failed a6601c8ceee30bb74233e1d44c129f4ccd8c8423
💔 Build #100048 failed 96f35819576271ddb1a081b9d585b56ea1036477

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kibanamachine · 2021-02-08T22:25:44Z

Backport result

{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"level":"info","message":"POST https://api.github.com/graphql (status: 200)"}
{"meta":{"labels":["Team:Operations","auto-backport","release_note:skip","v7.12.0","v8.0.0"],"branchLabelMapping":{"^v8.0.0$":"master","^v7.12.0$":"7.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"},"existingTargetPullRequests":[]},"level":"info","message":"Inputs when calculating target branches:"}
{"meta":["7.x"],"level":"info","message":"Target branches inferred from labels:"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm kibanamachine","stdout":"","stderr":"error: No such remote: 'kibanamachine'\n"},"level":"info","message":"exec error 'git remote rm kibanamachine':"}
{"meta":{"killed":false,"code":2,"signal":null,"cmd":"git remote rm elastic","stdout":"","stderr":"error: No such remote: 'elastic'\n"},"level":"info","message":"exec error 'git remote rm elastic':"}
{"level":"info","message":"Backporting [{\"sourceBranch\":\"master\",\"targetBranchesFromLabels\":[\"7.x\"],\"sha\":\"b39ad86b5d59fef96366affbdfbcc6758545cba9\",\"formattedMessage\":\"Use default ES distribution for functional tests (#88737)\",\"originalMessage\":\"Use default ES distribution for functional tests (#88737)\\n\\nSigned-off-by: Tyler Smalley <tyler.smalley@elastic.co>\\r\\n\\r\\nCo-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>\",\"pullNumber\":88737,\"existingTargetPullRequests\":[]}] to 7.x"}

Backporting to 7.x:
{"level":"info","message":"Backporting via filesystem"}
{"meta":{"killed":false,"code":1,"signal":null,"cmd":"git cherry-pick b39ad86b5d59fef96366affbdfbcc6758545cba9","stdout":"Auto-merging test/functional/config.js\nAuto-merging test/common/config.js\nAuto-merging src/core/test_helpers/kbn_server.ts\nAuto-merging src/core/server/saved_objects/migrationsv2/integration_tests/migration.test.ts\nAuto-merging packages/kbn-test/src/legacy_es/legacy_es_test_cluster.js\nCONFLICT (modify/delete): .ci/packer_cache_for_branch.sh deleted in HEAD and modified in b39ad86b5d5 (Use default ES distribution for functional tests (#88737)). Version b39ad86b5d5 (Use default ES distribution for functional tests (#88737)) of .ci/packer_cache_for_branch.sh left in tree.\n","stderr":"error: could not apply b39ad86b5d5... Use default ES distribution for functional tests (#88737)\nhint: after resolving the conflicts, mark the corrected paths\nhint: with 'git add <paths>' or 'git rm <paths>'\nhint: and commit the result with 'git commit'\n"},"level":"info","message":"exec error 'git cherry-pick b39ad86b5d59fef96366affbdfbcc6758545cba9':"}
Commit could not be cherrypicked due to conflicts

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # .ci/packer_cache_for_branch.sh

…timeline-and-rollover-info * 'master' of github.com:elastic/kibana: (47 commits) [Fleet] Use TS project references (elastic#87574) before/beforeEach clean up (elastic#90663) [Vega] user should be able to set a specific tilemap service using the mapStyle property (elastic#88440) [Security Solution][Case] ServiceNow SIR Connector (elastic#88655) [Search Sessions] Enable extend from management (elastic#90558) [ILM] Delete phase redesign (rework) (elastic#90291) [APM-UI][E2E] use withGithubStatus step (elastic#90651) Add folding in kb-monaco and update some viewers (elastic#90152) [Grok Debugger] Changed test to wait for grok debugger container to exist to fix test flakiness (elastic#90543) Strongly typed EUI theme for styled-components (elastic#90106) Fix vega renovate label (elastic#90591) [Uptime] Migrate to TypeScript project references (elastic#90510) [Monitoring] Migrate data source for legacy alerts to monitoring data directly (elastic#87377) [Upgrade Assistant] Add A11y Tests (elastic#90265) [Time to Visualize] Adds functional tests for linking/unlinking panel from embeddable library (elastic#89612) [dev-utils/ship-ci-stats] fail when CI stats is down (elastic#90678) chore(NA): remove write permissions on Bazel remote cache for PRs (elastic#90652) chore(NA): move bazel workspace status from bash script into nodejs executable (elastic#90560) Use default ES distribution for functional tests (elastic#88737) [Alerts] Jira: Disallow labels with spaces (elastic#90548) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/timeline/timeline.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.test.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/lib/absolute_timing_to_relative_timing.ts

tylersmalley force-pushed the no-es-oss-builds branch 4 times, most recently from 76e0819 to 544de3d Compare January 19, 2021 20:59

tylersmalley changed the title ~~WIP~~ Removes usage of OSS Elasticsearch builds Jan 19, 2021

tylersmalley force-pushed the no-es-oss-builds branch 7 times, most recently from cbc8164 to 45c1941 Compare January 20, 2021 05:21

tylersmalley changed the title ~~Removes usage of OSS Elasticsearch builds~~ Use default ES distribution for functional tests Jan 20, 2021

tylersmalley force-pushed the no-es-oss-builds branch 7 times, most recently from 202d240 to 4d84523 Compare January 21, 2021 00:25

tylersmalley added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.12.0 v8.0.0 labels Jan 21, 2021

tylersmalley marked this pull request as ready for review January 21, 2021 05:02

tylersmalley requested review from a team as code owners January 21, 2021 05:02

spalger reviewed Jan 21, 2021

View reviewed changes

test/api_integration/config.js Outdated Show resolved Hide resolved

spalger reviewed Jan 21, 2021

View reviewed changes

test/common/services/deployment.ts Outdated Show resolved Hide resolved

tylersmalley commented Jan 21, 2021

View reviewed changes

test/functional/apps/management/_scripted_fields.js Outdated Show resolved Hide resolved

spalger approved these changes Jan 21, 2021

View reviewed changes

mshustov approved these changes Jan 21, 2021

View reviewed changes

Use default ES distribution for functional tests

55b9586

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>

tylersmalley force-pushed the no-es-oss-builds branch from 4d84523 to 55b9586 Compare February 6, 2021 00:16

jbudz approved these changes Feb 8, 2021

View reviewed changes

Merge branch 'master' into no-es-oss-builds

00e5a44

tylersmalley added the auto-backport Deprecated - use backport:version if exact versions are needed label Feb 8, 2021

tylersmalley merged commit b39ad86 into elastic:master Feb 8, 2021

tylersmalley mentioned this pull request Feb 8, 2021

[7.x] Use default ES distribution for functional tests (#88737) #90694

Merged

lukeelmers mentioned this pull request Feb 9, 2021

Support pit and search_after in server savedObjects.find #89915

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use default ES distribution for functional tests#88737

Use default ES distribution for functional tests#88737
tylersmalley merged 2 commits intoelastic:masterfrom
tylersmalley:no-es-oss-builds

tylersmalley commented Jan 19, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Jan 21, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spalger left a comment

Uh oh!

flash1293 commented Jan 21, 2021

Uh oh!

mshustov left a comment

Uh oh!

spalger commented Feb 8, 2021

Uh oh!

kibanamachine commented Feb 8, 2021

Uh oh!

kibanamachine commented Feb 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

tylersmalley commented Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jan 21, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Jan 21, 2021

Uh oh!

mshustov left a comment

Choose a reason for hiding this comment

Uh oh!

spalger commented Feb 8, 2021

Uh oh!

kibanamachine commented Feb 8, 2021

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kibanamachine commented Feb 8, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

tylersmalley commented Jan 19, 2021 •

edited

Loading