[Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 #89973
Merged
FrankHassanabad merged 4 commits intoelastic:masterfrom Feb 2, 2021
Merged
[Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 #89973FrankHassanabad merged 4 commits intoelastic:masterfrom
FrankHassanabad merged 4 commits intoelastic:masterfrom
Conversation
FrankHassanabad
commented
Feb 2, 2021
| .send() | ||
| .expect(200); | ||
| expect(body).to.eql({ | ||
| index_mapping_outdated: null, |
Contributor
Author
There was a problem hiding this comment.
NOTE: I think this index_mapping_outdated: null is returned intentionally for when the user does not have correct permissions to read if the index mapping exists or not. It exists here in a few other tests.
FrankHassanabad
commented
Feb 2, 2021
| detections_admin = 'detections_admin', | ||
| } | ||
|
|
||
| export type RolesType = keyof typeof ROLES; |
Contributor
Author
There was a problem hiding this comment.
NOTE: removed as I directly use the ROLES below now and this enables me to use an exhaustive switch.
FrankHassanabad
commented
Feb 2, 2021
|
|
||
| import * as t1AnalystUser from './detections_user.json'; | ||
| import * as t1AnalystRole from './detections_role.json'; | ||
| export { t1AnalystUser, t1AnalystRole }; |
Contributor
Author
There was a problem hiding this comment.
NOTE: I get that these are script folders, but the tests and imports cleaned up when I did the NodeJS index barrel rolls here.
FrankHassanabad
commented
Feb 2, 2021
| return postRoleAndUser(ROLES.reader, readerRole, readerUser, securityService); | ||
| default: | ||
| break; | ||
| return assertUnreachable(role); |
Contributor
Author
There was a problem hiding this comment.
NOTE: Using this and changing the enum above gives us exhaustive switches where when someone adds a new role type such as ROLES.reader (which was missing I noticed), they are forced to add it to this function as well.
dhurley14
approved these changes
Feb 2, 2021
Contributor
dhurley14
left a comment
There was a problem hiding this comment.
Thanks for the cleanup and the additional tests LGTM!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Feb 2, 2021
…lastic#89947 (elastic#89973) ## Summary Adds e2e and unit tests for PR: elastic#89947 * Adds e2e tests for create_index * Adds e2e tests for get_privileges * Adds unit test for use_privilege_user * Adds exhaustive switch for the roles in the e2e tests * Adds some typescript barrel rolls for the .json scripts to make TypeScript a bit more readable when doing imports * Fixes some of the types that were not matched up with the recent privilege endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
Feb 2, 2021
…lastic#89947 (elastic#89973) ## Summary Adds e2e and unit tests for PR: elastic#89947 * Adds e2e tests for create_index * Adds e2e tests for get_privileges * Adds unit test for use_privilege_user * Adds exhaustive switch for the roles in the e2e tests * Adds some typescript barrel rolls for the .json scripts to make TypeScript a bit more readable when doing imports * Fixes some of the types that were not matched up with the recent privilege endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
FrankHassanabad
added a commit
that referenced
this pull request
Feb 3, 2021
…for PR #89947 (#89973) (#90091) * [Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 (#89973) ## Summary Adds e2e and unit tests for PR: #89947 * Adds e2e tests for create_index * Adds e2e tests for get_privileges * Adds unit test for use_privilege_user * Adds exhaustive switch for the roles in the e2e tests * Adds some typescript barrel rolls for the .json scripts to make TypeScript a bit more readable when doing imports * Fixes some of the types that were not matched up with the recent privilege endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios * Fixes the backport for test to work correctly as the messages are different * Fixes one permission change issue between versions
FrankHassanabad
added a commit
that referenced
this pull request
Feb 3, 2021
… for PR #89947 (#89973) (#90092) * [Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 (#89973) ## Summary Adds e2e and unit tests for PR: #89947 * Adds e2e tests for create_index * Adds e2e tests for get_privileges * Adds unit test for use_privilege_user * Adds exhaustive switch for the roles in the e2e tests * Adds some typescript barrel rolls for the .json scripts to make TypeScript a bit more readable when doing imports * Fixes some of the types that were not matched up with the recent privilege endpoint ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios * Updated to work with the right messages * Fixes permissions that are slightly different
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds e2e and unit tests for PR:
#89947
Checklist