Skip to content

[7.11] [Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 (#89973)#90092

Merged
FrankHassanabad merged 3 commits intoelastic:7.11from
FrankHassanabad:backport/7.11/pr-89973
Feb 3, 2021
Merged

[7.11] [Security Solutions][Detection Engine] Adds e2e and unit tests for PR #89947 (#89973)#90092
FrankHassanabad merged 3 commits intoelastic:7.11from
FrankHassanabad:backport/7.11/pr-89973

Conversation

@FrankHassanabad
Copy link
Copy Markdown
Contributor

…lastic#89947  (elastic#89973)

## Summary

Adds e2e and unit tests for PR:
elastic#89947

* Adds e2e tests for create_index
* Adds e2e tests for get_privileges
* Adds unit test for use_privilege_user
* Adds exhaustive switch for the roles in the e2e tests
* Adds some typescript barrel rolls for the .json scripts to make TypeScript a bit more readable when doing imports 
* Fixes some of the types that were not matched up with the recent privilege endpoint

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@FrankHassanabad FrankHassanabad added the backport This PR is a backport of another PR label Feb 2, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.5MB 1.5MB -26.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 162.3KB 162.4KB +102.0B
Unknown metric groups

async chunk count

id before after diff
triggersActionsUi 31 32 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@FrankHassanabad FrankHassanabad merged commit 3643211 into elastic:7.11 Feb 3, 2021
@FrankHassanabad FrankHassanabad deleted the backport/7.11/pr-89973 branch February 3, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants