[Security Solution] Remove focustrap#89905
Merged
angorayc merged 3 commits intoelastic:masterfrom Feb 1, 2021
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
andrew-goldstein
approved these changes
Feb 1, 2021
Contributor
andrew-goldstein
left a comment
There was a problem hiding this comment.
Thanks for this fix @angorayc!
The EuiFocusTrap (removed in this PR) was used assuming no other inputs would be focused while editing the markdown, but that assumption didn't consider the case where users would, for example, filter the event details view by typing in its input while also editing the markdown.
- Tested locally
LGTM
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome UI Functional Tests.test/functional/apps/dashboard/panel_context_menu·ts.dashboard app using legacy data dashboard panel context menu on an expanded panel "before all" hook: and add one panel and save to put dashboard in "view" mode for "context menu actions are hidden in view mode"Standard OutStack TraceMetrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 1, 2021
* remove focustrap * remove focustrap Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Feb 1, 2021
* remove focustrap * remove focustrap Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
angorayc
added a commit
that referenced
this pull request
Feb 2, 2021
angorayc
added a commit
that referenced
this pull request
Feb 2, 2021
gmmorris
added a commit
to lizozom/kibana
that referenced
this pull request
Feb 2, 2021
…om/kibana into pr/89570 * 'sessions/save-all-sessions' of https://github.com/lizozom/kibana: (44 commits) [ML] Functional tests - skip DFA clone tests [Uptime] Fix synthetics detail step count (elastic#89940) Fixes the permissions to require cluster.manage in order to create an index and in order to update an index (elastic#89947) [Security Solution] [Detections] adds log info level for logging in cloud (elastic#89941) [Time to Visualize] Dashboard By Value Testing Lens (elastic#89581) [Uptime] Expand synthetic journey step thumbnail on hover (elastic#89179) TS project refs: Migrates snapshot_restore to a TS Project (elastic#89653) docs: APM 7.11 updates (elastic#89789) move skip to higher level (elastic#86952) Revert "Migrations v2: don't auto-create indices + FTR/esArchiver support (elastic#85778)" Revert "Revert "Enable v2 so migrations, disable in FTR tests (elastic#89297)"" Revert "Enable v2 so migrations, disable in FTR tests (elastic#89297)" [data.search] Allow search response to follow new hits format (elastic#88115) [Maps] Change 'create multi-layer map' title to be use-case focused (elastic#89520) skip flaky suite (elastic#86952) [Security Solution] Remove focustrap (elastic#89905) [Workplace Search] Add remaining i18n support for the Content Sources tree (elastic#89910) [esArchiver] log when migrations complete and we're done loading data (elastic#89938) Add --ssl flag to make resolver generator use ssl with kbn and elasticsearch clients (elastic#89873) TS project refs: Migrates grokdebugger (elastic#89652) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to fix #86918