Skip to content

[APM] Fixes alert creation items being available for readonly users#87343

Merged
ogupte merged 2 commits intoelastic:masterfrom
ogupte:apm-87026-fix-readonly-alert-saves
Jan 6, 2021
Merged

[APM] Fixes alert creation items being available for readonly users#87343
ogupte merged 2 commits intoelastic:masterfrom
ogupte:apm-87026-fix-readonly-alert-saves

Conversation

@ogupte
Copy link
Copy Markdown
Contributor

@ogupte ogupte commented Jan 5, 2021

Closes #87026 by ensuring the user also has save privileges for APM.

Menu items to create a new alert are now hidden for readonly APM users.

Screen Shot 2021-01-05 at 11 56 14 AM

@ogupte ogupte requested a review from a team January 5, 2021 16:57
@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jan 5, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 5, 2021

Pinging @elastic/apm-ui (Team:apm)

@ogupte ogupte added release_note:fix v7.11.0 v7.12.0 and removed Team:APM - DEPRECATED Use Team:obs-ux-infra_services. labels Jan 5, 2021
@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jan 5, 2021

jenkins run the e2e

@ogupte
Copy link
Copy Markdown
Contributor Author

ogupte commented Jan 5, 2021

@elasticmachine merge upstream

@botelastic botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Jan 5, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 5, 2021

💛 Build succeeded, but was flaky

Test Failures

Chrome X-Pack UI Plugin Functional Tests.x-pack/test/plugin_functional/test_suites/resolver.Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:00:00]         └-: Resolver test app
[00:00:00]           └-> "before all" hook
[00:00:00]           └-> "before all" hook
[00:00:00]             │ debg navigating to resolverTest url: http://localhost:6141/app/resolverTest
[00:00:00]             │ debg navigate to: http://localhost:6141/app/resolverTest
[00:00:00]             │ debg browser[INFO] http://localhost:6141/login?next=%2Fapp%2FresolverTest%3F_t%3D1609880952183 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:00]             │
[00:00:00]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:00]             │ debg ... sleep(700) start
[00:00:00]             │ debg ... sleep(700) end
[00:00:00]             │ debg returned from get, calling refresh
[00:00:01]             │ debg browser[INFO] http://localhost:6141/login?next=%2Fapp%2FresolverTest%3F_t%3D1609880952183 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:01]             │
[00:00:01]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:02]             │ debg currentUrl = http://localhost:6141/login?next=%2Fapp%2FresolverTest%3F_t%3D1609880952183
[00:00:02]             │          appUrl = http://localhost:6141/app/resolverTest
[00:00:02]             │ debg TestSubjects.find(kibanaChrome)
[00:00:02]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:02]             │ debg Found login page
[00:00:02]             │ debg TestSubjects.setValue(loginUsername, test_user)
[00:00:02]             │ debg TestSubjects.click(loginUsername)
[00:00:02]             │ debg Find.clickByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:02]             │ debg Find.findByCssSelector('[data-test-subj="loginUsername"]') with timeout=10000
[00:00:03]             │ debg TestSubjects.setValue(loginPassword, changeme)
[00:00:03]             │ debg TestSubjects.click(loginPassword)
[00:00:03]             │ debg Find.clickByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="loginPassword"]') with timeout=10000
[00:00:03]             │ debg TestSubjects.click(loginSubmit)
[00:00:03]             │ debg Find.clickByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="loginSubmit"]') with timeout=10000
[00:00:03]             │ debg Find.waitForDeletedByCssSelector('.kibanaWelcomeLogo') with timeout=10000
[00:00:03]             │ proc [kibana]   log   [21:09:15.591] [info][plugins][routes][security] Logging in with provider "basic" (basic)
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:00:03]             │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"] nav:not(.ng-hide)') with timeout=60000
[00:00:06]             │ debg browser[INFO] http://localhost:6141/app/resolverTest?_t=1609880952183 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:06]             │
[00:00:06]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:07]             │ debg browser[INFO] http://localhost:6141/app/resolverTest?_t=1609880958959 341 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:00:07]             │
[00:00:07]             │ debg browser[INFO] http://localhost:6141/bootstrap.js 42:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:00:07]             │ debg Finished login process currentUrl = http://localhost:6141/app/resolverTest
[00:00:07]             │ debg ... sleep(501) start
[00:00:08]             │ debg ... sleep(501) end
[00:00:08]             │ debg in navigateTo url = http://localhost:6141/app/resolverTest
[00:00:08]             │ debg TestSubjects.exists(statusPageContainer)
[00:00:08]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:00:11]             │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:00:11]             │ debg ======browser======== setWindowSize 3840 2400
[00:00:11]             │ debg ======browser======== actual initial screenshot size width=1200, height=800
[00:00:12]             │ debg ======browser======== actual second screenshot size width= 600, height=400
[00:00:12]             │ debg ======browser======== calculated values xBorder= 0, yBorder=0, xScaling=1, yScaling=1
[00:00:12]             │ debg ======browser======== setting browser size to 3840 x 2400
[00:00:13]             │ debg ======browser======== final screenshot size width=3840, height=2400
[00:00:13]           └-> renders at least one node
[00:00:13]             └-> "before each" hook: global before each
[00:00:13]             │ debg TestSubjects.exists(resolver:node)
[00:00:13]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:node"]') with timeout=120000
[00:00:13]             └- ✓ pass  (65ms) "Resolver test app renders at least one node"
[00:00:13]           └-> renders a node list
[00:00:13]             └-> "before each" hook: global before each
[00:00:13]             │ debg TestSubjects.exists(resolver:node-list)
[00:00:13]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:node-list"]') with timeout=120000
[00:00:13]             └- ✓ pass  (31ms) "Resolver test app renders a node list"
[00:00:13]           └-> renders at least one edge line
[00:00:13]             └-> "before each" hook: global before each
[00:00:13]             │ debg TestSubjects.exists(resolver:graph:edgeline)
[00:00:13]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:graph:edgeline"]') with timeout=120000
[00:00:13]             └- ✓ pass  (71ms) "Resolver test app renders at least one edge line"
[00:00:13]           └-> renders graph controls
[00:00:13]             └-> "before each" hook: global before each
[00:00:13]             │ debg TestSubjects.exists(resolver:graph-controls)
[00:00:13]             │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="resolver:graph-controls"]') with timeout=120000
[00:00:13]             └- ✓ pass  (27ms) "Resolver test app renders graph controls"
[00:00:13]           └-: when the user is interacting with the node with ID: origin
[00:00:13]             └-> "before all" hook
[00:00:40]           └-: when the user is interacting with the node with ID: secondChild
[00:00:40]             └-> "before all" hook
[00:00:40]             └-> should render as expected
[00:00:40]               └-> "before each" hook: global before each
[00:00:40]               └-> "before each" hook
[00:00:40]               │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:40]               │ debg compareAgainstBaseline
[00:00:40]               │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child.png"
[00:00:41]               │ debg comparePngs: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child.png vs /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/baseline/second_child.png
[00:00:41]               │ debg calculating diff pixels...
[00:00:41]               │ debg percent different: 0.046875
[00:00:41]               └- ✓ pass  (1.4s) "Resolver test app when the user is interacting with the node with ID: secondChild should render as expected"
[00:00:41]             └-: when the user hovers over the primary button
[00:00:41]               └-> "before all" hook
[00:00:41]               └-> should render as expected
[00:00:41]                 └-> "before each" hook: global before each
[00:00:41]                 └-> "before each" hook
[00:00:41]                 └-> "before each" hook
[00:00:41]                   │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:42]                 │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:42]                 │ debg compareAgainstBaseline
[00:00:42]                 │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_with_primary_button_hovered.png"
[00:00:43]                 │ debg comparePngs: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_with_primary_button_hovered.png vs /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/baseline/second_child_with_primary_button_hovered.png
[00:00:43]                 │ debg calculating diff pixels...
[00:00:43]                 │ debg percent different: 0.05201388888888889
[00:00:43]                 └- ✓ pass  (1.4s) "Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button should render as expected"
[00:00:43]               └-: when the user has clicked the primary button (which selects the node.)
[00:00:43]                 └-> "before all" hook
[00:00:43]                 └-> should render as expected
[00:00:43]                   └-> "before each" hook: global before each
[00:00:43]                   └-> "before each" hook
[00:00:43]                   └-> "before each" hook
[00:00:43]                     │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:43]                   └-> "before each" hook
[00:00:44]                   │ debg Find.findByCssSelector('[data-test-resolver-node-id="secondChild"]') with timeout=10000
[00:00:44]                   │ debg compareAgainstBaseline
[00:00:44]                   │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_selected_with_primary_button_hovered.png"
[00:00:46]                   │ debg comparePngs: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/session/second_child_selected_with_primary_button_hovered.png vs /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/baseline/second_child_selected_with_primary_button_hovered.png
[00:00:46]                   │ debg calculating diff pixels...
[00:00:46]                   │ debg percent different: 0.09585648148148149
[00:00:46]                   │ info Taking screenshot "/dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/screenshots/failure/Resolver test app when the user is interacting with the node with ID_ secondChild when the user hovers over the primary button when the user has clicked the primary button _which selects the node_ should render as expected.png"
[00:00:47]                   │ info Current URL is: http://localhost:6141/app/resolverTest?resolver-test=(panelParameters%3A(nodeID%3AsecondChild)%2CpanelView%3AnodeDetail)
[00:00:47]                   │ info Saving page source to: /dev/shm/workspace/parallel/4/kibana/x-pack/test/plugin_functional/failure_debug/html/Resolver test app when the user is interacting with the node with ID_ secondChild when the user hovers over the primary button when the user has clicked the primary button _which selects the node_ should render as expected.html
[00:00:47]                   └- ✖ fail: Resolver test app when the user is interacting with the node with ID: secondChild when the user hovers over the primary button when the user has clicked the primary button (which selects the node.) should render as expected
[00:00:47]                   │      Error: expected 0.09585648148148149 to be below 0.09
[00:00:47]                   │       at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:100:11)
[00:00:47]                   │       at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:336:8)
[00:00:47]                   │       at Function.lessThan (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:531:15)
[00:00:47]                   │       at Context.<anonymous> (test/plugin_functional/test_suites/resolver/index.ts:119:23)
[00:00:47]                   │       at Object.apply (/dev/shm/workspace/parallel/4/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)
[00:00:47]                   │ 
[00:00:47]                   │

Stack Trace

Error: expected 0.09585648148148149 to be below 0.09
    at Assertion.assert (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.lessThan.Assertion.below (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:336:8)
    at Function.lessThan (/dev/shm/workspace/parallel/4/kibana/packages/kbn-expect/expect.js:531:15)
    at Context.<anonymous> (test/plugin_functional/test_suites/resolver/index.ts:119:23)
    at Object.apply (/dev/shm/workspace/parallel/4/kibana/packages/kbn-test/src/functional_test_runner/lib/mocha/wrap_function.js:84:16)

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.4MB 5.4MB +63.0B

Distributable file count

id before after diff
default 47260 48020 +760

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ogupte ogupte merged commit c0eeb86 into elastic:master Jan 6, 2021
@ogupte ogupte mentioned this pull request Jan 6, 2021
Merged
ogupte added a commit to ogupte/kibana that referenced this pull request Jan 6, 2021
@ogupte @kibanamachine
Closes elastic#87026 by ensuring the user also has save privileges fo…
7bb3262 
…r APM (elastic#87343)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@ogupte ogupte mentioned this pull request Jan 6, 2021
Merged
ogupte added a commit to ogupte/kibana that referenced this pull request Jan 6, 2021
@ogupte @kibanamachine
Closes elastic#87026 by ensuring the user also has save privileges fo…
4b65d9f 
…r APM (elastic#87343)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@sorenlouv
Copy link
Copy Markdown
Contributor

sorenlouv commented Jan 6, 2021 •
edited
Loading

Thanks for doing this @ogupte! @cauemarcondes recently did something similar but instead of removing the link he disabled the submit button on the ui indices page if the user didn't have needed permissions.

@formgeist Do we have some guidelines around when to disable ui elements and when to hide the links to them?

Possible suggestion in the future: To make this consistent, instead of removing the link it should be greyed out. This makes it a little more clear that a particular action is available but just restricted for the current user.

@formgeist
Copy link
Copy Markdown
Contributor

formgeist commented Jan 6, 2021

I also prefer disabling over hiding - doesn't the alert flyout handle user permissions in some way with an empty prompt or similar? I haven't checked it out, just curious.

ogupte added a commit that referenced this pull request Jan 6, 2021
@ogupte @kibanamachine
Closes #87026 by ensuring the user also has save privileges for APM (#…
63de344 
…87343) (#87420)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
ogupte added a commit that referenced this pull request Jan 6, 2021
@ogupte @kibanamachine
Closes #87026 by ensuring the user also has save privileges for APM (#…
014c92a 
…87343) (#87421)

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smith smith smith approved these changes

Assignees

No one assigned

Labels

release_note:fix Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.11.0 v7.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[APM] Disable Alerts option for read only user

6 participants

@ogupte @elasticmachine @kibanamachine @sorenlouv @formgeist @smith